From: Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
To: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 0/2] User-index fixes
Date: Thu, 3 Mar 2016 11:57:49 +0200 [thread overview]
Message-ID: <56D80A9D.6030507@mellanox.com> (raw)
In-Reply-To: <56C49D8C.2000605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
On 17/2/2016 6:19 PM, Doug Ledford wrote:
> On 02/14/2016 11:35 AM, Matan Barak wrote:
>> From: Majd Dibbiny <majd-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> Hi Doug,
>>
>> This series fixes two issues introduced in 4.5 after applying my
>> series "Raw Packet QP user-space support for mlx5".
>>
>> SRQs don't use user-index, therefore the user shouldn't pass it and the
>> kernel shouldn't verify. The first patch fixes this by avoiding
>> user-index verification for non-xrc srqs.
>>
>> The mlx5_ib driver fails libraries that support user-index but don't
>> pass it. It relies on the input length of the vendor specific part to
>> determine whether the user-space supports user-index.
>>
>>
>> In Legacy verbs, the given vendor specific part input length is given
>> including struct ib_uverbs_cmd_hdr. In contrast, extended commands
>> pass the same length exluding the header size.
>> The vendor driver doesn't know whether the command is a legacy
>> command or an extended command. Thus, we need to modify IB/core
>> in order to pass a consistent size. The second patch fixes the input
>> length in the IB/core and the wrong usage in the mlx5_ib.
>>
>> We verified that other vendors don't use the inlen parameter and thus
>> won't break by this change.
>>
>> Thanks,
>> Majd and Matan
>>
>>
>> Majd Dibbiny (2):
>> IB/mlx5: Avoid using user-index for SRQs
>> IB/{core, mlx5}: Fix input len in vendor specific part of
>> create_qp/srq cmd
>>
>> drivers/infiniband/core/uverbs_cmd.c | 9 +++++---
>> drivers/infiniband/hw/mlx5/srq.c | 41 +++++++++++++++++++-----------------
>> 2 files changed, 28 insertions(+), 22 deletions(-)
>>
> These went in already in case you missed it. Thanks.
Hi Doug,
I can't see those patches in your git repositories.
Where were they applied to?
Thanks
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-03-03 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 16:35 [PATCH 0/2] User-index fixes Matan Barak
[not found] ` <1455467752-3170-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-02-14 16:35 ` [PATCH 1/2] IB/mlx5: Avoid using user-index for SRQs Matan Barak
2016-02-14 16:35 ` [PATCH 2/2] IB/{core, mlx5}: Fix input len in vendor specific part of create_qp/srq cmd Matan Barak
2016-02-17 16:19 ` [PATCH 0/2] User-index fixes Doug Ledford
[not found] ` <56C49D8C.2000605-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-03 9:57 ` Majd Dibbiny [this message]
[not found] ` <56D80A9D.6030507-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-03-03 15:08 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D80A9D.6030507@mellanox.com \
--to=majd-vpraknaxozvwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.