diff for duplicates of <56D86C5E.8050900@redhat.com> diff --git a/a/1.txt b/N1/1.txt index b40a851..7098d8a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -61,11 +61,11 @@ obvious what it is doing when you see it for the first time. > + > + token = rtas_token("get-time-of-day"); > + report("token available", token != RTAS_UNKNOWN_SERVICE); -> + if (token = RTAS_UNKNOWN_SERVICE) +> + if (token == RTAS_UNKNOWN_SERVICE) > + return; > + > + ret = rtas_call(token, 0, 8, now); -> + report("execution", ret = 0); +> + report("execution", ret == 0); > + > + report("second", now[5] >= 0 && now[5] <= 59); > + report("minute", now[4] >= 0 && now[4] <= 59); @@ -78,7 +78,7 @@ obvious what it is doing when you see it for the first time. > + > + ret = rtas_call(token, 0, 8, now); -Maybe make sure that ret = 0 here again? ... or you could simply omit +Maybe make sure that ret == 0 here again? ... or you could simply omit this call and recycle the results from the first rtas_call ? > + t1 = mktime(now[0], now[1], now[2], now[3], now[4], now[5]); @@ -90,7 +90,7 @@ this call and recycle the results from the first rtas_call ? > + } while (t1 + DELAY > t2 && count < MAX_LOOP); > + report("running", t1 + DELAY <= t2); -I think at least here you should add another "ret = 0" check again, +I think at least here you should add another "ret == 0" check again, just to be sure. > +} @@ -104,17 +104,17 @@ just to be sure. > + > + token = rtas_token("set-time-of-day"); > + report("token available", token != RTAS_UNKNOWN_SERVICE); -> + if (token = RTAS_UNKNOWN_SERVICE) +> + if (token == RTAS_UNKNOWN_SERVICE) > + return; > + > + /* 23:59:59 28/2/2000 */ > + > + ret = rtas_call(token, 7, 1, NULL, 2000, 2, 28, 23, 59, 59); -> + report("execution", ret = 0); +> + report("execution", ret == 0); > + > + /* check it has worked */ > + ret = rtas_call(rtas_token("get-time-of-day"), 0, 8, date); -> + report("re-read", ret = 0); +> + report("re-read", ret == 0); > + t1 = mktime(2000, 2, 28, 23, 59, 59); > + t2 = mktime(date[0], date[1], date[2], > + date[3], date[4], date[5]); @@ -130,7 +130,7 @@ just to be sure. > + } while (t1 + DELAY > t2 && count < MAX_LOOP); > + report("running", t1 + DELAY <= t2); -Please also add a check for "ret = 0" here ... just to be really, +Please also add a check for "ret == 0" here ... just to be really, really sure ;-) > +} diff --git a/a/content_digest b/N1/content_digest index 7371d62..b03fbca 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01457008099-29944-1-git-send-email-lvivier@redhat.com\0" "From\0Thomas Huth <thuth@redhat.com>\0" "Subject\0Re: [kvm-unit-tests PATCH] powerpc: Add tests for RTAS\0" - "Date\0Thu, 03 Mar 2016 16:54:54 +0000\0" + "Date\0Thu, 3 Mar 2016 17:54:54 +0100\0" "To\0Laurent Vivier <lvivier@redhat.com>" kvm@vger.kernel.org " kvm-ppc@vger.kernel.org\0" @@ -73,11 +73,11 @@ "> +\n" "> +\ttoken = rtas_token(\"get-time-of-day\");\n" "> +\treport(\"token available\", token != RTAS_UNKNOWN_SERVICE);\n" - "> +\tif (token = RTAS_UNKNOWN_SERVICE)\n" + "> +\tif (token == RTAS_UNKNOWN_SERVICE)\n" "> +\t\treturn;\n" "> +\n" "> +\tret = rtas_call(token, 0, 8, now);\n" - "> +\treport(\"execution\", ret = 0);\n" + "> +\treport(\"execution\", ret == 0);\n" "> +\n" "> +\treport(\"second\", now[5] >= 0 && now[5] <= 59);\n" "> +\treport(\"minute\", now[4] >= 0 && now[4] <= 59);\n" @@ -90,7 +90,7 @@ "> +\n" "> +\tret = rtas_call(token, 0, 8, now);\n" "\n" - "Maybe make sure that ret = 0 here again? ... or you could simply omit\n" + "Maybe make sure that ret == 0 here again? ... or you could simply omit\n" "this call and recycle the results from the first rtas_call ?\n" "\n" "> +\tt1 = mktime(now[0], now[1], now[2], now[3], now[4], now[5]);\n" @@ -102,7 +102,7 @@ "> +\t} while (t1 + DELAY > t2 && count < MAX_LOOP);\n" "> +\treport(\"running\", t1 + DELAY <= t2);\n" "\n" - "I think at least here you should add another \"ret = 0\" check again,\n" + "I think at least here you should add another \"ret == 0\" check again,\n" "just to be sure.\n" "\n" "> +}\n" @@ -116,17 +116,17 @@ "> +\n" "> +\ttoken = rtas_token(\"set-time-of-day\");\n" "> +\treport(\"token available\", token != RTAS_UNKNOWN_SERVICE);\n" - "> +\tif (token = RTAS_UNKNOWN_SERVICE)\n" + "> +\tif (token == RTAS_UNKNOWN_SERVICE)\n" "> +\t\treturn;\n" "> +\n" "> +\t/* 23:59:59 28/2/2000 */\n" "> +\n" "> +\tret = rtas_call(token, 7, 1, NULL, 2000, 2, 28, 23, 59, 59);\n" - "> +\treport(\"execution\", ret = 0);\n" + "> +\treport(\"execution\", ret == 0);\n" "> +\n" "> +\t/* check it has worked */\n" "> +\tret = rtas_call(rtas_token(\"get-time-of-day\"), 0, 8, date);\n" - "> +\treport(\"re-read\", ret = 0);\n" + "> +\treport(\"re-read\", ret == 0);\n" "> +\tt1 = mktime(2000, 2, 28, 23, 59, 59);\n" "> +\tt2 = mktime(date[0], date[1], date[2],\n" "> +\t\t date[3], date[4], date[5]);\n" @@ -142,7 +142,7 @@ "> +\t} while (t1 + DELAY > t2 && count < MAX_LOOP);\n" "> +\treport(\"running\", t1 + DELAY <= t2);\n" "\n" - "Please also add a check for \"ret = 0\" here ... just to be really,\n" + "Please also add a check for \"ret == 0\" here ... just to be really,\n" "really sure ;-)\n" "\n" "> +}\n" @@ -152,4 +152,4 @@ "\n" Thomas -b647a93363ecdeb946daf61ccb107fd98f8a20db6dab2dd32db52c9dac210973 +3c1587d4274a687cccd67af8abf984038eb9e6a21c55f33037cfb26392ffdc4d
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.