From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org,
thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2] dma: tegra: don't open code of_device_get_match_data()
Date: Fri, 4 Mar 2016 07:36:04 +0530 [thread overview]
Message-ID: <56D8ED8C.4090708@nvidia.com> (raw)
In-Reply-To: <20160303160021.GV11154@localhost>
On Thursday 03 March 2016 09:30 PM, Vinod Koul wrote:
> On Wed, Mar 02, 2016 at 07:59:26PM +0530, Laxman Dewangan wrote:
>> Use of_device_get_match_data() for getting matched data
>> instead of implementing this locally.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> Acked-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>>
>> ---
>> Changes form V1:
>> - Found that it is possible to move of_device_id table to down
>> where this is used i.e. just above the platform driver structure.
>> Make this change on V2.
> But that is just noise and not relevant to the title which patch says. If
> you want to do this code move please send that separately. I have picked v1
> for now
>
OK, fine with me. Will post another patch.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: <dan.j.williams@intel.com>, <swarren@wwwdotorg.org>,
<thierry.reding@gmail.com>, <gnurou@gmail.com>,
<dmaengine@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] dma: tegra: don't open code of_device_get_match_data()
Date: Fri, 4 Mar 2016 07:36:04 +0530 [thread overview]
Message-ID: <56D8ED8C.4090708@nvidia.com> (raw)
In-Reply-To: <20160303160021.GV11154@localhost>
On Thursday 03 March 2016 09:30 PM, Vinod Koul wrote:
> On Wed, Mar 02, 2016 at 07:59:26PM +0530, Laxman Dewangan wrote:
>> Use of_device_get_match_data() for getting matched data
>> instead of implementing this locally.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> Acked-by: Thierry Reding <treding@nvidia.com>
>>
>> ---
>> Changes form V1:
>> - Found that it is possible to move of_device_id table to down
>> where this is used i.e. just above the platform driver structure.
>> Make this change on V2.
> But that is just noise and not relevant to the title which patch says. If
> you want to do this code move please send that separately. I have picked v1
> for now
>
OK, fine with me. Will post another patch.
next prev parent reply other threads:[~2016-03-04 2:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 14:29 [PATCH V2] dma: tegra: don't open code of_device_get_match_data() Laxman Dewangan
2016-03-02 14:29 ` Laxman Dewangan
2016-03-03 16:00 ` Vinod Koul
2016-03-04 2:06 ` Laxman Dewangan [this message]
2016-03-04 2:06 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8ED8C.4090708@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=gnurou-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.