From: Vlastimil Babka <vbabka@suse.cz>
To: Li Zhang <zhlcindy@gmail.com>,
mpe@ellerman.id.au, khandual@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, mgorman@techsingularity.net
Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Li Zhang <zhlcindy@linux.vnet.ibm.com>
Subject: Re: [PATCH RFC 1/2] mm: meminit: initialise more memory for inode/dentry hash tables in early boot
Date: Fri, 4 Mar 2016 09:48:46 +0100 [thread overview]
Message-ID: <56D94BEE.1080506@suse.cz> (raw)
In-Reply-To: <1456988501-29046-2-git-send-email-zhlcindy@gmail.com>
On 03/03/2016 08:01 AM, Li Zhang wrote:
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -293,13 +293,20 @@ static inline bool update_defer_init(pg_data_t *pgdat,
> unsigned long pfn, unsigned long zone_end,
> unsigned long *nr_initialised)
> {
> + unsigned long max_initialise;
> +
> /* Always populate low zones for address-contrained allocations */
> if (zone_end < pgdat_end_pfn(pgdat))
> return true;
> + /*
> + * Initialise at least 2G of a node but also take into account that
> + * two large system hashes that can take up 1GB for 0.25TB/node.
> + */
The indentation is wrong here.
> + max_initialise = max(2UL << (30 - PAGE_SHIFT),
> + (pgdat->node_spanned_pages >> 8));
>
> - /* Initialise at least 2G of the highest zone */
> (*nr_initialised)++;
> - if (*nr_initialised > (2UL << (30 - PAGE_SHIFT)) &&
> + if ((*nr_initialised > max_initialise) &&
> (pfn & (PAGES_PER_SECTION - 1)) == 0) {
> pgdat->first_deferred_pfn = pfn;
> return false;
>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Li Zhang <zhlcindy@gmail.com>,
mpe@ellerman.id.au, khandual@linux.vnet.ibm.com,
aneesh.kumar@linux.vnet.ibm.com, mgorman@techsingularity.net
Cc: linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Li Zhang <zhlcindy@linux.vnet.ibm.com>
Subject: Re: [PATCH RFC 1/2] mm: meminit: initialise more memory for inode/dentry hash tables in early boot
Date: Fri, 4 Mar 2016 09:48:46 +0100 [thread overview]
Message-ID: <56D94BEE.1080506@suse.cz> (raw)
In-Reply-To: <1456988501-29046-2-git-send-email-zhlcindy@gmail.com>
On 03/03/2016 08:01 AM, Li Zhang wrote:
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -293,13 +293,20 @@ static inline bool update_defer_init(pg_data_t *pgdat,
> unsigned long pfn, unsigned long zone_end,
> unsigned long *nr_initialised)
> {
> + unsigned long max_initialise;
> +
> /* Always populate low zones for address-contrained allocations */
> if (zone_end < pgdat_end_pfn(pgdat))
> return true;
> + /*
> + * Initialise at least 2G of a node but also take into account that
> + * two large system hashes that can take up 1GB for 0.25TB/node.
> + */
The indentation is wrong here.
> + max_initialise = max(2UL << (30 - PAGE_SHIFT),
> + (pgdat->node_spanned_pages >> 8));
>
> - /* Initialise at least 2G of the highest zone */
> (*nr_initialised)++;
> - if (*nr_initialised > (2UL << (30 - PAGE_SHIFT)) &&
> + if ((*nr_initialised > max_initialise) &&
> (pfn & (PAGES_PER_SECTION - 1)) == 0) {
> pgdat->first_deferred_pfn = pfn;
> return false;
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2016-03-04 8:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-03 7:01 [PATCH RFC 0/2] mm: Enable page parallel initialisation for Power Li Zhang
2016-03-03 7:01 ` Li Zhang
2016-03-03 7:01 ` [PATCH RFC 1/2] mm: meminit: initialise more memory for inode/dentry hash tables in early boot Li Zhang
2016-03-03 7:01 ` Li Zhang
2016-03-03 8:34 ` Mel Gorman
2016-03-03 8:34 ` Mel Gorman
2016-03-03 9:41 ` Anshuman Khandual
2016-03-03 9:41 ` Anshuman Khandual
2016-03-04 5:21 ` Li Zhang
2016-03-04 5:21 ` Li Zhang
2016-03-04 8:48 ` Vlastimil Babka [this message]
2016-03-04 8:48 ` Vlastimil Babka
2016-03-04 13:52 ` Li Zhang
2016-03-04 13:52 ` Li Zhang
2016-03-03 7:01 ` [PATCH RFC 2/2] powerpc/mm: Enable page parallel initialisation Li Zhang
2016-03-03 7:01 ` Li Zhang
2016-03-03 8:34 ` Mel Gorman
2016-03-03 8:34 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2016-03-02 8:49 [PATCH RFC 0/2] mm: Enable page parallel initialisation for Power Li Zhang
2016-03-02 8:49 ` [PATCH RFC 1/2] mm: meminit: initialise more memory for inode/dentry hash tables in early boot Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D94BEE.1080506@suse.cz \
--to=vbabka@suse.cz \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@techsingularity.net \
--cc=mpe@ellerman.id.au \
--cc=zhlcindy@gmail.com \
--cc=zhlcindy@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.