All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suravee Suthikulpanit <Suravee.Suthikulpanit-5C7GfCeVMHo@public.gmane.org>
To: "Wan, Vincent" <Vincent.Wan-5C7GfCeVMHo@public.gmane.org>,
	Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
Cc: "Long, Gang" <Gang.Long-5C7GfCeVMHo@public.gmane.org>,
	"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org"
	<iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>,
	"Huang, Ray" <Ray.Huang-5C7GfCeVMHo@public.gmane.org>,
	Borislav Petkov <bp-l3A5Bk7waGM@public.gmane.org>,
	"Xue, Ken" <Ken.Xue-5C7GfCeVMHo@public.gmane.org>
Subject: Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support
Date: Sat, 5 Mar 2016 16:00:25 +0700	[thread overview]
Message-ID: <56DAA029.7040504@amd.com> (raw)
In-Reply-To: <CY1PR1201MB1019F37D828D88814896B798E6BE0-JBJ/M6OpXY8t7t9t4go5W2rFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>

Hi Joerg,

On 03/04/2016 03:49 PM, Wan, Vincent wrote:
>>> Joerg,
>>> Can you provide me which branch you are using to test those patches.
>>>
>>> We are validating the patches in v4.5.0-rc6, and no issues like your
>> description.
>>
>> I tested them on v4.5-rc5.
>>
> Thanks!
> We will test the patches basing on this v4.5-rc5 version again.
>
> Vincent.
>>
>> 	Joerg
>

I found the issue now. I'll work with Vincent to send out V3.

The problem is because in the information in the IOMMU Attributes field 
of the IVHD header type 40h (offset byte 20 = struct 
ivhd_header.efr_attr) is incorrect. It was correct in the IVHD type 
10h.... Sigh :(

However, the same information in the MMIO offset 4000h Counter 
configuration Register is correct. So, I'll try to have the patch get 
information from here instead.

Earlier, we had another issue with IOMMU PERF intialization, and it was 
disabled. So, it hides this bug when we were testing the patch earlier.
Now that we had a workaround for that bug n v4.5-rc5, it bombs in the 
init_iommu_perf_ctr().

So, if you want to test out the rest of this patch series, just simply 
comment out this function, and it should boot.

Regards,
Suravee

WARNING: multiple messages have this Message-ID (diff)
From: Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>
To: "Wan, Vincent" <Vincent.Wan@amd.com>, Joerg Roedel <joro@8bytes.org>
Cc: "iommu@lists.linux-foundation.org"
	<iommu@lists.linux-foundation.org>, Borislav Petkov <bp@suse.de>,
	"Huang, Ray" <Ray.Huang@amd.com>, "Xue, Ken" <Ken.Xue@amd.com>,
	"vw@iommu.org" <vw@iommu.org>,
	"mcuos.com@gmail.com" <mcuos.com@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Long, Gang" <Gang.Long@amd.com>
Subject: Re: [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support
Date: Sat, 5 Mar 2016 16:00:25 +0700	[thread overview]
Message-ID: <56DAA029.7040504@amd.com> (raw)
In-Reply-To: <CY1PR1201MB1019F37D828D88814896B798E6BE0@CY1PR1201MB1019.namprd12.prod.outlook.com>

Hi Joerg,

On 03/04/2016 03:49 PM, Wan, Vincent wrote:
>>> Joerg,
>>> Can you provide me which branch you are using to test those patches.
>>>
>>> We are validating the patches in v4.5.0-rc6, and no issues like your
>> description.
>>
>> I tested them on v4.5-rc5.
>>
> Thanks!
> We will test the patches basing on this v4.5-rc5 version again.
>
> Vincent.
>>
>> 	Joerg
>

I found the issue now. I'll work with Vincent to send out V3.

The problem is because in the information in the IOMMU Attributes field 
of the IVHD header type 40h (offset byte 20 = struct 
ivhd_header.efr_attr) is incorrect. It was correct in the IVHD type 
10h.... Sigh :(

However, the same information in the MMIO offset 4000h Counter 
configuration Register is correct. So, I'll try to have the patch get 
information from here instead.

Earlier, we had another issue with IOMMU PERF intialization, and it was 
disabled. So, it hides this bug when we were testing the patch earlier.
Now that we had a workaround for that bug n v4.5-rc5, it bombs in the 
init_iommu_perf_ctr().

So, if you want to test out the rest of this patch series, just simply 
comment out this function, and it should boot.

Regards,
Suravee

  parent reply	other threads:[~2016-03-05  9:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 23:14 [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support Wan Zongshun
2016-01-26 23:14 ` Wan Zongshun
     [not found] ` <1453850077-2539-1-git-send-email-vincent.wan-5C7GfCeVMHo@public.gmane.org>
2016-01-26 23:14   ` [PATCH V2 1/8] iommu/amd: Modify ivhd_header structure to support type 11h and 40h Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-01-26 23:14   ` [PATCH V2 2/8] iommu/amd: Use the most comprehensive IVHD type that the driver can support Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-01-26 23:14   ` [PATCH V2 3/8] iommu/amd: Add new map for storing IVHD dev entry type HID Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-01-26 23:14   ` [PATCH V2 4/8] iommu/amd: Introduces ivrs_acpihid kernel parameter Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-01-26 23:14   ` [PATCH V2 5/8] iommu/amd: Make call-sites of get_device_id aware of its return value Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-01-26 23:14   ` [PATCH V2 6/8] iommu/amd: Add iommu support for ACPI HID devices Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-01-26 23:14   ` [PATCH V2 7/8] iommu/amd: Manage iommu_group " Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-01-26 23:14   ` [PATCH V2 8/8] iommu/amd: Set AMD iommu callbacks for amba bus Wan Zongshun
2016-01-26 23:14     ` Wan Zongshun
2016-02-26 14:44   ` [PATCH V2 0/8] iommu/amd: enable ACPI hardware ID device support Joerg Roedel
2016-02-26 14:44     ` Joerg Roedel
     [not found]     ` <20160226144446.GG22747-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-03-04  1:52       ` Wan, Vincent
2016-03-04  1:52         ` Wan, Vincent
     [not found]         ` <DM3PR1201MB10235E51027C3330C9BAF888E6BE0-BBcFnVpqZhUfW+iVwtCNz2rFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-03-04  8:46           ` Joerg Roedel
2016-03-04  8:46             ` Joerg Roedel
     [not found]             ` <20160304084624.GA21839-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2016-03-04  8:49               ` Wan, Vincent
2016-03-04  8:49                 ` Wan, Vincent
     [not found]                 ` <CY1PR1201MB1019F37D828D88814896B798E6BE0-JBJ/M6OpXY8t7t9t4go5W2rFom/aUZj6nBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-03-05  9:00                   ` Suravee Suthikulpanit [this message]
2016-03-05  9:00                     ` Suravee Suthikulpanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DAA029.7040504@amd.com \
    --to=suravee.suthikulpanit-5c7gfcevmho@public.gmane.org \
    --cc=Gang.Long-5C7GfCeVMHo@public.gmane.org \
    --cc=Ken.Xue-5C7GfCeVMHo@public.gmane.org \
    --cc=Ray.Huang-5C7GfCeVMHo@public.gmane.org \
    --cc=Vincent.Wan-5C7GfCeVMHo@public.gmane.org \
    --cc=bp-l3A5Bk7waGM@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.