Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic

All of lore.kernel.org
 help / color / mirror / Atom feed

From: f6bvp <f6bvp@free.fr>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, ralf@linux-mips.org,
	"Eric W. Biederman\"" <ebiederm@xmission.com>,
	linux-hams@vger.kernel.org,
	Bernard Pidoux <bernard.pidoux@free.fr>
Subject: Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic
Date: Sun, 6 Mar 2016 11:58:35 +0100	[thread overview]
Message-ID: <56DC0D5B.1040408@free.fr> (raw)
In-Reply-To: <56DC0B8A.5030708@free.fr>

Fran√ßois,

Thank you for providing information about rose_rebuild_header history.
I was not able to find Jonathan Naylor G4KLX email.
However as rose_xmit() has been recently changed by Eric Biederman, he
may have more precise information about rose_route_frame()
NULL argument.
Meanwhile, I browsed into rose_route.c release 001 you referenced and found
an interesting comment before rose_route_frame() :
+/*
+ * Route a frame to an appropriate AX.25 connection. A NULL ax25_cb
+ * indicates an internally generated frame.
+ */
+int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25)

Now, I hope that ROSE guru will explain us what means an "internally
generated frame" and if, by chance, it means that it is not to be sent
via a net device, but rather to be used locally ?

Bernard

--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: f6bvp <f6bvp@free.fr>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: David Miller <davem@davemloft.net>,
	netdev@vger.kernel.org, ralf@linux-mips.org,
	"Eric W. Biederman\"" <ebiederm@xmission.com>,
	linux-hams@vger.kernel.org,
	Bernard Pidoux <bernard.pidoux@free.fr>
Subject: Re: [Patch] rose_route_frame() NULL pointer dereference kernel panic
Date: Sun, 6 Mar 2016 11:58:35 +0100	[thread overview]
Message-ID: <56DC0D5B.1040408@free.fr> (raw)
In-Reply-To: <56DC0B8A.5030708@free.fr>

François,

Thank you for providing information about rose_rebuild_header history.
I was not able to find Jonathan Naylor G4KLX email.
However as rose_xmit() has been recently changed by Eric Biederman, he
may have more precise information about rose_route_frame()
NULL argument.
Meanwhile, I browsed into rose_route.c release 001 you referenced and found
an interesting comment before rose_route_frame() :
+/*
+ * Route a frame to an appropriate AX.25 connection. A NULL ax25_cb
+ * indicates an internally generated frame.
+ */
+int rose_route_frame(struct sk_buff *skb, ax25_cb *ax25)

Now, I hope that ROSE guru will explain us what means an "internally
generated frame" and if, by chance, it means that it is not to be sent
via a net device, but rather to be used locally ?

Bernard

--
To unsubscribe from this list: send the line "unsubscribe linux-hams" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

next prev parent reply	other threads:[~2016-03-06 10:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 16:53 [Patch] rose_route_frame() NULL pointer dereference kernel panic f6bvp
2016-02-25 22:09 ` David Miller
2016-03-01 20:37   ` f6bvp
2016-03-03 22:02     ` David Miller
2016-03-05 15:32       ` f6bvp
2016-03-05 16:22         ` David Miller
2016-03-05 17:32           ` f6bvp
2016-03-05 19:57             ` Francois Romieu
     [not found]               ` <56DC0B8A.5030708@free.fr>
2016-03-06 10:58                 ` f6bvp [this message]
2016-03-06 10:58                   ` f6bvp
  -- strict thread matches above, loose matches on Subject: below --
2016-02-21 15:26 f6bvp
2016-03-02 12:30 ` f6bvp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DC0D5B.1040408@free.fr \
    --to=f6bvp@free.fr \
    --cc=bernard.pidoux@free.fr \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=linux-hams@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    --cc=romieu@fr.zoreil.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.