From: Florian Fainelli <f.fainelli@gmail.com>
To: Vladimir Zapolskiy <vz@mleia.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Gregory Fong <gregory.0xf0@gmail.com>,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] pwm: bcm7038: fix check of error code returned by devm_ioremap_resource()
Date: Sun, 6 Mar 2016 17:15:52 -0800 [thread overview]
Message-ID: <56DCD648.5000600@gmail.com> (raw)
In-Reply-To: <1457227306-3142-1-git-send-email-vz@mleia.com>
Le 05/03/2016 17:21, Vladimir Zapolskiy a écrit :
> The change fixes potential oops while accessing iomem on invalid
> address, if devm_ioremap_resource() fails due to some reason.
>
> The devm_ioremap_resource() function returns ERR_PTR() and never
> returns NULL, which makes useless a following check for NULL.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Fixes: 3a9f5957020f ("pwm: Add Broadcom BCM7038 PWM controller support")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Using pwm: brcmstb for the subject might be a better fit to match the
filename, but this is bike shedding.
--
Florian
WARNING: multiple messages have this Message-ID (diff)
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pwm: bcm7038: fix check of error code returned by devm_ioremap_resource()
Date: Sun, 6 Mar 2016 17:15:52 -0800 [thread overview]
Message-ID: <56DCD648.5000600@gmail.com> (raw)
In-Reply-To: <1457227306-3142-1-git-send-email-vz@mleia.com>
Le 05/03/2016 17:21, Vladimir Zapolskiy a ?crit :
> The change fixes potential oops while accessing iomem on invalid
> address, if devm_ioremap_resource() fails due to some reason.
>
> The devm_ioremap_resource() function returns ERR_PTR() and never
> returns NULL, which makes useless a following check for NULL.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Fixes: 3a9f5957020f ("pwm: Add Broadcom BCM7038 PWM controller support")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Using pwm: brcmstb for the subject might be a better fit to match the
filename, but this is bike shedding.
--
Florian
next prev parent reply other threads:[~2016-03-07 1:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 1:21 [PATCH] pwm: bcm7038: fix check of error code returned by devm_ioremap_resource() Vladimir Zapolskiy
2016-03-06 1:21 ` Vladimir Zapolskiy
2016-03-07 1:15 ` Florian Fainelli [this message]
2016-03-07 1:15 ` Florian Fainelli
2016-03-07 9:19 ` Thierry Reding
2016-03-07 9:19 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DCD648.5000600@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=computersforpeace@gmail.com \
--cc=gregory.0xf0@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.