From: Vlastimil Babka <vbabka@suse.cz>
To: Dan Williams <dan.j.williams@intel.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: ZONE_DEVICE depends on SPARSEMEM_VMEMMAP
Date: Mon, 7 Mar 2016 10:53:35 +0100 [thread overview]
Message-ID: <56DD4F9F.303@suse.cz> (raw)
In-Reply-To: <20160305004214.12356.32017.stgit@dwillia2-desk3.jf.intel.com>
On 03/05/2016 01:42 AM, Dan Williams wrote:
> The primary use case for devm_memremap_pages() is to allocate an
> memmap array from persistent memory. That capabilty requires
> vmem_altmap which requires SPARSEMEM_VMEMMAP.
Some if the ifdefs around to_vmem_altmap() could now be simplified, but
that can also be done later...
> Also, without SPARSEMEM_VMEMMAP the addition of ZONE_DEVICE expands
> ZONES_WIDTH and triggers the:
>
> "Unfortunate NUMA and NUMA Balancing config, growing page-frame for
> last_cpupid."
>
> ...warning in mm/memory.c. SPARSEMEM_VMEMMAP=n && ZONE_DEVICE=y is not
> a configuration we should worry about supporting.
>
> Reported-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 664fa2416909..b95322ba542b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -654,6 +654,7 @@ config ZONE_DEVICE
> bool "Device memory (pmem, etc...) hotplug support" if EXPERT
> depends on MEMORY_HOTPLUG
> depends on MEMORY_HOTREMOVE
> + depends on SPARSEMEM_VMEMMAP
> depends on X86_64 #arch_add_memory() comprehends device memory
>
> help
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Dan Williams <dan.j.williams@intel.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: ZONE_DEVICE depends on SPARSEMEM_VMEMMAP
Date: Mon, 7 Mar 2016 10:53:35 +0100 [thread overview]
Message-ID: <56DD4F9F.303@suse.cz> (raw)
In-Reply-To: <20160305004214.12356.32017.stgit@dwillia2-desk3.jf.intel.com>
On 03/05/2016 01:42 AM, Dan Williams wrote:
> The primary use case for devm_memremap_pages() is to allocate an
> memmap array from persistent memory. That capabilty requires
> vmem_altmap which requires SPARSEMEM_VMEMMAP.
Some if the ifdefs around to_vmem_altmap() could now be simplified, but
that can also be done later...
> Also, without SPARSEMEM_VMEMMAP the addition of ZONE_DEVICE expands
> ZONES_WIDTH and triggers the:
>
> "Unfortunate NUMA and NUMA Balancing config, growing page-frame for
> last_cpupid."
>
> ...warning in mm/memory.c. SPARSEMEM_VMEMMAP=n && ZONE_DEVICE=y is not
> a configuration we should worry about supporting.
>
> Reported-by: Vlastimil Babka <vbabka@suse.cz>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 664fa2416909..b95322ba542b 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -654,6 +654,7 @@ config ZONE_DEVICE
> bool "Device memory (pmem, etc...) hotplug support" if EXPERT
> depends on MEMORY_HOTPLUG
> depends on MEMORY_HOTREMOVE
> + depends on SPARSEMEM_VMEMMAP
> depends on X86_64 #arch_add_memory() comprehends device memory
>
> help
>
next prev parent reply other threads:[~2016-03-07 9:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 0:42 [PATCH] mm: ZONE_DEVICE depends on SPARSEMEM_VMEMMAP Dan Williams
2016-03-05 0:42 ` Dan Williams
2016-03-07 9:53 ` Vlastimil Babka [this message]
2016-03-07 9:53 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DD4F9F.303@suse.cz \
--to=vbabka@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.