From: Yang Shi <yang.shi@windriver.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <tglx@linutronix.de>, <rostedt@goodmis.org>,
<linux-kernel@vger.kernel.org>, <linux-rt-users@vger.kernel.org>
Subject: Re: [4.4-rt PATCH] trace: use rcuidle version for preemptoff_hist trace point
Date: Mon, 7 Mar 2016 15:44:53 -0800 [thread overview]
Message-ID: <56DE1275.9030309@windriver.com> (raw)
In-Reply-To: <20160307180009.GF12595@linutronix.de>
On 3/7/2016 10:00 AM, Sebastian Andrzej Siewior wrote:
> * Yang Shi | 2016-02-23 13:23:23 [-0800]:
>
>> I recall the rcuidle version is used by 4.1-rt, but not sure why it is dropped
>> in 4.4-rt. It looks such fix is still needed.
> I don't recall while I removed it. It was durring v4.1 -> v4.4 port. In
> v4.1 we had the idle version only in time_hardirqs_on() + …_off(). You
> introduced it also to start_critical_timings() + stop_…(). Is this
> required?
Yes, the test showed the same problem in start{stop}_critical_timings too.
> In the meantime I bring back the empty macro of
> trace_preemptirqsoff_hist_rcuidle() back in -RT sine it breaks compile
> latest v4.4.3-RT9
Yes, sorry to forget to bring this in too. The 4.1 patch was submitted
by me, but forgot to have it in 4.4.
Yang
>
>> kernel/trace/trace_irqsoff.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
>> index 36e584f..069942c 100644
>> --- a/kernel/trace/trace_irqsoff.c
>> +++ b/kernel/trace/trace_irqsoff.c
>> @@ -421,13 +421,13 @@ void start_critical_timings(void)
>> {
>> if (preempt_trace() || irq_trace())
>> start_critical_timing(CALLER_ADDR0, CALLER_ADDR1);
>> - trace_preemptirqsoff_hist(TRACE_START, 1);
>> + trace_preemptirqsoff_hist_rcuidle(TRACE_START, 1);
>> }
>> EXPORT_SYMBOL_GPL(start_critical_timings);
>>
>> void stop_critical_timings(void)
>> {
>> - trace_preemptirqsoff_hist(TRACE_STOP, 0);
>> + trace_preemptirqsoff_hist_rcuidle(TRACE_STOP, 0);
>> if (preempt_trace() || irq_trace())
>> stop_critical_timing(CALLER_ADDR0, CALLER_ADDR1);
>> }
> Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Yang Shi <yang.shi@windriver.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: <tglx@linutronix.de>, <rostedt@goodmis.org>,
<linux-kernel@vger.kernel.org>, <linux-rt-users@vger.kernel.org>
Subject: Re: [4.4-rt PATCH] trace: use rcuidle version for preemptoff_hist trace point
Date: Mon, 7 Mar 2016 15:44:53 -0800 [thread overview]
Message-ID: <56DE1275.9030309@windriver.com> (raw)
In-Reply-To: <20160307180009.GF12595@linutronix.de>
On 3/7/2016 10:00 AM, Sebastian Andrzej Siewior wrote:
> * Yang Shi | 2016-02-23 13:23:23 [-0800]:
>
>> I recall the rcuidle version is used by 4.1-rt, but not sure why it is dropped
>> in 4.4-rt. It looks such fix is still needed.
> I don't recall while I removed it. It was durring v4.1 -> v4.4 port. In
> v4.1 we had the idle version only in time_hardirqs_on() + …_off(). You
> introduced it also to start_critical_timings() + stop_…(). Is this
> required?
Yes, the test showed the same problem in start{stop}_critical_timings too.
> In the meantime I bring back the empty macro of
> trace_preemptirqsoff_hist_rcuidle() back in -RT sine it breaks compile
> latest v4.4.3-RT9
Yes, sorry to forget to bring this in too. The 4.1 patch was submitted
by me, but forgot to have it in 4.4.
Yang
>
>> kernel/trace/trace_irqsoff.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/trace/trace_irqsoff.c b/kernel/trace/trace_irqsoff.c
>> index 36e584f..069942c 100644
>> --- a/kernel/trace/trace_irqsoff.c
>> +++ b/kernel/trace/trace_irqsoff.c
>> @@ -421,13 +421,13 @@ void start_critical_timings(void)
>> {
>> if (preempt_trace() || irq_trace())
>> start_critical_timing(CALLER_ADDR0, CALLER_ADDR1);
>> - trace_preemptirqsoff_hist(TRACE_START, 1);
>> + trace_preemptirqsoff_hist_rcuidle(TRACE_START, 1);
>> }
>> EXPORT_SYMBOL_GPL(start_critical_timings);
>>
>> void stop_critical_timings(void)
>> {
>> - trace_preemptirqsoff_hist(TRACE_STOP, 0);
>> + trace_preemptirqsoff_hist_rcuidle(TRACE_STOP, 0);
>> if (preempt_trace() || irq_trace())
>> stop_critical_timing(CALLER_ADDR0, CALLER_ADDR1);
>> }
> Sebastian
next prev parent reply other threads:[~2016-03-07 23:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 21:23 [4.4-rt PATCH] trace: use rcuidle version for preemptoff_hist trace point Yang Shi
2016-02-26 10:25 ` Sebastian Andrzej Siewior
2016-02-26 14:54 ` Steven Rostedt
2016-03-07 18:00 ` Sebastian Andrzej Siewior
2016-03-07 18:00 ` Sebastian Andrzej Siewior
2016-03-07 23:44 ` Yang Shi [this message]
2016-03-07 23:44 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DE1275.9030309@windriver.com \
--to=yang.shi@windriver.com \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.