All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>, zhangchen.fnst@cn.fujitsu.com
Subject: Re: [Qemu-devel] [PULL 00/14] Net patches
Date: Tue, 8 Mar 2016 15:33:03 +0800	[thread overview]
Message-ID: <56DE802F.2060502@redhat.com> (raw)
In-Reply-To: <CAFEAcA-7+pZFO6_p-w_95BB1fmU9hVdV-Z6V_xqyqOfOQ+ktgQ@mail.gmail.com>



On 03/08/2016 12:51 PM, Peter Maydell wrote:
> On 7 March 2016 at 10:12, Jason Wang <jasowang@redhat.com> wrote:
>> The following changes since commit 1464ad45cd6cdeb0b5c1a54d3d3791396e47e52f:
>>
>>   Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2016-03-04' into staging (2016-03-06 11:53:27 +0000)
>>
>> are available in the git repository at:
>>
>>   https://github.com/jasowang/qemu.git tags/net-pull-request
>>
>> for you to fetch changes up to a2f2e45c6edbba9e1961056fa77c696208b40c8e:
>>
>>   net: check packet payload length (2016-03-07 10:15:48 +0800)
>>
>> ----------------------------------------------------------------
>>
>> - a new netfilter implementation: mirror
>> - netfilter could be disabled and enabled through qom-set now
>> - fix netfilter crash when specifiying wrong parameters
>> - rocker switch now can allow user to specifiy world
>> - fix OOB access for ne2000
> Hi; I'm afraid this makes "make check" hang for me (Linux, x86-64):
>
> TEST: tests/test-netfilter... (pid=26854)
>   /i386/netfilter/addremove_one:                                       OK
>   /i386/netfilter/remove_netdev_one:                                   OK
>   /i386/netfilter/addremove_multi:                                     OK
>   /i386/netfilter/remove_netdev_multi:                                 OK
> PASS: tests/test-netfilter
> TEST: tests/test-filter-mirror... (pid=26858)
>   /i386/netfilter/mirror:
>
> (consistently, every time I run make check, on the same test).
>
> thanks
> -- PMM

Sorry, it manages to pass on my machine before submitting the pull
request. But when I re-try this several times, it fails.

This probably means we have bug in mirror implementation. Chen and
Congyang, please try to fix this bug and resubmit a new version of the
patch.

Will drop mirror from this pull request and submit a V2.

Thanks

  reply	other threads:[~2016-03-08  7:33 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-07  3:12 [Qemu-devel] [PULL 00/14] Net patches Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 01/14] net: ne2000: check ring buffer control registers Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 02/14] net: filter: correctly remove filter from the list during finalization Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 03/14] MAINTAINERS: Add entries for include/net/ files Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 04/14] net: simplify net_init_tap_one logic Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 05/14] net/filter-mirror:Add filter-mirror Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 06/14] tests/test-filter-mirror:add filter-mirror unit test Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 07/14] net: netmap: probe netmap interface for virtio-net header Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 08/14] rocker: forbid to change world type Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 09/14] rocker: return -ENOMEM in case of some world alloc fails Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 10/14] rocker: add name field into WorldOps ale let world specify its name Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 11/14] rocker: allow user to specify rocker world by property Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 12/14] filter: Add 'status' property for filter object Jason Wang
2016-03-07  3:12 ` [Qemu-devel] [PULL 13/14] filter-buffer: Add status_changed callback processing Jason Wang
2016-03-07  3:13 ` [Qemu-devel] [PULL 14/14] net: check packet payload length Jason Wang
2016-03-08  4:51 ` [Qemu-devel] [PULL 00/14] Net patches Peter Maydell
2016-03-08  7:33   ` Jason Wang [this message]
2016-03-08  7:50     ` Wen Congyang
2016-03-08  7:56       ` Jason Wang
2016-03-08  9:06         ` Zhang Chen
2016-03-08  9:13           ` Wen Congyang
2016-03-08  9:54           ` Peter Maydell
2016-03-09  1:36             ` Wen Congyang
2016-03-09  4:26               ` Li Zhijian
2016-03-09  5:24                 ` Wen Congyang
2016-03-15  3:15                 ` Jason Wang
2016-03-10  2:28             ` Jason Wang
2016-03-10  3:51               ` Li Zhijian
2016-03-15  3:07                 ` Jason Wang
2016-03-15  3:25                   ` Li Zhijian
  -- strict thread matches above, loose matches on Subject: below --
2017-07-17 12:21 Jason Wang
2017-07-18  9:34 ` Peter Maydell
2015-10-12  8:17 Jason Wang
2015-10-12 14:52 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56DE802F.2060502@redhat.com \
    --to=jasowang@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.