[master][PATCH] ARMv8 32-bit compiler tunings

All of lore.kernel.org
 help / color / mirror / Atom feed

* [master][PATCH] ARMv8 32-bit compiler tunings
@ 2016-03-07 14:34 Daniel Dragomir
  2016-03-07 14:34 ` [PATCH][master] Add tune for 32-bit ARMv8-a Daniel Dragomir
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Dragomir @ 2016-03-07 14:34 UTC (permalink / raw)
  To: openembedded-core; +Cc: otavio.salvador

Hello!

This is a new version for the patch, against master branch:
http://lists.openembedded.org/pipermail/openembedded-core/2016-February/117603.html

@Martin, I pushed the results from testing with your script in a personal repo:
Tune results without the patch - clean open-embedded (master branch):
	https://github.com/ddragomi/tune_test/tree/3f4054dd96e9d96c18e1eb9c5fef9f5ebc77f4a3/tune

Tune results with this patch:
	https://github.com/ddragomi/tune_test/tree/ff9c904fa6fff38efdc72c604e6d5677b64f76a5/tune

And a diff between those here:
        https://github.com/ddragomi/tune_test/commit/ff9c904fa6fff38efdc72c604e6d5677b64f76a5

NOTE: I also added a new fake-machine (axxiaarm) that require arch-arm8a.inc
to test/parse armv8a tunes:
DEFAULTTUNE ?= "armv8a-neon"
require conf/machine/include/arm/arch-armv8a.inc

Previous message:
Starting with linux-yocto-4.1, Intel provides kernel support for its
ARM v8 Axxia platforms, both on 32-bit and 64-bit.
Poky already contains arm 64-bit compiler tunings, so I added 32-bit
tunings based on those for armv7.

The patch that I send you is a draft. Please review it and if it's ok
I will return with thumb and big-endian tunings.

Daniel Dragomir (1):
  Add tune for 32-bit ARMv8-a

 meta/conf/machine/include/arm/arch-armv8a.inc      | 111 +++++++++++++++++++++
 .../conf/machine/include/arm/feature-arm-thumb.inc |   1 +
 2 files changed, 112 insertions(+)
 create mode 100644 meta/conf/machine/include/arm/arch-armv8a.inc

-- 
1.9.1



^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH][master] Add tune for 32-bit ARMv8-a
  2016-03-07 14:34 [master][PATCH] ARMv8 32-bit compiler tunings Daniel Dragomir
@ 2016-03-07 14:34 ` Daniel Dragomir
  2016-03-08  0:55   ` Otavio Salvador
  0 siblings, 1 reply; 6+ messages in thread
From: Daniel Dragomir @ 2016-03-07 14:34 UTC (permalink / raw)
  To: openembedded-core; +Cc: otavio.salvador

This patch adds tunes for 32-bit armv8 platforms. The user can select
the vector floating-point instruction set: vfpv4 or fp-armv8
and the thumb, neon, crc and crypto extensions.

Signed-off-by: Daniel Dragomir <daniel.dragomir@windriver.com>
---
 meta/conf/machine/include/arm/arch-armv8a.inc      | 111 +++++++++++++++++++++
 .../conf/machine/include/arm/feature-arm-thumb.inc |   1 +
 2 files changed, 112 insertions(+)
 create mode 100644 meta/conf/machine/include/arm/arch-armv8a.inc

diff --git a/meta/conf/machine/include/arm/arch-armv8a.inc b/meta/conf/machine/include/arm/arch-armv8a.inc
new file mode 100644
index 0000000..d4fb830
--- /dev/null
+++ b/meta/conf/machine/include/arm/arch-armv8a.inc
@@ -0,0 +1,111 @@
+DEFAULTTUNE ?= "armv8a"
+
+TUNEVALID[armv8a] = "Enable instructions for ARMv8-a"
+TUNECONFLICTS[armv8a] = "armv4 armv5 armv6 armv7 armv7a armv7ve"
+
+TUNEVALID[crc] = "Enable CRC instructions for ARMv8-a"
+ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "crc", "-crc", "", d)}"
+
+TUNEVALID[crypto] = "Enable ARMv8 crypto extension."
+ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "crypto", "-crypto", "", d)}"
+
+TUNEVALID[fp-armv8] = "Enable ARMv8 Vector Floating Point unit."
+ARMPKGSFX_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fp-armv8", "-fp-armv8", "", d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "armv8a", bb.utils.contains("TUNE_FEATURES", "crc", " -march=armv8-a+crc", " -march=armv8-a", d), "", d)}"
+
+TUNE_CCARGS .= "${@bb.utils.contains("TUNE_FEATURES", "fp-armv8", bb.utils.contains("TUNE_FEATURES", "neon", bb.utils.contains("TUNE_FEATURES", "crypto", " -mfpu=crypto-neon-fp-armv8", " -mfpu=neon-fp-armv8", d), " -mfpu=fp-armv8", d), "", d)}"
+
+MACHINEOVERRIDES =. "${@bb.utils.contains("TUNE_FEATURES", "armv8a", "armv8a:", "" ,d)}"
+
+require conf/machine/include/arm/arch-armv7ve.inc
+
+# Little Endian base configs
+AVAILTUNES += "armv8a armv8at armv8a-neon armv8at-neon armv8a-vfpv4 armv8at-vfpv4 armv8a-vfpv4-neon armv8at-vfpv4-neon armv8a-fp-armv8 armv8at-fp-armv8 armv8a-fp-armv8-neon armv8at-fp-armv8-neon armv8a-crypto-fp-armv8-neon armv8at-crypto-fp-armv8-neon"
+ARMPKGARCH_tune-armv8a                       ?= "armv8a"
+ARMPKGARCH_tune-armv8at                      ?= "armv8a"
+ARMPKGARCH_tune-armv8a-neon                  ?= "armv8a"
+ARMPKGARCH_tune-armv8at-neon                 ?= "armv8a"
+ARMPKGARCH_tune-armv8a-vfpv4                 ?= "armv8a"
+ARMPKGARCH_tune-armv8at-vfpv4                ?= "armv8a"
+ARMPKGARCH_tune-armv8a-vfpv4-neon            ?= "armv8a"
+ARMPKGARCH_tune-armv8at-vfpv4-neon           ?= "armv8a"
+ARMPKGARCH_tune-armv8a-fp-armv8              ?= "armv8a"
+ARMPKGARCH_tune-armv8at-fp-armv8             ?= "armv8a"
+ARMPKGARCH_tune-armv8a-fp-armv8-neon         ?= "armv8a"
+ARMPKGARCH_tune-armv8at-fp-armv8-neon        ?= "armv8a"
+ARMPKGARCH_tune-armv8a-crypto-fp-armv8-neon  ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crypto-fp-armv8-neon ?= "armv8a"
+TUNE_FEATURES_tune-armv8a                       = "arm armv8a vfp"
+TUNE_FEATURES_tune-armv8at                      = "${TUNE_FEATURES_tune-armv8a} thumb"
+TUNE_FEATURES_tune-armv8a-neon                  = "${TUNE_FEATURES_tune-armv8a} neon"
+TUNE_FEATURES_tune-armv8at-neon                 = "${TUNE_FEATURES_tune-armv8at} neon"
+TUNE_FEATURES_tune-armv8a-vfpv4                 = "${TUNE_FEATURES_tune-armv8a} vfpv4"
+TUNE_FEATURES_tune-armv8at-vfpv4                = "${TUNE_FEATURES_tune-armv8at} vfpv4"
+TUNE_FEATURES_tune-armv8a-vfpv4-neon            = "${TUNE_FEATURES_tune-armv8a-neon} vfpv4"
+TUNE_FEATURES_tune-armv8at-vfpv4-neon           = "${TUNE_FEATURES_tune-armv8at-neon} vfpv4"
+TUNE_FEATURES_tune-armv8a-fp-armv8              = "${TUNE_FEATURES_tune-armv8a} fp-armv8"
+TUNE_FEATURES_tune-armv8at-fp-armv8             = "${TUNE_FEATURES_tune-armv8at} fp-armv8"
+TUNE_FEATURES_tune-armv8a-fp-armv8-neon         = "${TUNE_FEATURES_tune-armv8a-neon} fp-armv8"
+TUNE_FEATURES_tune-armv8at-fp-armv8-neon        = "${TUNE_FEATURES_tune-armv8at-neon} fp-armv8"
+TUNE_FEATURES_tune-armv8a-crypto-fp-armv8-neon  = "${TUNE_FEATURES_tune-armv8a-fp-armv8-neon} crypto"
+TUNE_FEATURES_tune-armv8at-crypto-fp-armv8-neon = "${TUNE_FEATURES_tune-armv8at-fp-armv8-neon} crypto"
+PACKAGE_EXTRA_ARCHS_tune-armv8a                       = "${PACKAGE_EXTRA_ARCHS_tune-armv7ve} armv8a armv8a-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv8at                      = "${PACKAGE_EXTRA_ARCHS_tune-armv7vet2} armv8a armv8a-vfp armv8at2-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-neon                  = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} armv8a-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-neon                 = "${PACKAGE_EXTRA_ARCHS_tune-armv8at} armv8a-neon armv8at2-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-vfpv4                 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} armv8a-vfpv4"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-vfpv4                = "${PACKAGE_EXTRA_ARCHS_tune-armv8at} armv8a-vfpv4 armv8at2-vfpv4"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-vfpv4-neon            = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-vfpv4} armv8a-neon armv8a-neon-vfpv4"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-vfpv4-neon           = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-vfpv4} armv8a-neon armv8at2-neon armv8a-neon-vfpv4 armv8at2-neon-vfpv4"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-fp-armv8              = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} armv8a-fp-armv8"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-fp-armv8             = "${PACKAGE_EXTRA_ARCHS_tune-armv8at} armv8a-fp-armv8 armv8at2-fp-armv8"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-fp-armv8-neon         = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-fp-armv8} armv8a-neon armv8a-fp-armv8-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-fp-armv8-neon        = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-fp-armv8} armv8a-neon armv8at2-neon armv8a-fp-armv8-neon armv8at2-fp-armv8-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto-fp-armv8-neon  = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-fp-armv8-neon} armv8a-crypto-fp-armv8-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crypto-fp-armv8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-fp-armv8-neon} armv8a-crypto-fp-armv8-neon armv8at2-crypto-fp-armv8-neon"
+
+# CRC configs
+AVAILTUNES += "armv8a-crc armv8at-crc armv8a-crc-neon armv8at-crc-neon armv8a-crc-vfpv4 armv8at-crc-vfpv4 armv8a-crc-vfpv4-neon armv8at-crc-vfpv4-neon armv8a-crc-fp-armv8 armv8at-crc-fp-armv8 armv8a-crc-fp-armv8-neon armv8at-crc-fp-armv8-neon armv8a-crc-crypto-fp-armv8-neon armv8at-crc-crypto-fp-armv8-neon"
+ARMPKGARCH_tune-armv8a-crc                       ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crc                      ?= "armv8a"
+ARMPKGARCH_tune-armv8a-crc-neon                  ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crc-neon                 ?= "armv8a"
+ARMPKGARCH_tune-armv8a-crc-vfpv4                 ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crc-vfpv4                ?= "armv8a"
+ARMPKGARCH_tune-armv8a-crc-vfpv4-neon            ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crc-vfpv4-neon           ?= "armv8a"
+ARMPKGARCH_tune-armv8a-crc-fp-armv8              ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crc-fp-armv8             ?= "armv8a"
+ARMPKGARCH_tune-armv8a-crc-fp-armv8-neon         ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crc-fp-armv8-neon        ?= "armv8a"
+ARMPKGARCH_tune-armv8a-crc-crypto-fp-armv8-neon  ?= "armv8a"
+ARMPKGARCH_tune-armv8at-crc-crypto-fp-armv8-neon ?= "armv8a"
+TUNE_FEATURES_tune-armv8a-crc                       = "${TUNE_FEATURES_tune-armv8a}                       crc"
+TUNE_FEATURES_tune-armv8at-crc                      = "${TUNE_FEATURES_tune-armv8at}                      crc"
+TUNE_FEATURES_tune-armv8a-crc-neon                  = "${TUNE_FEATURES_tune-armv8a-neon}                  crc"
+TUNE_FEATURES_tune-armv8at-crc-neon                 = "${TUNE_FEATURES_tune-armv8at-neon}                 crc"
+TUNE_FEATURES_tune-armv8a-crc-vfpv4                 = "${TUNE_FEATURES_tune-armv8a-vfpv4}                 crc"
+TUNE_FEATURES_tune-armv8at-crc-vfpv4                = "${TUNE_FEATURES_tune-armv8at-vfpv4}                crc"
+TUNE_FEATURES_tune-armv8a-crc-vfpv4-neon            = "${TUNE_FEATURES_tune-armv8a-vfpv4-neon}            crc"
+TUNE_FEATURES_tune-armv8at-crc-vfpv4-neon           = "${TUNE_FEATURES_tune-armv8at-vfpv4-neon}           crc"
+TUNE_FEATURES_tune-armv8a-crc-fp-armv8              = "${TUNE_FEATURES_tune-armv8a-fp-armv8}              crc"
+TUNE_FEATURES_tune-armv8at-crc-fp-armv8             = "${TUNE_FEATURES_tune-armv8at-fp-armv8}             crc"
+TUNE_FEATURES_tune-armv8a-crc-fp-armv8-neon         = "${TUNE_FEATURES_tune-armv8a-fp-armv8-neon}         crc"
+TUNE_FEATURES_tune-armv8at-crc-fp-armv8-neon        = "${TUNE_FEATURES_tune-armv8at-fp-armv8-neon}        crc"
+TUNE_FEATURES_tune-armv8a-crc-crypto-fp-armv8-neon  = "${TUNE_FEATURES_tune-armv8a-crypto-fp-armv8-neon}  crc"
+TUNE_FEATURES_tune-armv8at-crc-crypto-fp-armv8-neon = "${TUNE_FEATURES_tune-armv8at-crypto-fp-armv8-neon} crc"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crc                       = "${PACKAGE_EXTRA_ARCHS_tune-armv8a} armv8a-crc-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crc                      = "${PACKAGE_EXTRA_ARCHS_tune-armv8at} armv8a-crc-vfp armv8at2-crc-vfp"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-neon                  = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-neon} armv8a-crc-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crc-neon                 = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-neon} armv8a-crc-neon armv8at2-crc-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-vfpv4                 = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-vfpv4} armv8a-crc-vfpv4"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crc-vfpv4                = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-vfpv4} armv8a-crc-vfpv4 armv8at2-crc-vfpv4"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-vfpv4-neon            = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-vfpv4-neon} armv8a-crc-neon armv8a-crc-vfpv4-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crc-vfpv4-neon           = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-vfpv4-neon} armv8a-crc-neon armv8at2-crc-neon armv8a-crc-vfpv4-neon armv8at2-crc-vfpv4-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-fp-armv8              = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-fp-armv8} armv8a-crc-fp-armv8"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crc-fp-armv8             = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-fp-armv8} armv8a-crc-fp-armv8 armv8at2-crc-fp-armv8"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-fp-armv8-neon         = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-fp-armv8-neon} armv8a-crc-fp-armv8-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crc-fp-armv8-neon        = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-fp-armv8-neon} armv8a-crc-fp-armv8-neon armv8at2-crc-fp-armv8-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8a-crc-crypto-fp-armv8-neon  = "${PACKAGE_EXTRA_ARCHS_tune-armv8a-crypto-fp-armv8-neon} armv8a-crc-crypto-fp-armv8-neon"
+PACKAGE_EXTRA_ARCHS_tune-armv8at-crc-crypto-fp-armv8-neon = "${PACKAGE_EXTRA_ARCHS_tune-armv8at-crypto-fp-armv8-neon} armv8a-crc-crypto-fp-armv8-neon armv8at2-crc-crypto-fp-armv8-neon"
diff --git a/meta/conf/machine/include/arm/feature-arm-thumb.inc b/meta/conf/machine/include/arm/feature-arm-thumb.inc
index dfb9d7e..94d269f 100644
--- a/meta/conf/machine/include/arm/feature-arm-thumb.inc
+++ b/meta/conf/machine/include/arm/feature-arm-thumb.inc
@@ -7,6 +7,7 @@ ARM_THUMB_SUFFIX .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7a', 't2', '', d
 ARM_THUMB_SUFFIX .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7r', 't2', '', d)}"
 ARM_THUMB_SUFFIX .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7m', 't2', '', d)}"
 ARM_THUMB_SUFFIX .= "${@bb.utils.contains('TUNE_FEATURES', 'armv7ve', 't2', '', d)}"
+ARM_THUMB_SUFFIX .= "${@bb.utils.contains('TUNE_FEATURES', 'armv8a', 't2', '', d)}"
 
 # If the device supports ARM, then respect ARM_THUMB_OPT (which can be "arm" or "thumb")
 # If the defice doesn't support ARM, then always set "thumb" even when
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH][master] Add tune for 32-bit ARMv8-a
  2016-03-07 14:34 ` [PATCH][master] Add tune for 32-bit ARMv8-a Daniel Dragomir
@ 2016-03-08  0:55   ` Otavio Salvador
  2016-03-08  2:26     ` Otavio Salvador
  0 siblings, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2016-03-08  0:55 UTC (permalink / raw)
  To: Daniel Dragomir; +Cc: Patches and discussions about the oe-core layer

Hello Daniel,

On Mon, Mar 7, 2016 at 11:34 AM, Daniel Dragomir
<daniel.dragomir@windriver.com> wrote:
> This patch adds tunes for 32-bit armv8 platforms. The user can select
> the vector floating-point instruction set: vfpv4 or fp-armv8
> and the thumb, neon, crc and crypto extensions.
>
> Signed-off-by: Daniel Dragomir <daniel.dragomir@windriver.com>

First I would like to thank you for working on this. This is very
helpful and a good step in extending the ARMv8 platform support in
OE-Core.

I think you should also change the arch-arm64.inc file to use the
armv8a.inc file. So it is more consistent.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH][master] Add tune for 32-bit ARMv8-a
  2016-03-08  0:55   ` Otavio Salvador
@ 2016-03-08  2:26     ` Otavio Salvador
  2016-03-08 11:37       ` Dragomir Daniel
  0 siblings, 1 reply; 6+ messages in thread
From: Otavio Salvador @ 2016-03-08  2:26 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: Patches and discussions about the oe-core layer

Hello Daniel,

On Mon, Mar 7, 2016 at 9:55 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> On Mon, Mar 7, 2016 at 11:34 AM, Daniel Dragomir
> <daniel.dragomir@windriver.com> wrote:
>> This patch adds tunes for 32-bit armv8 platforms. The user can select
>> the vector floating-point instruction set: vfpv4 or fp-armv8
>> and the thumb, neon, crc and crypto extensions.
>>
>> Signed-off-by: Daniel Dragomir <daniel.dragomir@windriver.com>
>
> First I would like to thank you for working on this. This is very
> helpful and a good step in extending the ARMv8 platform support in
> OE-Core.
>
> I think you should also change the arch-arm64.inc file to use the
> armv8a.inc file. So it is more consistent.

When I tried to use armv8at-crc-crypto-fp-armv8-neon as default tune,
it fails with:

Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH
(armv8a-crc-crypto-fp-armv8-vfp).

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH][master] Add tune for 32-bit ARMv8-a
  2016-03-08  2:26     ` Otavio Salvador
@ 2016-03-08 11:37       ` Dragomir Daniel
  2016-03-08 11:53         ` Otavio Salvador
  0 siblings, 1 reply; 6+ messages in thread
From: Dragomir Daniel @ 2016-03-08 11:37 UTC (permalink / raw)
  To: Otavio Salvador, Otavio Salvador
  Cc: Patches and discussions about the oe-core layer

Thanks, Otavio!

I'll update also the arch-arm64.inc file to have 64bit support for armv8a
in a new version for the patch.

On 03/08/2016 04:26 AM, Otavio Salvador wrote:
> Hello Daniel,
>
> On Mon, Mar 7, 2016 at 9:55 PM, Otavio Salvador <otavio@ossystems.com.br> wrote:
>> On Mon, Mar 7, 2016 at 11:34 AM, Daniel Dragomir
>> <daniel.dragomir@windriver.com> wrote:
>>> This patch adds tunes for 32-bit armv8 platforms. The user can select
>>> the vector floating-point instruction set: vfpv4 or fp-armv8
>>> and the thumb, neon, crc and crypto extensions.
>>>
>>> Signed-off-by: Daniel Dragomir <daniel.dragomir@windriver.com>
>> First I would like to thank you for working on this. This is very
>> helpful and a good step in extending the ARMv8 platform support in
>> OE-Core.
>>
>> I think you should also change the arch-arm64.inc file to use the
>> armv8a.inc file. So it is more consistent.
> When I tried to use armv8at-crc-crypto-fp-armv8-neon as default tune,
> it fails with:
>
> Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH
> (armv8a-crc-crypto-fp-armv8-vfp).
>

Did you used master or jethro?
Did you get this kind of error only for this tuneor there are also other
armv8a tunes that fails?

Thanks,
Daniel




^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH][master] Add tune for 32-bit ARMv8-a
  2016-03-08 11:37       ` Dragomir Daniel
@ 2016-03-08 11:53         ` Otavio Salvador
  0 siblings, 0 replies; 6+ messages in thread
From: Otavio Salvador @ 2016-03-08 11:53 UTC (permalink / raw)
  To: Dragomir Daniel
  Cc: Otavio Salvador, Patches and discussions about the oe-core layer

On Tue, Mar 8, 2016 at 8:37 AM, Dragomir Daniel
<daniel.dragomir@windriver.com> wrote:
> I'll update also the arch-arm64.inc file to have 64bit support for armv8a
> in a new version for the patch.

Please do.

> On 03/08/2016 04:26 AM, Otavio Salvador wrote:
>> On Mon, Mar 7, 2016 at 9:55 PM, Otavio Salvador <otavio@ossystems.com.br>
>> wrote:
>>>
>>> On Mon, Mar 7, 2016 at 11:34 AM, Daniel Dragomir
>>> <daniel.dragomir@windriver.com> wrote:
>>>>
>>>> This patch adds tunes for 32-bit armv8 platforms. The user can select
>>>> the vector floating-point instruction set: vfpv4 or fp-armv8
>>>> and the thumb, neon, crc and crypto extensions.
>>>>
>>>> Signed-off-by: Daniel Dragomir <daniel.dragomir@windriver.com>
>>>
>>> First I would like to thank you for working on this. This is very
>>> helpful and a good step in extending the ARMv8 platform support in
>>> OE-Core.
>>>
>>> I think you should also change the arch-arm64.inc file to use the
>>> armv8a.inc file. So it is more consistent.
>>
>> When I tried to use armv8at-crc-crypto-fp-armv8-neon as default tune,
>> it fails with:
>>
>> Error, the PACKAGE_ARCHS variable does not contain TUNE_PKGARCH
>> (armv8a-crc-crypto-fp-armv8-vfp).
>>
>
> Did you used master or jethro?
> Did you get this kind of error only for this tuneor there are also other
> armv8a tunes that fails?

I applied your patch in a Jethro tree but it seems not related. Could
you test it at your side?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2016-03-08 11:53 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-07 14:34 [master][PATCH] ARMv8 32-bit compiler tunings Daniel Dragomir
2016-03-07 14:34 ` [PATCH][master] Add tune for 32-bit ARMv8-a Daniel Dragomir
2016-03-08  0:55   ` Otavio Salvador
2016-03-08  2:26     ` Otavio Salvador
2016-03-08 11:37       ` Dragomir Daniel
2016-03-08 11:53         ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.