From: nicolas.ferre@atmel.com (Nicolas Ferre)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/8] drm: atmel-hlcdc: remove leftovers from atomic mode setting migration
Date: Tue, 8 Mar 2016 16:04:16 +0100 [thread overview]
Message-ID: <56DEE9F0.7060406@atmel.com> (raw)
In-Reply-To: <1452075569-8545-5-git-send-email-boris.brezillon@free-electrons.com>
Le 06/01/2016 11:19, Boris Brezillon a ?crit :
> The ->dpms field is no longer used and can be removed.
> The same goes for the dummy ->mode_fixup() implementation which always
> returns true.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> index 49494e9..2255dc9 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> @@ -44,13 +44,11 @@ enum atmel_hlcdc_connector_rgb_mode {
> * @connector: DRM connector
> * @encoder: DRM encoder
> * @dc: pointer to the atmel_hlcdc_dc structure
> - * @dpms: current DPMS mode
> */
> struct atmel_hlcdc_rgb_output {
> struct drm_connector connector;
> struct drm_encoder encoder;
> struct atmel_hlcdc_dc *dc;
> - int dpms;
> };
>
> static inline struct atmel_hlcdc_rgb_output *
> @@ -104,14 +102,6 @@ static void atmel_hlcdc_panel_encoder_disable(struct drm_encoder *encoder)
> drm_panel_disable(panel->panel);
> }
>
> -static bool
> -atmel_hlcdc_panel_encoder_mode_fixup(struct drm_encoder *encoder,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted)
> -{
> - return true;
> -}
> -
> static void
> atmel_hlcdc_rgb_encoder_mode_set(struct drm_encoder *encoder,
> struct drm_display_mode *mode,
> @@ -147,7 +137,6 @@ atmel_hlcdc_rgb_encoder_mode_set(struct drm_encoder *encoder,
> }
>
> static const struct drm_encoder_helper_funcs atmel_hlcdc_panel_encoder_helper_funcs = {
> - .mode_fixup = atmel_hlcdc_panel_encoder_mode_fixup,
> .mode_set = atmel_hlcdc_rgb_encoder_mode_set,
> .disable = atmel_hlcdc_panel_encoder_disable,
> .enable = atmel_hlcdc_panel_encoder_enable,
> @@ -248,7 +237,6 @@ static int atmel_hlcdc_create_panel_output(struct drm_device *dev,
> if (!panel)
> return -EINVAL;
>
> - panel->base.dpms = DRM_MODE_DPMS_OFF;
>
> panel->base.dc = dc;
>
>
--
Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/8] drm: atmel-hlcdc: remove leftovers from atomic mode setting migration
Date: Tue, 8 Mar 2016 16:04:16 +0100 [thread overview]
Message-ID: <56DEE9F0.7060406@atmel.com> (raw)
In-Reply-To: <1452075569-8545-5-git-send-email-boris.brezillon@free-electrons.com>
Le 06/01/2016 11:19, Boris Brezillon a écrit :
> The ->dpms field is no longer used and can be removed.
> The same goes for the dummy ->mode_fixup() implementation which always
> returns true.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> index 49494e9..2255dc9 100644
> --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_output.c
> @@ -44,13 +44,11 @@ enum atmel_hlcdc_connector_rgb_mode {
> * @connector: DRM connector
> * @encoder: DRM encoder
> * @dc: pointer to the atmel_hlcdc_dc structure
> - * @dpms: current DPMS mode
> */
> struct atmel_hlcdc_rgb_output {
> struct drm_connector connector;
> struct drm_encoder encoder;
> struct atmel_hlcdc_dc *dc;
> - int dpms;
> };
>
> static inline struct atmel_hlcdc_rgb_output *
> @@ -104,14 +102,6 @@ static void atmel_hlcdc_panel_encoder_disable(struct drm_encoder *encoder)
> drm_panel_disable(panel->panel);
> }
>
> -static bool
> -atmel_hlcdc_panel_encoder_mode_fixup(struct drm_encoder *encoder,
> - const struct drm_display_mode *mode,
> - struct drm_display_mode *adjusted)
> -{
> - return true;
> -}
> -
> static void
> atmel_hlcdc_rgb_encoder_mode_set(struct drm_encoder *encoder,
> struct drm_display_mode *mode,
> @@ -147,7 +137,6 @@ atmel_hlcdc_rgb_encoder_mode_set(struct drm_encoder *encoder,
> }
>
> static const struct drm_encoder_helper_funcs atmel_hlcdc_panel_encoder_helper_funcs = {
> - .mode_fixup = atmel_hlcdc_panel_encoder_mode_fixup,
> .mode_set = atmel_hlcdc_rgb_encoder_mode_set,
> .disable = atmel_hlcdc_panel_encoder_disable,
> .enable = atmel_hlcdc_panel_encoder_enable,
> @@ -248,7 +237,6 @@ static int atmel_hlcdc_create_panel_output(struct drm_device *dev,
> if (!panel)
> return -EINVAL;
>
> - panel->base.dpms = DRM_MODE_DPMS_OFF;
>
> panel->base.dc = dc;
>
>
--
Nicolas Ferre
next prev parent reply other threads:[~2016-03-08 15:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 10:19 [PATCH 0/8] drm: atmel-hlcdc: various fixes/improvements Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-01-06 10:19 ` [PATCH 1/8] drm: atmel-hlcdc: add a ->cleanup_fb() operation Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-03-08 15:03 ` Nicolas Ferre
2016-03-08 15:03 ` Nicolas Ferre
2016-01-06 10:19 ` [PATCH 2/8] drm: atmel-hlcdc: support asynchronous atomic commit operations Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-01-06 10:19 ` [PATCH 3/8] drm: atmel-hlcdc: fix connector and encoder types Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-03-08 15:03 ` Nicolas Ferre
2016-03-08 15:03 ` Nicolas Ferre
2016-01-06 10:19 ` [PATCH 4/8] drm: atmel-hlcdc: remove leftovers from atomic mode setting migration Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-03-08 15:04 ` Nicolas Ferre [this message]
2016-03-08 15:04 ` Nicolas Ferre
2016-01-06 10:19 ` [PATCH 5/8] drm: atmel-hlcdc: support extended timing ranges on sama5d4 and sama5d2 Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-03-08 15:08 ` Nicolas Ferre
2016-03-08 15:08 ` Nicolas Ferre
2016-01-06 10:19 ` [PATCH 6/8] drm: atmel-hlcdc: move output mode selection in CRTC implementation Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-01-06 10:19 ` [PATCH 7/8] drm: atmel-hlcdc: rework the output code to support drm bridges Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-01-06 10:19 ` [PATCH 8/8] drm: atmel-hlcdc: check display mode validity in crtc->mode_fixup() Boris Brezillon
2016-01-06 10:19 ` Boris Brezillon
2016-03-08 15:44 ` Nicolas Ferre
2016-03-08 15:44 ` Nicolas Ferre
2016-03-01 10:55 ` [PATCH 0/8] drm: atmel-hlcdc: various fixes/improvements Boris Brezillon
2016-03-01 10:55 ` Boris Brezillon
2016-03-17 2:43 ` Dave Airlie
2016-03-17 2:43 ` Dave Airlie
2016-03-17 8:33 ` Boris Brezillon
2016-03-17 8:33 ` Boris Brezillon
2016-03-16 13:06 ` Nicolas Ferre
2016-03-16 13:06 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DEE9F0.7060406@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.