From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
dwmw2@infradead.org, matthias.bgg@gmail.com, robh@kernel.org,
daniel.thompson@linaro.org, xiaolei.li@mediatek.com,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH 2/3] mtd: mediatek: driver for MTK Smart Device Gen1 NAND
Date: Tue, 8 Mar 2016 17:02:19 -0500 [thread overview]
Message-ID: <56DF4BEB.4080907@linaro.org> (raw)
In-Reply-To: <20160308212240.GM55664@google.com>
On 03/08/2016 04:22 PM, Brian Norris wrote:
> Hi Jorge,
>
> On Tue, Mar 08, 2016 at 03:57:44PM -0500, Jorge Ramirez-Ortiz wrote:
>> On 03/08/2016 03:20 PM, Brian Norris wrote:
>>>>> If you feel strongly about it I don't mind adding an additional check after any
>>>>> form of sleep (not so sure about adding it after a cpu_relax) but I don't think
>>>>> it is needed.
>>> It is non-negotiable that your timeout loops must be logically correct.
>>> That is, you must recheck the exit condition before you declare a
>>> timeout.
>
of course agreed. you/Boris are absolutely right: I was missing the last check
that the macro does (I didnt notice it when I grepped the implementation).
next prev parent reply other threads:[~2016-03-08 22:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-02 17:00 [RFC PATCH 0/3] MTK Smart Device Gen1 NAND support Jorge Ramirez-Ortiz
2016-03-02 17:00 ` [PATCH 1/3] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Jorge Ramirez-Ortiz
2016-03-08 15:00 ` Boris Brezillon
2016-03-08 18:19 ` Brian Norris
2016-03-08 15:15 ` Boris Brezillon
2016-03-02 17:00 ` [PATCH 2/3] mtd: mediatek: driver " Jorge Ramirez-Ortiz
2016-03-08 16:24 ` Boris Brezillon
2016-03-08 17:17 ` Jorge Ramirez-Ortiz
2016-03-08 18:17 ` Brian Norris
2016-03-08 20:08 ` Jorge Ramirez-Ortiz
2016-03-08 20:20 ` Brian Norris
2016-03-08 20:57 ` Jorge Ramirez-Ortiz
2016-03-08 21:22 ` Brian Norris
2016-03-08 22:02 ` Jorge Ramirez-Ortiz [this message]
2016-03-09 10:00 ` Boris Brezillon
2016-03-09 20:01 ` Jorge Ramirez-Ortiz
2016-03-09 20:43 ` Boris Brezillon
2016-03-18 14:00 ` Jorge Ramirez-Ortiz
2016-03-18 14:00 ` Jorge Ramirez-Ortiz
[not found] ` <56EC09F5.5020704-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-18 14:24 ` Boris Brezillon
2016-03-18 14:24 ` Boris Brezillon
2016-03-15 12:28 ` Jorge Ramirez-Ortiz
2016-03-15 12:59 ` Boris Brezillon
2016-03-15 13:21 ` Jorge Ramirez-Ortiz
2016-03-15 13:53 ` Boris Brezillon
2016-03-02 17:00 ` [PATCH 3/3] mtd: mediatek: device tree enable NAND in MTK's 2701 evb Jorge Ramirez-Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56DF4BEB.4080907@linaro.org \
--to=jorge.ramirez-ortiz@linaro.org \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=xiaolei.li@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.