All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Jorge Ramirez-Ortiz
	<jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
	computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org
Subject: Re: [PATCH 2/3] mtd: mediatek: driver for MTK Smart Device Gen1 NAND
Date: Fri, 18 Mar 2016 15:24:27 +0100	[thread overview]
Message-ID: <20160318152427.672c3957@bbrezillon> (raw)
In-Reply-To: <56EC09F5.5020704-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

On Fri, 18 Mar 2016 10:00:21 -0400
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:

> On 03/09/2016 03:43 PM, Boris Brezillon wrote:
> > On Wed, 9 Mar 2016 15:01:22 -0500
> > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> >
> >> On 03/08/2016 11:24 AM, Boris Brezillon wrote:
> >>>> +	switch (mtd->writesize) {
> >>>>> +	case KB(2):
> >>>>> +		fmt = PAGEFMT_512_2K;
> >>>>> +		chip->ecc.layout = &nand_2k_64;
> >>>>> +		break;
> >>>>> +	case KB(4):
> >>>>> +		fmt = PAGEFMT_2K_4K;
> >>>>> +		chip->ecc.layout = &nand_4k_128;
> >>>>> +		break;
> >>>>> +	case KB(8):
> >>>>> +		fmt = PAGEFMT_4K_8K;
> >>>>> +		break;
> >>>>> +	default:
> >>>>> +		dev_err(dev, "invalid page size: %d\n", mtd->writesize);
> >>>>> +		return -EINVAL;
> >>>>> +	}
> >>> ecclayout info should be exposed through mtd_ooblayout_ops now.
> >>>
> >> do you have an approximate date for when this interface will be merged in
> >> git://git.infradead.org/l2-mtd.git?
> >>
> > Should be ready for 4.7, in the meantime you can base your work on my
> > branch [1] (which is based on l2-mtd/master).
> >
> > [1]https://github.com/bbrezillon/linux-0day/tree/nand/ecclayout
> 
> 
> hi Boris, just a quick one, please could you confirm that you would like to see
> the RFC v2 patch-set for this driver based on this branch?

Yes, I confirm you can base your work on this tree.

> or should we rebase on some other tree?

You may have to rebase on a different tree after 4.6-rc1 is out though.

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>
Cc: dwmw2@infradead.org, computersforpeace@gmail.com,
	matthias.bgg@gmail.com, robh@kernel.org,
	daniel.thompson@linaro.org, xiaolei.li@mediatek.com,
	linux-mtd@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/3] mtd: mediatek: driver for MTK Smart Device Gen1 NAND
Date: Fri, 18 Mar 2016 15:24:27 +0100	[thread overview]
Message-ID: <20160318152427.672c3957@bbrezillon> (raw)
In-Reply-To: <56EC09F5.5020704@linaro.org>

On Fri, 18 Mar 2016 10:00:21 -0400
Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:

> On 03/09/2016 03:43 PM, Boris Brezillon wrote:
> > On Wed, 9 Mar 2016 15:01:22 -0500
> > Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org> wrote:
> >
> >> On 03/08/2016 11:24 AM, Boris Brezillon wrote:
> >>>> +	switch (mtd->writesize) {
> >>>>> +	case KB(2):
> >>>>> +		fmt = PAGEFMT_512_2K;
> >>>>> +		chip->ecc.layout = &nand_2k_64;
> >>>>> +		break;
> >>>>> +	case KB(4):
> >>>>> +		fmt = PAGEFMT_2K_4K;
> >>>>> +		chip->ecc.layout = &nand_4k_128;
> >>>>> +		break;
> >>>>> +	case KB(8):
> >>>>> +		fmt = PAGEFMT_4K_8K;
> >>>>> +		break;
> >>>>> +	default:
> >>>>> +		dev_err(dev, "invalid page size: %d\n", mtd->writesize);
> >>>>> +		return -EINVAL;
> >>>>> +	}
> >>> ecclayout info should be exposed through mtd_ooblayout_ops now.
> >>>
> >> do you have an approximate date for when this interface will be merged in
> >> git://git.infradead.org/l2-mtd.git?
> >>
> > Should be ready for 4.7, in the meantime you can base your work on my
> > branch [1] (which is based on l2-mtd/master).
> >
> > [1]https://github.com/bbrezillon/linux-0day/tree/nand/ecclayout
> 
> 
> hi Boris, just a quick one, please could you confirm that you would like to see
> the RFC v2 patch-set for this driver based on this branch?

Yes, I confirm you can base your work on this tree.

> or should we rebase on some other tree?

You may have to rebase on a different tree after 4.6-rc1 is out though.

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2016-03-18 14:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 17:00 [RFC PATCH 0/3] MTK Smart Device Gen1 NAND support Jorge Ramirez-Ortiz
2016-03-02 17:00 ` [PATCH 1/3] mtd: mediatek: device tree docs for MTK Smart Device Gen1 NAND Jorge Ramirez-Ortiz
2016-03-08 15:00   ` Boris Brezillon
2016-03-08 18:19     ` Brian Norris
2016-03-08 15:15   ` Boris Brezillon
2016-03-02 17:00 ` [PATCH 2/3] mtd: mediatek: driver " Jorge Ramirez-Ortiz
2016-03-08 16:24   ` Boris Brezillon
2016-03-08 17:17     ` Jorge Ramirez-Ortiz
2016-03-08 18:17     ` Brian Norris
2016-03-08 20:08       ` Jorge Ramirez-Ortiz
2016-03-08 20:20         ` Brian Norris
2016-03-08 20:57           ` Jorge Ramirez-Ortiz
2016-03-08 21:22             ` Brian Norris
2016-03-08 22:02               ` Jorge Ramirez-Ortiz
2016-03-09 10:00             ` Boris Brezillon
2016-03-09 20:01     ` Jorge Ramirez-Ortiz
2016-03-09 20:43       ` Boris Brezillon
2016-03-18 14:00         ` Jorge Ramirez-Ortiz
2016-03-18 14:00           ` Jorge Ramirez-Ortiz
     [not found]           ` <56EC09F5.5020704-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-03-18 14:24             ` Boris Brezillon [this message]
2016-03-18 14:24               ` Boris Brezillon
2016-03-15 12:28     ` Jorge Ramirez-Ortiz
2016-03-15 12:59       ` Boris Brezillon
2016-03-15 13:21         ` Jorge Ramirez-Ortiz
2016-03-15 13:53           ` Boris Brezillon
2016-03-02 17:00 ` [PATCH 3/3] mtd: mediatek: device tree enable NAND in MTK's 2701 evb Jorge Ramirez-Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160318152427.672c3957@bbrezillon \
    --to=boris.brezillon-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
    --cc=computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=daniel.thompson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
    --cc=jorge.ramirez-ortiz-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=xiaolei.li-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.