From: Laxman Dewangan <ldewangan@nvidia.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: rui.zhang@intel.com, corbet@lwn.net, rklein@nvidia.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/3] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register
Date: Wed, 9 Mar 2016 17:40:38 +0530 [thread overview]
Message-ID: <56E012BE.3050305@nvidia.com> (raw)
In-Reply-To: <20160308212954.GB8820@localhost.localdomain>
Hi Edurado,
Thanks for review.
On Wednesday 09 March 2016 02:59 AM, Eduardo Valentin wrote:
> Hello Laxman,
>
>
> Minor as follows.
>
> Can you please run ./scripts/checkpatch.pl --strict on this and remove
> the warnings, errors, checks?
Taken from existing function and so borrowed the error. Will fix in next
revision.
>
> On Fri, Mar 04, 2016 at 07:10:08PM +0530, Laxman Dewangan wrote:
>> Add resource managed version of thermal_zone_of_sensor_register() and
>> thermal_zone_of_sensor_unregister().
>>
>> This helps in reducing the code size in error path, remove of
>> driver remove callbacks and making proper sequence for deallocations.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>> drivers/thermal/of-thermal.c | 81 ++++++++++++++++++++++++++++++++++++++++++++
>> include/linux/thermal.h | 18 ++++++++++
> Could you also please document these under
> Documentation/thermal/sysfs-api.txt?
>
>
Sure, I saw that thermal_zone_of_sensor_register/unregister is also not
documented.
So I will add the details for this first and then add for newly added
interfaces.
Will take care in next series.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: <rui.zhang@intel.com>, <corbet@lwn.net>, <rklein@nvidia.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH 1/3] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register
Date: Wed, 9 Mar 2016 17:40:38 +0530 [thread overview]
Message-ID: <56E012BE.3050305@nvidia.com> (raw)
In-Reply-To: <20160308212954.GB8820@localhost.localdomain>
Hi Edurado,
Thanks for review.
On Wednesday 09 March 2016 02:59 AM, Eduardo Valentin wrote:
> Hello Laxman,
>
>
> Minor as follows.
>
> Can you please run ./scripts/checkpatch.pl --strict on this and remove
> the warnings, errors, checks?
Taken from existing function and so borrowed the error. Will fix in next
revision.
>
> On Fri, Mar 04, 2016 at 07:10:08PM +0530, Laxman Dewangan wrote:
>> Add resource managed version of thermal_zone_of_sensor_register() and
>> thermal_zone_of_sensor_unregister().
>>
>> This helps in reducing the code size in error path, remove of
>> driver remove callbacks and making proper sequence for deallocations.
>>
>> Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
>> ---
>> drivers/thermal/of-thermal.c | 81 ++++++++++++++++++++++++++++++++++++++++++++
>> include/linux/thermal.h | 18 ++++++++++
> Could you also please document these under
> Documentation/thermal/sysfs-api.txt?
>
>
Sure, I saw that thermal_zone_of_sensor_register/unregister is also not
documented.
So I will add the details for this first and then add for newly added
interfaces.
Will take care in next series.
next prev parent reply other threads:[~2016-03-09 12:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 13:40 [PATCH 0/3] thermal: add devm_ version of thermal_zone register and driver for max77620 Laxman Dewangan
2016-03-04 13:40 ` Laxman Dewangan
2016-03-04 13:40 ` [PATCH 1/3] thermal: of-thermal: Add devm version of thermal_zone_of_sensor_register Laxman Dewangan
2016-03-04 13:40 ` Laxman Dewangan
2016-03-08 21:29 ` Eduardo Valentin
2016-03-09 12:10 ` Laxman Dewangan [this message]
2016-03-09 12:10 ` Laxman Dewangan
2016-03-04 13:40 ` [PATCH 2/3] thermal: Add devm_thermal_zone_of_sensor_register() in managed devices list Laxman Dewangan
2016-03-04 13:40 ` Laxman Dewangan
2016-03-04 13:40 ` [PATCH 3/3] thermal: max77620: Add thermal driver for reporting junction temp Laxman Dewangan
2016-03-04 13:40 ` Laxman Dewangan
2016-03-04 14:04 ` Laxman Dewangan
2016-03-04 14:04 ` Laxman Dewangan
2016-03-08 21:24 ` Eduardo Valentin
2016-03-09 12:34 ` Laxman Dewangan
2016-03-09 12:34 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E012BE.3050305@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=corbet@lwn.net \
--cc=edubezval@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.