All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: rutuja shah <rutu.shah.26@gmail.com>, qemu-devel@nongnu.org
Cc: samuel.thibault@ens-lyon.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	kwolf@redhat.com, crosthwaite.peter@gmail.com, rth@twiddle.net,
	mst@redhat.com, imammedo@redhat.com, peter.maydell@linaro.org,
	balrogg@gmail.com, jsnow@redhat.com, alistair.francis@xilinx.com,
	agraf@suse.de, jasowang@redhat.com, blauwirbel@gmail.co,
	mark.cave-ayland@ilande.co.uk, kraxel@redhat.com,
	cornelia.huck@de.ibm.com, borntraeger@de.ibm.com,
	lcapitulino@redhat.com, armbru@redhat.com, qemu-block@nongnu.org,
	qemu-arm@nongnu.org, qemu-ppc@nongnu.org, kvm@vger.kernel.org
Subject: Re: [PATCH] Replaced get_ticks_per_sec calls with NANOSECONDS_PER_SECOND
Date: Thu, 10 Mar 2016 18:28:51 +0100	[thread overview]
Message-ID: <56E1AED3.8080508@redhat.com> (raw)
In-Reply-To: <CAFE_T+SrAELFxgmuNPMt_FR9LwBNoNUwy-gVifuHNdrsWbhM-g@mail.gmail.com>



On 10/03/2016 18:22, rutuja shah wrote:
> Hi,
> As there are no callers to get_ticks_per_sec() function, definition of
> this function could be removed completely?

Yes, please.

> diff --git a/backends/baum.c b/backends/baum.c
> index c11320e..20b49f2 100644
> --- a/backends/baum.c
> +++ b/backends/baum.c
> @@ -336,7 +336,7 @@ static int baum_eat_packet(BaumDriverState *baum,
> const uint8_t *buf, int len)
> 
>          /* Allow 100ms to complete the DisplayData packet */
>          timer_mod(baum->cellCount_timer,
> qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> -                       get_ticks_per_sec() / 10);
> +                       NANOSECONDS_PER_SECOND / 10);

There is a problem with your patch, probably because you're using gmail;
lines are wrapped (for example the timer_mod line shows as two lines).

You can use the smtp.gmail.com server and git-send-email to avoid this
issue.

Thanks,

Paolo

WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: rutuja shah <rutu.shah.26@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com,
	jasowang@redhat.com, mark.cave-ayland@ilande.co.uk,
	lcapitulino@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org,
	agraf@suse.de, borntraeger@de.ibm.com,
	samuel.thibault@ens-lyon.org, alistair.francis@xilinx.com,
	qemu-arm@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	cornelia.huck@de.ibm.com, jsnow@redhat.com, rth@twiddle.net,
	kwolf@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com,
	blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Replaced get_ticks_per_sec calls with NANOSECONDS_PER_SECOND
Date: Thu, 10 Mar 2016 18:28:51 +0100	[thread overview]
Message-ID: <56E1AED3.8080508@redhat.com> (raw)
In-Reply-To: <CAFE_T+SrAELFxgmuNPMt_FR9LwBNoNUwy-gVifuHNdrsWbhM-g@mail.gmail.com>



On 10/03/2016 18:22, rutuja shah wrote:
> Hi,
> As there are no callers to get_ticks_per_sec() function, definition of
> this function could be removed completely?

Yes, please.

> diff --git a/backends/baum.c b/backends/baum.c
> index c11320e..20b49f2 100644
> --- a/backends/baum.c
> +++ b/backends/baum.c
> @@ -336,7 +336,7 @@ static int baum_eat_packet(BaumDriverState *baum,
> const uint8_t *buf, int len)
> 
>          /* Allow 100ms to complete the DisplayData packet */
>          timer_mod(baum->cellCount_timer,
> qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +
> -                       get_ticks_per_sec() / 10);
> +                       NANOSECONDS_PER_SECOND / 10);

There is a problem with your patch, probably because you're using gmail;
lines are wrapped (for example the timer_mod line shows as two lines).

You can use the smtp.gmail.com server and git-send-email to avoid this
issue.

Thanks,

Paolo

  reply	other threads:[~2016-03-10 17:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-10 17:22 [PATCH] Replaced get_ticks_per_sec calls with NANOSECONDS_PER_SECOND rutuja shah
2016-03-10 17:22 ` [Qemu-devel] " rutuja shah
2016-03-10 17:28 ` Paolo Bonzini [this message]
2016-03-10 17:28   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E1AED3.8080508@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=agraf@suse.de \
    --cc=alistair.francis@xilinx.com \
    --cc=armbru@redhat.com \
    --cc=balrogg@gmail.com \
    --cc=blauwirbel@gmail.co \
    --cc=borntraeger@de.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=crosthwaite.peter@gmail.com \
    --cc=imammedo@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=mark.cave-ayland@ilande.co.uk \
    --cc=mst@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=rutu.shah.26@gmail.com \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.