Re: [Qemu-devel] [PATCH v12 1/3] Add new block driver interface to add/delete a BDS's child

[Changlong Xie <xiecl.fnst@cn.fujitsu.com>]

On 03/10/2016 10:57 PM, Alberto Garcia wrote:
> On Thu 10 Mar 2016 03:49:39 AM CET, Changlong Xie wrote:
>> From: Wen Congyang <wency@cn.fujitsu.com>
>>
>> In some cases, we want to take a quorum child offline, and take
>> another child online.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>> Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>> Signed-off-by: Gonglei <arei.gonglei@huawei.com>
>> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
>> Reviewed-by: Max Reitz <mreitz@redhat.com>
>
>> +    if (!tmp) {
>> +        error_setg(errp, "The node %s does not have child named %s",
>> +                   bdrv_get_device_or_node_name(parent_bs),
>> +                   bdrv_get_device_or_node_name(child->bs));
>> +        return;
>
> I think it should be "does not have a child" or "does not have any
> child".
>
> With that corrected,

Ok, will fix in next version.

Thanks
	-Xie

>
> Reviewed-by: Alberto Garcia <berto@igalia.com>
>
> Berto
>
>
> .
>