All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt
Date: Fri, 11 Mar 2016 16:29:29 +0300	[thread overview]
Message-ID: <56E2C839.4000700@cogentembedded.com> (raw)
In-Reply-To: <56E2251D.905@hisilicon.com>

Hello.

On 3/11/2016 4:53 AM, Daode Huang wrote:

>>> In V2 chip, when sending mamagement packets, the driver should
>>> config the port id to BD descs.
>>>
>>> Signed-off-by: Daode Huang <huangdaode@hisilicon.com>
>>> Signed-off-by: Lisheng <lisheng011@huawei.com>
>>> ---
>>>   drivers/net/ethernet/hisilicon/hns/hnae.h         | 3 +++
>>>   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
>>>   drivers/net/ethernet/hisilicon/hns/hns_enet.c     | 4 ++++
>>>   3 files changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> b/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> index 1cbcb9f..11a3f97 100644
>>> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
>> [...]
>>> @@ -516,6 +518,7 @@ struct hnae_handle {
>>>       int q_num;
>>>       int vf_id;
>>>       u32 eport_id;
>>> +    u32 dport_id;    /*v2 tx bd should fill the dport_id*/
>>
>>    Please add spaces after /* and before */ (like it's done in other places
>> in this driver).
>>
>
> Hi MBR, Sergei,

    Just in case: MBR stands for "my best regards", Sergei is my name. :-)

> Daode.

MBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Daode Huang <huangdaode@hisilicon.com>, davem@davemloft.net
Cc: liguozhu@hisilicon.com, Yisen.Zhuang@huawei.com,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linuxarm@huawei.com, salil.mehta@huawei.com,
	kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com,
	lisheng011@huawei.com, yankejian@huawei.com
Subject: Re: [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt
Date: Fri, 11 Mar 2016 16:29:29 +0300	[thread overview]
Message-ID: <56E2C839.4000700@cogentembedded.com> (raw)
In-Reply-To: <56E2251D.905@hisilicon.com>

Hello.

On 3/11/2016 4:53 AM, Daode Huang wrote:

>>> In V2 chip, when sending mamagement packets, the driver should
>>> config the port id to BD descs.
>>>
>>> Signed-off-by: Daode Huang <huangdaode@hisilicon.com>
>>> Signed-off-by: Lisheng <lisheng011@huawei.com>
>>> ---
>>>   drivers/net/ethernet/hisilicon/hns/hnae.h         | 3 +++
>>>   drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 1 +
>>>   drivers/net/ethernet/hisilicon/hns/hns_enet.c     | 4 ++++
>>>   3 files changed, 8 insertions(+)
>>>
>>> diff --git a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> b/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> index 1cbcb9f..11a3f97 100644
>>> --- a/drivers/net/ethernet/hisilicon/hns/hnae.h
>>> +++ b/drivers/net/ethernet/hisilicon/hns/hnae.h
>> [...]
>>> @@ -516,6 +518,7 @@ struct hnae_handle {
>>>       int q_num;
>>>       int vf_id;
>>>       u32 eport_id;
>>> +    u32 dport_id;    /*v2 tx bd should fill the dport_id*/
>>
>>    Please add spaces after /* and before */ (like it's done in other places
>> in this driver).
>>
>
> Hi MBR, Sergei,

    Just in case: MBR stands for "my best regards", Sergei is my name. :-)

> Daode.

MBR, Sergei

  reply	other threads:[~2016-03-11 13:29 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-04  1:09 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04  1:09 ` Daode Huang
2016-03-04  0:55 ` Daode Huang
2016-03-04  0:55   ` Daode Huang
2016-03-04  1:09 ` [PATCH net 1/6] net: hns: bug fix about the overflow of mss Daode Huang
2016-03-04  1:09   ` Daode Huang
2016-03-04  1:09 ` [PATCH net 2/6] net: hns: fixes the hw interrupt bug in using napi Daode Huang
2016-03-04  1:09   ` Daode Huang
2016-03-04  1:09 ` [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang
2016-03-04  1:09   ` Daode Huang
2016-03-04 13:37   ` Sergei Shtylyov
2016-03-04 13:37     ` Sergei Shtylyov
2016-03-11  1:53     ` Daode Huang
2016-03-11  1:53       ` Daode Huang
2016-03-11 13:29       ` Sergei Shtylyov [this message]
2016-03-11 13:29         ` Sergei Shtylyov
2016-03-14  0:45         ` Daode Huang
2016-03-14  0:45           ` Daode Huang
2016-03-04  1:09 ` [PATCH net 4/6] net: hns: adds uc match for debug port Daode Huang
2016-03-04  1:09   ` Daode Huang
2016-03-04 13:39   ` Sergei Shtylyov
2016-03-04 13:39     ` Sergei Shtylyov
2016-03-11  1:58     ` Daode Huang
2016-03-11  1:58       ` Daode Huang
2016-03-04  1:09 ` [PATCH net 5/6] net: hns: fixed service-ges setting MAC-addr bug Daode Huang
2016-03-04  1:09   ` Daode Huang
2016-03-04  1:09 ` [PATCH net 6/6] net: hns: bug fix of getting hilink status Daode Huang
2016-03-04  1:09   ` Daode Huang
  -- strict thread matches above, loose matches on Subject: below --
2016-03-04  3:05 [PATCH net 0/6]net: hns: hns driver updates Daode Huang
2016-03-04  3:05 ` [PATCH net 3/6] net: hns: fixed portid bug in sending manage pkt Daode Huang
2016-03-04  3:05   ` Daode Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E2C839.4000700@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.