All of lore.kernel.org
 help / color / mirror / Atom feed
* Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming)
@ 2016-03-11 15:23 Michael Trimarchi
  2016-03-12  7:29 ` Arend van Spriel
  2017-05-28 19:37 ` Arend van Spriel
  0 siblings, 2 replies; 5+ messages in thread
From: Michael Trimarchi @ 2016-03-11 15:23 UTC (permalink / raw)
  To: Arend van Spriel; +Cc: linux-wireless

Hi

I have a kernel panic on the brcmf_sdiod_sgtable_alloc just because
the function is called before brcmf_sdio_probe.

I think that
 nents = max_t(uint, BRCMF_DEFAULT_RXGLOM_SIZE,
                      sdiodev->bus_if->drvr->settings->sdiod_txglomsz);

drvr is null. Can you explain how it can work or do you have already a
fix for this?

Michael

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming)
  2016-03-11 15:23 Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming) Michael Trimarchi
@ 2016-03-12  7:29 ` Arend van Spriel
  2016-03-12  8:57   ` Michael Trimarchi
  2017-05-28 19:37 ` Arend van Spriel
  1 sibling, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2016-03-12  7:29 UTC (permalink / raw)
  To: Michael Trimarchi, Arend van Spriel; +Cc: linux-wireless



On 11-03-16 16:23, Michael Trimarchi wrote:
> Hi
> 
> I have a kernel panic on the brcmf_sdiod_sgtable_alloc just because
> the function is called before brcmf_sdio_probe.
> 
> I think that
>  nents = max_t(uint, BRCMF_DEFAULT_RXGLOM_SIZE,
>                       sdiodev->bus_if->drvr->settings->sdiod_txglomsz);
> 
> drvr is null. Can you explain how it can work or do you have already a
> fix for this?

What kernel version are you using? This has been fixed already in
4.5-rc2 or rc3.

Regards,
Arend

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming)
  2016-03-12  7:29 ` Arend van Spriel
@ 2016-03-12  8:57   ` Michael Trimarchi
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Trimarchi @ 2016-03-12  8:57 UTC (permalink / raw)
  To: Arend van Spriel; +Cc: Arend van Spriel, linux-wireless

Hi


On Sat, Mar 12, 2016 at 8:29 AM, Arend van Spriel
<arend.vanspriel@broadcom.com> wrote:
>
>
> On 11-03-16 16:23, Michael Trimarchi wrote:
>> Hi
>>
>> I have a kernel panic on the brcmf_sdiod_sgtable_alloc just because
>> the function is called before brcmf_sdio_probe.
>>
>> I think that
>>  nents = max_t(uint, BRCMF_DEFAULT_RXGLOM_SIZE,
>>                       sdiodev->bus_if->drvr->settings->sdiod_txglomsz);
>>
>> drvr is null. Can you explain how it can work or do you have already a
>> fix for this?
>
> What kernel version are you using? This has been fixed already in
> 4.5-rc2 or rc3.

Ok, I see it I was using rockchip for-next and I have seen now the fix
in newest tree.

Thank you
Michael

>
> Regards,
> Arend



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming)
  2016-03-11 15:23 Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming) Michael Trimarchi
  2016-03-12  7:29 ` Arend van Spriel
@ 2017-05-28 19:37 ` Arend van Spriel
  2017-05-28 20:25   ` Michael Nazzareno Trimarchi
  1 sibling, 1 reply; 5+ messages in thread
From: Arend van Spriel @ 2017-05-28 19:37 UTC (permalink / raw)
  To: Michael Trimarchi, Arend van Spriel; +Cc: linux-wireless

On 11-03-16 16:23, Michael Trimarchi wrote:
> Hi
> 
> I have a kernel panic on the brcmf_sdiod_sgtable_alloc just because
> the function is called before brcmf_sdio_probe.
> 
> I think that
>  nents = max_t(uint, BRCMF_DEFAULT_RXGLOM_SIZE,
>                       sdiodev->bus_if->drvr->settings->sdiod_txglomsz);
> 
> drvr is null. Can you explain how it can work or do you have already a
> fix for this?

It sounds familiar so what kernel version are you seeing this.

Regards,
Arend

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming)
  2017-05-28 19:37 ` Arend van Spriel
@ 2017-05-28 20:25   ` Michael Nazzareno Trimarchi
  0 siblings, 0 replies; 5+ messages in thread
From: Michael Nazzareno Trimarchi @ 2017-05-28 20:25 UTC (permalink / raw)
  To: Arend van Spriel; +Cc: Arend van Spriel, linux-wireless

Hi Arend

On Sun, May 28, 2017 at 9:37 PM, Arend van Spriel
<arend.vanspriel@broadcom.com> wrote:
> On 11-03-16 16:23, Michael Trimarchi wrote:
>> Hi
>>
>> I have a kernel panic on the brcmf_sdiod_sgtable_alloc just because
>> the function is called before brcmf_sdio_probe.
>>
>> I think that
>>  nents = max_t(uint, BRCMF_DEFAULT_RXGLOM_SIZE,
>>                       sdiodev->bus_if->drvr->settings->sdiod_txglomsz);
>>
>> drvr is null. Can you explain how it can work or do you have already a
>> fix for this?
>
> It sounds familiar so what kernel version are you seeing this.
>

This should be already sort out 1 year ago ;)

Regards
Michael

> Regards,
> Arend



-- 
| Michael Nazzareno Trimarchi                     Amarula Solutions BV |
| COO  -  Founder                                      Cruquiuskade 47 |
| +31(0)851119172                                 Amsterdam 1018 AM NL |
|                  [`as] http://www.amarulasolutions.com               |

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2017-05-28 20:25 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-11 15:23 Probelm on (brcmfmac: use pre-allocated scatter-gather table for txglomming) Michael Trimarchi
2016-03-12  7:29 ` Arend van Spriel
2016-03-12  8:57   ` Michael Trimarchi
2017-05-28 19:37 ` Arend van Spriel
2017-05-28 20:25   ` Michael Nazzareno Trimarchi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.