All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: Eric Wheeler <dm-devel@lists.ewheeler.net>,
	dm-devel@redhat.com,
	LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: dm-thin metadata: can two device_id's have the same transaction_id ?
Date: Sat, 12 Mar 2016 09:44:31 +0100	[thread overview]
Message-ID: <56E3D6EF.3020404@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.11.1603112308440.30893@mail.ewheeler.net>

Dne 12.3.2016 v 00:14 Eric Wheeler napsal(a):
>
> Hello all,
>
> For thin volumes shown in the lvm VG metadata backups in
> /etc/lvm/backup/pool, can any two device_id's have the same
> transaction_id, ever?
>
> Otherwise, can I assume that the device_id and transaction_id are both
> unique, or is only the tuple (transaction_id,device_id) unique?
>
> For example:
>
> my-thin-vol {
>          id = "M8fkBP-pFe8-Z6K0-0f7N-HAFM-Mv2v-KOTmM3"
>          status = ["READ", "WRITE", "VISIBLE"]
>          flags = ["ACTIVATION_SKIP"]
>          creation_host = "hv1.ewheeler.net"
>          creation_time = 1452374892      # 2016-01-09 13:28:12 -0800
>          segment_count = 1
>
>          segment1 {
>                  start_extent = 0
>                  extent_count = 3072     # 48 Gigabytes
>
>                  type = "thin"
>                  thin_pool = "data-pool"
>>>>>>>>>>>>>     transaction_id = 9843
>                  device_id = 5735
>                  origin = "backup2.ewheeler.net_14-drbd"
>          }
> }
>

Hi

It's rather for linux-lvm list.

Transaction_id is 24bit number - and like may be possible to wrap
although it has not been much tested in such corner case.
(I should probably add some tests around this for lvm2...)

Device_id lvm2 does not recycle ATM - so it just always seeks for
largest and picks +1.  But it doesn't mean we could not introduce
recyling at some point.

However at this moment we rather try to use unique numbers to simplify 
possible recovery steps - it's fairly simpler.

Regards

Zdenek

WARNING: multiple messages have this Message-ID (diff)
From: Zdenek Kabelac <zkabelac@redhat.com>
To: Eric Wheeler <dm-devel@lists.ewheeler.net>,
	dm-devel@redhat.com,
	LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] [dm-devel] dm-thin metadata: can two device_id's have the same transaction_id ?
Date: Sat, 12 Mar 2016 09:44:31 +0100	[thread overview]
Message-ID: <56E3D6EF.3020404@redhat.com> (raw)
In-Reply-To: <alpine.LRH.2.11.1603112308440.30893@mail.ewheeler.net>

Dne 12.3.2016 v 00:14 Eric Wheeler napsal(a):
>
> Hello all,
>
> For thin volumes shown in the lvm VG metadata backups in
> /etc/lvm/backup/pool, can any two device_id's have the same
> transaction_id, ever?
>
> Otherwise, can I assume that the device_id and transaction_id are both
> unique, or is only the tuple (transaction_id,device_id) unique?
>
> For example:
>
> my-thin-vol {
>          id = "M8fkBP-pFe8-Z6K0-0f7N-HAFM-Mv2v-KOTmM3"
>          status = ["READ", "WRITE", "VISIBLE"]
>          flags = ["ACTIVATION_SKIP"]
>          creation_host = "hv1.ewheeler.net"
>          creation_time = 1452374892      # 2016-01-09 13:28:12 -0800
>          segment_count = 1
>
>          segment1 {
>                  start_extent = 0
>                  extent_count = 3072     # 48 Gigabytes
>
>                  type = "thin"
>                  thin_pool = "data-pool"
>>>>>>>>>>>>>     transaction_id = 9843
>                  device_id = 5735
>                  origin = "backup2.ewheeler.net_14-drbd"
>          }
> }
>

Hi

It's rather for linux-lvm list.

Transaction_id is 24bit number - and like may be possible to wrap
although it has not been much tested in such corner case.
(I should probably add some tests around this for lvm2...)

Device_id lvm2 does not recycle ATM - so it just always seeks for
largest and picks +1.  But it doesn't mean we could not introduce
recyling at some point.

However at this moment we rather try to use unique numbers to simplify 
possible recovery steps - it's fairly simpler.

Regards

Zdenek

  reply	other threads:[~2016-03-12  8:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 23:14 dm-thin metadata: can two device_id's have the same transaction_id ? Eric Wheeler
2016-03-12  8:44 ` Zdenek Kabelac [this message]
2016-03-12  8:44   ` [linux-lvm] [dm-devel] " Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E3D6EF.3020404@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=dm-devel@lists.ewheeler.net \
    --cc=dm-devel@redhat.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.