* [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool @ 2016-03-11 3:25 ` Kejian Yan 0 siblings, 0 replies; 10+ messages in thread From: Kejian Yan @ 2016-03-11 3:25 UTC (permalink / raw) To: linux-arm-kernel When we use ethtool to retrieves or configure the receive flow hash indirection table, ethtool needs to call .get_rxnfc to get the ring number so this patchset implements the .get_rxnfc and fixes the bug that we can not get the tatal table each time. --- change log: PATCH v3: - This patchset fixes the building warning and error PATCH v2: - This patchset fixes the comments provided by Andy Shevchenko <Andy Shevchenko> PATCH v1: - first submit Kejian Yan (2): net: hns: fix return value of the function about rss net: hns: fixes a bug of RSS drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 8 ++++--- drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 28 ++++++++++++++++------- 3 files changed, 26 insertions(+), 12 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool @ 2016-03-11 3:25 ` Kejian Yan 0 siblings, 0 replies; 10+ messages in thread From: Kejian Yan @ 2016-03-11 3:25 UTC (permalink / raw) To: davem Cc: yisen.zhuang, salil.mehta, liguozhu, huangdaode, arnd, andriy.shevchenko, andrew, chenny.xu, ivecera, lisheng011, fengguang.wu, haifeng.wei, netdev, linux-kernel, linux-arm-kernel, linuxarm When we use ethtool to retrieves or configure the receive flow hash indirection table, ethtool needs to call .get_rxnfc to get the ring number so this patchset implements the .get_rxnfc and fixes the bug that we can not get the tatal table each time. --- change log: PATCH v3: - This patchset fixes the building warning and error PATCH v2: - This patchset fixes the comments provided by Andy Shevchenko <Andy Shevchenko> PATCH v1: - first submit Kejian Yan (2): net: hns: fix return value of the function about rss net: hns: fixes a bug of RSS drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 8 ++++--- drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 28 ++++++++++++++++------- 3 files changed, 26 insertions(+), 12 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 net-next 1/2] net: hns: fix return value of the function about rss 2016-03-11 3:25 ` Kejian Yan @ 2016-03-11 3:25 ` Kejian Yan -1 siblings, 0 replies; 10+ messages in thread From: Kejian Yan @ 2016-03-11 3:25 UTC (permalink / raw) To: linux-arm-kernel Both .get_rxfh and .get_rxfh are always return 0, it should return result from hardware when getting or setting rss. And the rss function should return the correct data type. Signed-off-by: Kejian Yan <yankejian@huawei.com> --- change log: PATCH v3: - This patch removes unused variable 'ret' to fix the build warning PATCH v2: - This patch fixes the comments provided by Andy Shevchenko <Andy Shevchenko> Link: https://lkml.org/lkml/2016/3/10/266 PATCH v1: - first submit Link: https://lkml.org/lkml/2016/3/9/978 --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 14 ++++---------- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c index d4f92ed..d07db1f 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c @@ -799,7 +799,7 @@ static int hns_ae_set_rss(struct hnae_handle *handle, const u32 *indir, /* set the RSS Hash Key if specififed by the user */ if (key) - hns_ppe_set_rss_key(ppe_cb, (int *)key); + hns_ppe_set_rss_key(ppe_cb, (u32 *)key); /* update the shadow RSS table with user specified qids */ memcpy(ppe_cb->rss_indir_table, indir, HNS_PPEV2_RSS_IND_TBL_SIZE); diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c index f302ef9..811ef35 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c @@ -27,7 +27,7 @@ void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) void hns_ppe_set_rss_key(struct hns_ppe_cb *ppe_cb, const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM]) { - int key_item = 0; + u32 key_item = 0; for (key_item = 0; key_item < HNS_PPEV2_RSS_KEY_NUM; key_item++) dsaf_write_dev(ppe_cb, PPEV2_RSS_KEY_REG + key_item * 0x4, diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 3c4a3bc..01b65eb 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -1178,7 +1178,7 @@ hns_get_rss_key_size(struct net_device *netdev) if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, "RSS feature is not supported on this hardware\n"); - return -EOPNOTSUPP; + return (u32)-EOPNOTSUPP; } ops = priv->ae_handle->dev->ops; @@ -1197,7 +1197,7 @@ hns_get_rss_indir_size(struct net_device *netdev) if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, "RSS feature is not supported on this hardware\n"); - return -EOPNOTSUPP; + return (u32)-EOPNOTSUPP; } ops = priv->ae_handle->dev->ops; @@ -1211,7 +1211,6 @@ hns_get_rss(struct net_device *netdev, u32 *indir, u8 *key, u8 *hfunc) { struct hns_nic_priv *priv = netdev_priv(netdev); struct hnae_ae_ops *ops; - int ret; if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, @@ -1224,9 +1223,7 @@ hns_get_rss(struct net_device *netdev, u32 *indir, u8 *key, u8 *hfunc) if (!indir) return 0; - ret = ops->get_rss(priv->ae_handle, indir, key, hfunc); - - return 0; + return ops->get_rss(priv->ae_handle, indir, key, hfunc); } static int @@ -1235,7 +1232,6 @@ hns_set_rss(struct net_device *netdev, const u32 *indir, const u8 *key, { struct hns_nic_priv *priv = netdev_priv(netdev); struct hnae_ae_ops *ops; - int ret; if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, @@ -1252,9 +1248,7 @@ hns_set_rss(struct net_device *netdev, const u32 *indir, const u8 *key, if (!indir) return 0; - ret = ops->set_rss(priv->ae_handle, indir, key, hfunc); - - return 0; + return ops->set_rss(priv->ae_handle, indir, key, hfunc); } static struct ethtool_ops hns_ethtool_ops = { -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 net-next 1/2] net: hns: fix return value of the function about rss @ 2016-03-11 3:25 ` Kejian Yan 0 siblings, 0 replies; 10+ messages in thread From: Kejian Yan @ 2016-03-11 3:25 UTC (permalink / raw) To: davem Cc: yisen.zhuang, salil.mehta, liguozhu, huangdaode, arnd, andriy.shevchenko, andrew, chenny.xu, ivecera, lisheng011, fengguang.wu, haifeng.wei, netdev, linux-kernel, linux-arm-kernel, linuxarm Both .get_rxfh and .get_rxfh are always return 0, it should return result from hardware when getting or setting rss. And the rss function should return the correct data type. Signed-off-by: Kejian Yan <yankejian@huawei.com> --- change log: PATCH v3: - This patch removes unused variable 'ret' to fix the build warning PATCH v2: - This patch fixes the comments provided by Andy Shevchenko <Andy Shevchenko> Link: https://lkml.org/lkml/2016/3/10/266 PATCH v1: - first submit Link: https://lkml.org/lkml/2016/3/9/978 --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 2 +- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 14 ++++---------- 3 files changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c index d4f92ed..d07db1f 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c @@ -799,7 +799,7 @@ static int hns_ae_set_rss(struct hnae_handle *handle, const u32 *indir, /* set the RSS Hash Key if specififed by the user */ if (key) - hns_ppe_set_rss_key(ppe_cb, (int *)key); + hns_ppe_set_rss_key(ppe_cb, (u32 *)key); /* update the shadow RSS table with user specified qids */ memcpy(ppe_cb->rss_indir_table, indir, HNS_PPEV2_RSS_IND_TBL_SIZE); diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c index f302ef9..811ef35 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c @@ -27,7 +27,7 @@ void hns_ppe_set_tso_enable(struct hns_ppe_cb *ppe_cb, u32 value) void hns_ppe_set_rss_key(struct hns_ppe_cb *ppe_cb, const u32 rss_key[HNS_PPEV2_RSS_KEY_NUM]) { - int key_item = 0; + u32 key_item = 0; for (key_item = 0; key_item < HNS_PPEV2_RSS_KEY_NUM; key_item++) dsaf_write_dev(ppe_cb, PPEV2_RSS_KEY_REG + key_item * 0x4, diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 3c4a3bc..01b65eb 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -1178,7 +1178,7 @@ hns_get_rss_key_size(struct net_device *netdev) if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, "RSS feature is not supported on this hardware\n"); - return -EOPNOTSUPP; + return (u32)-EOPNOTSUPP; } ops = priv->ae_handle->dev->ops; @@ -1197,7 +1197,7 @@ hns_get_rss_indir_size(struct net_device *netdev) if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, "RSS feature is not supported on this hardware\n"); - return -EOPNOTSUPP; + return (u32)-EOPNOTSUPP; } ops = priv->ae_handle->dev->ops; @@ -1211,7 +1211,6 @@ hns_get_rss(struct net_device *netdev, u32 *indir, u8 *key, u8 *hfunc) { struct hns_nic_priv *priv = netdev_priv(netdev); struct hnae_ae_ops *ops; - int ret; if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, @@ -1224,9 +1223,7 @@ hns_get_rss(struct net_device *netdev, u32 *indir, u8 *key, u8 *hfunc) if (!indir) return 0; - ret = ops->get_rss(priv->ae_handle, indir, key, hfunc); - - return 0; + return ops->get_rss(priv->ae_handle, indir, key, hfunc); } static int @@ -1235,7 +1232,6 @@ hns_set_rss(struct net_device *netdev, const u32 *indir, const u8 *key, { struct hns_nic_priv *priv = netdev_priv(netdev); struct hnae_ae_ops *ops; - int ret; if (AE_IS_VER1(priv->enet_ver)) { netdev_err(netdev, @@ -1252,9 +1248,7 @@ hns_set_rss(struct net_device *netdev, const u32 *indir, const u8 *key, if (!indir) return 0; - ret = ops->set_rss(priv->ae_handle, indir, key, hfunc); - - return 0; + return ops->set_rss(priv->ae_handle, indir, key, hfunc); } static struct ethtool_ops hns_ethtool_ops = { -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 net-next 2/2] net: hns: fixes a bug of RSS 2016-03-11 3:25 ` Kejian Yan @ 2016-03-11 3:25 ` Kejian Yan -1 siblings, 0 replies; 10+ messages in thread From: Kejian Yan @ 2016-03-11 3:25 UTC (permalink / raw) To: linux-arm-kernel If trying to get receive flow hash indirection table by ethtool, it needs to call .get_rxnfc to get ring number first. So this patch implements the .get_rxnfc of ethtool. And the data type of rss_indir_table is u32, it has to be multiply by the width of data type when using memcpy. Signed-off-by: Kejian Yan <yankejian@huawei.com> --- change log: PATCH v3: - This patch modifies the return value of .get_rxnfc to fix building error PATCH v2: - This patch fixes the comments provided by Andy Shevchenko <Andy Shevchenko> Link: https://lkml.org/lkml/2016/3/10/267 PATCH v1: - first submit Link: https://lkml.org/lkml/2016/3/9/981 --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 6 ++++-- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c index d07db1f..7b06e9b 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c @@ -787,7 +787,8 @@ static int hns_ae_get_rss(struct hnae_handle *handle, u32 *indir, u8 *key, memcpy(key, ppe_cb->rss_key, HNS_PPEV2_RSS_KEY_SIZE); /* update the current hash->queue mappings from the shadow RSS table */ - memcpy(indir, ppe_cb->rss_indir_table, HNS_PPEV2_RSS_IND_TBL_SIZE); + memcpy(indir, ppe_cb->rss_indir_table, + HNS_PPEV2_RSS_IND_TBL_SIZE * sizeof(*indir)); return 0; } @@ -802,7 +803,8 @@ static int hns_ae_set_rss(struct hnae_handle *handle, const u32 *indir, hns_ppe_set_rss_key(ppe_cb, (u32 *)key); /* update the shadow RSS table with user specified qids */ - memcpy(ppe_cb->rss_indir_table, indir, HNS_PPEV2_RSS_IND_TBL_SIZE); + memcpy(ppe_cb->rss_indir_table, indir, + HNS_PPEV2_RSS_IND_TBL_SIZE * sizeof(*indir)); /* now update the hardware */ hns_ppe_set_indir_table(ppe_cb, ppe_cb->rss_indir_table); diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 01b65eb..46379ce 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -1251,6 +1251,23 @@ hns_set_rss(struct net_device *netdev, const u32 *indir, const u8 *key, return ops->set_rss(priv->ae_handle, indir, key, hfunc); } +static int hns_get_rxnfc(struct net_device *netdev, + struct ethtool_rxnfc *cmd, + u32 *rule_locs) +{ + struct hns_nic_priv *priv = netdev_priv(netdev); + + switch (cmd->cmd) { + case ETHTOOL_GRXRINGS: + cmd->data = priv->ae_handle->q_num; + break; + default: + return -EOPNOTSUPP; + } + + return 0; +} + static struct ethtool_ops hns_ethtool_ops = { .get_drvinfo = hns_nic_get_drvinfo, .get_link = hns_nic_get_link, @@ -1274,6 +1291,7 @@ static struct ethtool_ops hns_ethtool_ops = { .get_rxfh_indir_size = hns_get_rss_indir_size, .get_rxfh = hns_get_rss, .set_rxfh = hns_set_rss, + .get_rxnfc = hns_get_rxnfc, }; void hns_ethtool_set_ops(struct net_device *ndev) -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 net-next 2/2] net: hns: fixes a bug of RSS @ 2016-03-11 3:25 ` Kejian Yan 0 siblings, 0 replies; 10+ messages in thread From: Kejian Yan @ 2016-03-11 3:25 UTC (permalink / raw) To: davem Cc: yisen.zhuang, salil.mehta, liguozhu, huangdaode, arnd, andriy.shevchenko, andrew, chenny.xu, ivecera, lisheng011, fengguang.wu, haifeng.wei, netdev, linux-kernel, linux-arm-kernel, linuxarm If trying to get receive flow hash indirection table by ethtool, it needs to call .get_rxnfc to get ring number first. So this patch implements the .get_rxnfc of ethtool. And the data type of rss_indir_table is u32, it has to be multiply by the width of data type when using memcpy. Signed-off-by: Kejian Yan <yankejian@huawei.com> --- change log: PATCH v3: - This patch modifies the return value of .get_rxnfc to fix building error PATCH v2: - This patch fixes the comments provided by Andy Shevchenko <Andy Shevchenko> Link: https://lkml.org/lkml/2016/3/10/267 PATCH v1: - first submit Link: https://lkml.org/lkml/2016/3/9/981 --- drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 6 ++++-- drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 18 ++++++++++++++++++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c index d07db1f..7b06e9b 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c @@ -787,7 +787,8 @@ static int hns_ae_get_rss(struct hnae_handle *handle, u32 *indir, u8 *key, memcpy(key, ppe_cb->rss_key, HNS_PPEV2_RSS_KEY_SIZE); /* update the current hash->queue mappings from the shadow RSS table */ - memcpy(indir, ppe_cb->rss_indir_table, HNS_PPEV2_RSS_IND_TBL_SIZE); + memcpy(indir, ppe_cb->rss_indir_table, + HNS_PPEV2_RSS_IND_TBL_SIZE * sizeof(*indir)); return 0; } @@ -802,7 +803,8 @@ static int hns_ae_set_rss(struct hnae_handle *handle, const u32 *indir, hns_ppe_set_rss_key(ppe_cb, (u32 *)key); /* update the shadow RSS table with user specified qids */ - memcpy(ppe_cb->rss_indir_table, indir, HNS_PPEV2_RSS_IND_TBL_SIZE); + memcpy(ppe_cb->rss_indir_table, indir, + HNS_PPEV2_RSS_IND_TBL_SIZE * sizeof(*indir)); /* now update the hardware */ hns_ppe_set_indir_table(ppe_cb, ppe_cb->rss_indir_table); diff --git a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c index 01b65eb..46379ce 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_ethtool.c @@ -1251,6 +1251,23 @@ hns_set_rss(struct net_device *netdev, const u32 *indir, const u8 *key, return ops->set_rss(priv->ae_handle, indir, key, hfunc); } +static int hns_get_rxnfc(struct net_device *netdev, + struct ethtool_rxnfc *cmd, + u32 *rule_locs) +{ + struct hns_nic_priv *priv = netdev_priv(netdev); + + switch (cmd->cmd) { + case ETHTOOL_GRXRINGS: + cmd->data = priv->ae_handle->q_num; + break; + default: + return -EOPNOTSUPP; + } + + return 0; +} + static struct ethtool_ops hns_ethtool_ops = { .get_drvinfo = hns_nic_get_drvinfo, .get_link = hns_nic_get_link, @@ -1274,6 +1291,7 @@ static struct ethtool_ops hns_ethtool_ops = { .get_rxfh_indir_size = hns_get_rss_indir_size, .get_rxfh = hns_get_rss, .set_rxfh = hns_set_rss, + .get_rxnfc = hns_get_rxnfc, }; void hns_ethtool_set_ops(struct net_device *ndev) -- 1.9.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool 2016-03-11 3:25 ` Kejian Yan @ 2016-03-11 9:01 ` Andy Shevchenko -1 siblings, 0 replies; 10+ messages in thread From: Andy Shevchenko @ 2016-03-11 9:01 UTC (permalink / raw) To: linux-arm-kernel On Fri, 2016-03-11 at 11:25 +0800, Kejian Yan wrote: > When we use ethtool to retrieves or configure the receive flow hash? > indirection table, ethtool needs to call .get_rxnfc to get the ring > number > so this patchset implements the .get_rxnfc and fixes the bug that we > can > not get the tatal table each time. > FWIW: Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > change log: > PATCH v3: > ?- This patchset fixes the building warning and error > > PATCH v2: > ?- This patchset fixes the comments provided by Andy Shevchenko <Andy > Shevchenko> > > PATCH v1: > ?- first submit > > Kejian Yan (2): > ? net: hns: fix return value of the function about rss > ? net: hns: fixes a bug of RSS > > ?drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c |??8 ++++--- > ?drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c |??2 +- > ?drivers/net/ethernet/hisilicon/hns/hns_ethtool.c??| 28 > ++++++++++++++++------- > ?3 files changed, 26 insertions(+), 12 deletions(-) > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool @ 2016-03-11 9:01 ` Andy Shevchenko 0 siblings, 0 replies; 10+ messages in thread From: Andy Shevchenko @ 2016-03-11 9:01 UTC (permalink / raw) To: Kejian Yan, davem Cc: yisen.zhuang, salil.mehta, liguozhu, huangdaode, arnd, andrew, chenny.xu, ivecera, lisheng011, fengguang.wu, haifeng.wei, netdev, linux-kernel, linux-arm-kernel, linuxarm On Fri, 2016-03-11 at 11:25 +0800, Kejian Yan wrote: > When we use ethtool to retrieves or configure the receive flow hash > indirection table, ethtool needs to call .get_rxnfc to get the ring > number > so this patchset implements the .get_rxnfc and fixes the bug that we > can > not get the tatal table each time. > FWIW: Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > change log: > PATCH v3: > - This patchset fixes the building warning and error > > PATCH v2: > - This patchset fixes the comments provided by Andy Shevchenko <Andy > Shevchenko> > > PATCH v1: > - first submit > > Kejian Yan (2): > net: hns: fix return value of the function about rss > net: hns: fixes a bug of RSS > > drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 8 ++++--- > drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 2 +- > drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 28 > ++++++++++++++++------- > 3 files changed, 26 insertions(+), 12 deletions(-) > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool 2016-03-11 9:01 ` Andy Shevchenko @ 2016-03-14 4:27 ` Yankejian (Hackim Yim) -1 siblings, 0 replies; 10+ messages in thread From: Yankejian (Hackim Yim) @ 2016-03-14 4:27 UTC (permalink / raw) To: linux-arm-kernel On 2016/3/11 17:01, Andy Shevchenko wrote: > On Fri, 2016-03-11 at 11:25 +0800, Kejian Yan wrote: >> When we use ethtool to retrieves or configure the receive flow hash >> indirection table, ethtool needs to call .get_rxnfc to get the ring >> number >> so this patchset implements the .get_rxnfc and fixes the bug that we >> can >> not get the tatal table each time. >> > FWIW: > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Hi Andy, I'm sorry for missing it.i will fix it in next submit. MBR, Kejian >> --- >> change log: >> PATCH v3: >> - This patchset fixes the building warning and error >> >> PATCH v2: >> - This patchset fixes the comments provided by Andy Shevchenko <Andy >> Shevchenko> >> >> PATCH v1: >> - first submit >> >> Kejian Yan (2): >> net: hns: fix return value of the function about rss >> net: hns: fixes a bug of RSS >> >> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 8 ++++--- >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 2 +- >> drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 28 >> ++++++++++++++++------- >> 3 files changed, 26 insertions(+), 12 deletions(-) >> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool @ 2016-03-14 4:27 ` Yankejian (Hackim Yim) 0 siblings, 0 replies; 10+ messages in thread From: Yankejian (Hackim Yim) @ 2016-03-14 4:27 UTC (permalink / raw) To: Andy Shevchenko, davem Cc: yisen.zhuang, salil.mehta, liguozhu, huangdaode, arnd, andrew, chenny.xu, ivecera, lisheng011, fengguang.wu, haifeng.wei, netdev, linux-kernel, linux-arm-kernel, linuxarm On 2016/3/11 17:01, Andy Shevchenko wrote: > On Fri, 2016-03-11 at 11:25 +0800, Kejian Yan wrote: >> When we use ethtool to retrieves or configure the receive flow hash >> indirection table, ethtool needs to call .get_rxnfc to get the ring >> number >> so this patchset implements the .get_rxnfc and fixes the bug that we >> can >> not get the tatal table each time. >> > FWIW: > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Hi Andy, I'm sorry for missing it.i will fix it in next submit. MBR, Kejian >> --- >> change log: >> PATCH v3: >> - This patchset fixes the building warning and error >> >> PATCH v2: >> - This patchset fixes the comments provided by Andy Shevchenko <Andy >> Shevchenko> >> >> PATCH v1: >> - first submit >> >> Kejian Yan (2): >> net: hns: fix return value of the function about rss >> net: hns: fixes a bug of RSS >> >> drivers/net/ethernet/hisilicon/hns/hns_ae_adapt.c | 8 ++++--- >> drivers/net/ethernet/hisilicon/hns/hns_dsaf_ppe.c | 2 +- >> drivers/net/ethernet/hisilicon/hns/hns_ethtool.c | 28 >> ++++++++++++++++------- >> 3 files changed, 26 insertions(+), 12 deletions(-) >> ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-03-14 4:28 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-03-11 3:25 [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool Kejian Yan 2016-03-11 3:25 ` Kejian Yan 2016-03-11 3:25 ` [PATCH v3 net-next 1/2] net: hns: fix return value of the function about rss Kejian Yan 2016-03-11 3:25 ` Kejian Yan 2016-03-11 3:25 ` [PATCH v3 net-next 2/2] net: hns: fixes a bug of RSS Kejian Yan 2016-03-11 3:25 ` Kejian Yan 2016-03-11 9:01 ` [PATCH v3 net-next 0/2] net: hns: get and set RSS indirection table by using ethtool Andy Shevchenko 2016-03-11 9:01 ` Andy Shevchenko 2016-03-14 4:27 ` Yankejian (Hackim Yim) 2016-03-14 4:27 ` Yankejian (Hackim Yim)
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.