From: Caesar Wang <wxt@rock-chips.com>
To: linus.walleij@linaro.org, heiko@sntech.de
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: rockchip: add support the get_direction
Date: Mon, 14 Mar 2016 13:57:26 +0800 [thread overview]
Message-ID: <56E652C6.7030503@rock-chips.com> (raw)
In-Reply-To: <1457934266-29862-1-git-send-email-wxt@rock-chips.com>
在 2016年03月14日 13:44, Caesar Wang 写道:
> This patch adds the get_direction to support the gpio
> interface.
>
> the gpio direction is not used on rockchip platform when use the gpio
> debugfs.
>
> Tested on kylin board. (RK3036 SoCs)
> The repro steps:
> $/sys/class/gpio/
> echo 53 > export
> $/sys/class/gpio/gpio53# cat direction
> in
> In general, the gpio53 should be out value, but the direction is the
> default value 'in', since the get_direction didn't supported in rockchip
> pinctrl.
>
> So, we should add this patch to support it.
>
> Change-Id: I237c2e85ac7680b3d0de15bbbb923985b4827def
Resend it since the change id, sorry for the noise.
> Reported-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index bf032b9..f22a186 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1208,6 +1208,18 @@ static int rockchip_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
> return 0;
> }
>
> +static int rockchip_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> +{
> + struct rockchip_pin_bank *bank = gpiochip_get_data(chip);
> + int pin;
> + u32 data;
> +
> + pin = offset - chip->base;
> + data = readl_relaxed(bank->reg_base + GPIO_SWPORT_DDR);
> +
> + return !!(data & BIT(pin));
> +}
> +
> /*
> * The calls to gpio_direction_output() and gpio_direction_input()
> * leads to this function call (via the pinctrl_gpio_direction_{input|output}()
> @@ -1741,6 +1753,7 @@ static const struct gpio_chip rockchip_gpiolib_chip = {
> .free = gpiochip_generic_free,
> .set = rockchip_gpio_set,
> .get = rockchip_gpio_get,
> + .get_direction = rockchip_gpio_get_direction,
> .direction_input = rockchip_gpio_direction_input,
> .direction_output = rockchip_gpio_direction_output,
> .to_irq = rockchip_gpio_to_irq,
--
caesar wang | software engineer | wxt@rock-chip.com
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Caesar Wang <wxt@rock-chips.com>
To: linus.walleij@linaro.org, heiko@sntech.de
Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pinctrl: rockchip: add support the get_direction
Date: Mon, 14 Mar 2016 13:57:26 +0800 [thread overview]
Message-ID: <56E652C6.7030503@rock-chips.com> (raw)
In-Reply-To: <1457934266-29862-1-git-send-email-wxt@rock-chips.com>
在 2016年03月14日 13:44, Caesar Wang 写道:
> This patch adds the get_direction to support the gpio
> interface.
>
> the gpio direction is not used on rockchip platform when use the gpio
> debugfs.
>
> Tested on kylin board. (RK3036 SoCs)
> The repro steps:
> $/sys/class/gpio/
> echo 53 > export
> $/sys/class/gpio/gpio53# cat direction
> in
> In general, the gpio53 should be out value, but the direction is the
> default value 'in', since the get_direction didn't supported in rockchip
> pinctrl.
>
> So, we should add this patch to support it.
>
> Change-Id: I237c2e85ac7680b3d0de15bbbb923985b4827def
Resend it since the change id, sorry for the noise.
> Reported-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-gpio@vger.kernel.org
> Cc: linux-rockchip@lists.infradead.org
> ---
> drivers/pinctrl/pinctrl-rockchip.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
> index bf032b9..f22a186 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1208,6 +1208,18 @@ static int rockchip_pmx_set(struct pinctrl_dev *pctldev, unsigned selector,
> return 0;
> }
>
> +static int rockchip_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> +{
> + struct rockchip_pin_bank *bank = gpiochip_get_data(chip);
> + int pin;
> + u32 data;
> +
> + pin = offset - chip->base;
> + data = readl_relaxed(bank->reg_base + GPIO_SWPORT_DDR);
> +
> + return !!(data & BIT(pin));
> +}
> +
> /*
> * The calls to gpio_direction_output() and gpio_direction_input()
> * leads to this function call (via the pinctrl_gpio_direction_{input|output}()
> @@ -1741,6 +1753,7 @@ static const struct gpio_chip rockchip_gpiolib_chip = {
> .free = gpiochip_generic_free,
> .set = rockchip_gpio_set,
> .get = rockchip_gpio_get,
> + .get_direction = rockchip_gpio_get_direction,
> .direction_input = rockchip_gpio_direction_input,
> .direction_output = rockchip_gpio_direction_output,
> .to_irq = rockchip_gpio_to_irq,
--
caesar wang | software engineer | wxt@rock-chip.com
next prev parent reply other threads:[~2016-03-14 5:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 5:44 [PATCH] pinctrl: rockchip: add support the get_direction Caesar Wang
2016-03-14 5:57 ` Caesar Wang [this message]
2016-03-14 5:57 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E652C6.7030503@rock-chips.com \
--to=wxt@rock-chips.com \
--cc=heiko@sntech.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.