* [Ocfs2-devel] [PATCH V2] ocfs2/dlm: fix a variable overflow problem in dlmdomain.c
@ 2016-03-14 12:41 piaojun
2016-03-14 12:46 ` Joseph Qi
0 siblings, 1 reply; 2+ messages in thread
From: piaojun @ 2016-03-14 12:41 UTC (permalink / raw)
To: ocfs2-devel
In dlm_send_join_cancels(), node is defined with type unsigned int, but
initialized with -1, this will lead variable overflow. Although this
won't cause any runtime problem, the code looks a little uncoordinated.
Signed-off-by: Jun Piao <piaojun@huawei.com>
---
dlm/dlmdomain.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c
index 2ee7fe7..8cbf6e8 100644
--- a/dlm/dlmdomain.c
+++ b/dlm/dlmdomain.c
@@ -1396,7 +1396,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm,
unsigned int map_size)
{
int status, tmpstat;
- unsigned int node;
+ int node;
if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) *
sizeof(unsigned long))) {
--
1.8.4.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Ocfs2-devel] [PATCH V2] ocfs2/dlm: fix a variable overflow problem in dlmdomain.c
2016-03-14 12:41 [Ocfs2-devel] [PATCH V2] ocfs2/dlm: fix a variable overflow problem in dlmdomain.c piaojun
@ 2016-03-14 12:46 ` Joseph Qi
0 siblings, 0 replies; 2+ messages in thread
From: Joseph Qi @ 2016-03-14 12:46 UTC (permalink / raw)
To: ocfs2-devel
On 2016/3/14 20:41, piaojun wrote:
> In dlm_send_join_cancels(), node is defined with type unsigned int, but
> initialized with -1, this will lead variable overflow. Although this
> won't cause any runtime problem, the code looks a little uncoordinated.
>
> Signed-off-by: Jun Piao <piaojun@huawei.com>
Thanks, Jun.
Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
> ---
> dlm/dlmdomain.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dlm/dlmdomain.c b/dlm/dlmdomain.c
> index 2ee7fe7..8cbf6e8 100644
> --- a/dlm/dlmdomain.c
> +++ b/dlm/dlmdomain.c
> @@ -1396,7 +1396,7 @@ static int dlm_send_join_cancels(struct dlm_ctxt *dlm,
> unsigned int map_size)
> {
> int status, tmpstat;
> - unsigned int node;
> + int node;
>
> if (map_size != (BITS_TO_LONGS(O2NM_MAX_NODES) *
> sizeof(unsigned long))) {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-14 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-14 12:41 [Ocfs2-devel] [PATCH V2] ocfs2/dlm: fix a variable overflow problem in dlmdomain.c piaojun
2016-03-14 12:46 ` Joseph Qi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.