* Re: [PATCH] Avoid that long log lines are truncated
2016-03-14 14:19 [PATCH] Avoid that long log lines are truncated Bart Van Assche
@ 2016-03-14 14:32 ` Johannes Thumshirn
2016-03-14 14:36 ` Hannes Reinecke
2016-03-14 14:38 ` Ewan Milne
2 siblings, 0 replies; 5+ messages in thread
From: Johannes Thumshirn @ 2016-03-14 14:32 UTC (permalink / raw)
To: Bart Van Assche
Cc: James Bottomley, Martin K. Petersen, Hannes Reinecke,
Christoph Hellwig, Robert Elliott, Ewan D. Milne,
linux-scsi@vger.kernel.org
On Mon, Mar 14, 2016 at 07:19:55AM -0700, Bart Van Assche wrote:
> While testing the latest version of the SRP initiator and target
> drivers I encountered the following message in the kernel log:
>
> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
>
> This is a truncated message. Avoid that such truncation happens
> by increasing the SCSI_LOG_BUFSIZE constant.
>
> Fixes: ded85c193a39 (scsi: Implement per-cpu logging buffer)
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Avoid that long log lines are truncated
2016-03-14 14:19 [PATCH] Avoid that long log lines are truncated Bart Van Assche
2016-03-14 14:32 ` Johannes Thumshirn
@ 2016-03-14 14:36 ` Hannes Reinecke
2016-03-14 14:38 ` Ewan Milne
2 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2016-03-14 14:36 UTC (permalink / raw)
To: Bart Van Assche, James Bottomley, Martin K. Petersen
Cc: Christoph Hellwig, Robert Elliott, Ewan D. Milne,
linux-scsi@vger.kernel.org
On 03/14/2016 03:19 PM, Bart Van Assche wrote:
> While testing the latest version of the SRP initiator and target
> drivers I encountered the following message in the kernel log:
>
> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
>
> This is a truncated message. Avoid that such truncation happens
> by increasing the SCSI_LOG_BUFSIZE constant.
>
> Fixes: ded85c193a39 (scsi: Implement per-cpu logging buffer)
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Robert Elliott <elliott@hp.com>
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: <stable@vger.kernel.org> # v4.0+
> ---
> include/scsi/scsi_dbg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/scsi/scsi_dbg.h b/include/scsi/scsi_dbg.h
> index 56710e0..05d36eb 100644
> --- a/include/scsi/scsi_dbg.h
> +++ b/include/scsi/scsi_dbg.h
> @@ -5,7 +5,7 @@ struct scsi_cmnd;
> struct scsi_device;
> struct scsi_sense_hdr;
>
> -#define SCSI_LOG_BUFSIZE 128
> +#define SCSI_LOG_BUFSIZE 256
>
> extern void scsi_print_command(struct scsi_cmnd *);
> extern size_t __scsi_format_command(char *, size_t,
>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Avoid that long log lines are truncated
2016-03-14 14:19 [PATCH] Avoid that long log lines are truncated Bart Van Assche
2016-03-14 14:32 ` Johannes Thumshirn
2016-03-14 14:36 ` Hannes Reinecke
@ 2016-03-14 14:38 ` Ewan Milne
2016-03-14 14:45 ` Hannes Reinecke
2 siblings, 1 reply; 5+ messages in thread
From: Ewan Milne @ 2016-03-14 14:38 UTC (permalink / raw)
To: Bart Van Assche
Cc: James Bottomley, Martin K. Petersen, Hannes Reinecke,
Christoph Hellwig, Robert Elliott, linux-scsi@vger.kernel.org
On Mon, 2016-03-14 at 07:19 -0700, Bart Van Assche wrote:
> While testing the latest version of the SRP initiator and target
> drivers I encountered the following message in the kernel log:
>
> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
>
> This is a truncated message. Avoid that such truncation happens
> by increasing the SCSI_LOG_BUFSIZE constant.
>
> Fixes: ded85c193a39 (scsi: Implement per-cpu logging buffer)
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Robert Elliott <elliott@hp.com>
> Cc: Ewan D. Milne <emilne@redhat.com>
> Cc: <stable@vger.kernel.org> # v4.0+
> ---
> include/scsi/scsi_dbg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/scsi/scsi_dbg.h b/include/scsi/scsi_dbg.h
> index 56710e0..05d36eb 100644
> --- a/include/scsi/scsi_dbg.h
> +++ b/include/scsi/scsi_dbg.h
> @@ -5,7 +5,7 @@ struct scsi_cmnd;
> struct scsi_device;
> struct scsi_sense_hdr;
>
> -#define SCSI_LOG_BUFSIZE 128
> +#define SCSI_LOG_BUFSIZE 256
>
> extern void scsi_print_command(struct scsi_cmnd *);
> extern size_t __scsi_format_command(char *, size_t,
Hmm. Perhaps we should make the message less verbose instead?
It looks like if we increase SCSI_LOG_BUFSIZE then we get fewer
per-message buffers unless we also increase SCSI_LOG_SPOOLSIZE.
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Avoid that long log lines are truncated
2016-03-14 14:38 ` Ewan Milne
@ 2016-03-14 14:45 ` Hannes Reinecke
0 siblings, 0 replies; 5+ messages in thread
From: Hannes Reinecke @ 2016-03-14 14:45 UTC (permalink / raw)
To: emilne, Bart Van Assche
Cc: James Bottomley, Martin K. Petersen, Christoph Hellwig,
Robert Elliott, linux-scsi@vger.kernel.org
On 03/14/2016 03:38 PM, Ewan Milne wrote:
> On Mon, 2016-03-14 at 07:19 -0700, Bart Van Assche wrote:
>> While testing the latest version of the SRP initiator and target
>> drivers I encountered the following message in the kernel log:
>>
>> sd 16:0:0:0: Warning! Received an indication that the LUN assignments on this target have changed. The Linux SCSI layer does not automatical
>>
>> This is a truncated message. Avoid that such truncation happens
>> by increasing the SCSI_LOG_BUFSIZE constant.
>>
>> Fixes: ded85c193a39 (scsi: Implement per-cpu logging buffer)
>> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
>> Cc: Hannes Reinecke <hare@suse.de>
>> Cc: Christoph Hellwig <hch@lst.de>
>> Cc: Robert Elliott <elliott@hp.com>
>> Cc: Ewan D. Milne <emilne@redhat.com>
>> Cc: <stable@vger.kernel.org> # v4.0+
>> ---
>> include/scsi/scsi_dbg.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/scsi/scsi_dbg.h b/include/scsi/scsi_dbg.h
>> index 56710e0..05d36eb 100644
>> --- a/include/scsi/scsi_dbg.h
>> +++ b/include/scsi/scsi_dbg.h
>> @@ -5,7 +5,7 @@ struct scsi_cmnd;
>> struct scsi_device;
>> struct scsi_sense_hdr;
>>
>> -#define SCSI_LOG_BUFSIZE 128
>> +#define SCSI_LOG_BUFSIZE 256
>>
>> extern void scsi_print_command(struct scsi_cmnd *);
>> extern size_t __scsi_format_command(char *, size_t,
>
> Hmm. Perhaps we should make the message less verbose instead?
> It looks like if we increase SCSI_LOG_BUFSIZE then we get fewer
> per-message buffers unless we also increase SCSI_LOG_SPOOLSIZE.
>
Or just shorten the message itself.
It's really annoying having these really long messages showing up in
the system log ...
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread