All of lore.kernel.org
 help / color / mirror / Atom feed
From: ddaney@caviumnetworks.com (David Daney)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.
Date: Mon, 14 Mar 2016 13:12:53 -0700	[thread overview]
Message-ID: <56E71B45.1010805@caviumnetworks.com> (raw)
In-Reply-To: <20160314.152751.2108458769066613871.davem@davemloft.net>

On 03/14/2016 12:27 PM, David Miller wrote:
> From: David Daney <ddaney.cavm@gmail.com>
> Date: Fri, 11 Mar 2016 09:53:08 -0800
>
>> Changes from v1:
>>
>>   - In 1/3 Add back check for non-OF objects in bgx_init_of_phy().  It
>>     is probably not necessary, but better safe than sorry...
>>
>> The firmware on many Cavium Thunder systems configures the MDIO bus
>> hardware to be probed as a PCI device.  In order to use the MDIO bus
>> drivers in this configuration, we must add PCI probing to the driver.
>>
>> There are two parts to this set of three patches:
>>
>>   1) Cleanup the PHY probing code in thunder_bgx.c to handle the case
>>      where there is no PHY attached to a port, as well as being more
>>      robust in the face of driver loading order by use of
>>      -EPROBE_DEFER.
>>
>>   2) Split mdio-octeon.c into two drivers, one with platform probing,
>>   and the other with PCI probing.  Common code is shared between the
>>   two.
>>
>> Tested on several different Thunder and OCTEON systems, also compile
>> tested on x86_64.
>
> Series applied, thanks David.


Thanks, but ... I was going to send another revision.

See: https://lkml.org/lkml/2016/3/11/721

There were a couple of items I wanted to fix.

   1) Missing MODULE_LICENSE() in new common code source file results in 
taint warnings.

   2) Fix device reference counts for -EPROBE_DEFER case.


At this point, I think the best path forward is for me to rebase against 
net-next and send you a small fixup set to what was merged.

What do you think?

David Daney

WARNING: multiple messages have this Message-ID (diff)
From: David Daney <ddaney@caviumnetworks.com>
To: David Miller <davem@davemloft.net>
Cc: <ddaney.cavm@gmail.com>, <netdev@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <f.fainelli@gmail.com>,
	<rric@kernel.org>, <sgoutham@cavium.com>, <galak@codeaurora.org>,
	<ijc+devicetree@hellion.org.uk>, <mark.rutland@arm.com>,
	<pawel.moll@arm.com>, <robh+dt@kernel.org>,
	<linux-kernel@vger.kernel.org>, <rchintakuntla@cavium.com>,
	<david.daney@cavium.com>
Subject: Re: [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code.
Date: Mon, 14 Mar 2016 13:12:53 -0700	[thread overview]
Message-ID: <56E71B45.1010805@caviumnetworks.com> (raw)
In-Reply-To: <20160314.152751.2108458769066613871.davem@davemloft.net>

On 03/14/2016 12:27 PM, David Miller wrote:
> From: David Daney <ddaney.cavm@gmail.com>
> Date: Fri, 11 Mar 2016 09:53:08 -0800
>
>> Changes from v1:
>>
>>   - In 1/3 Add back check for non-OF objects in bgx_init_of_phy().  It
>>     is probably not necessary, but better safe than sorry...
>>
>> The firmware on many Cavium Thunder systems configures the MDIO bus
>> hardware to be probed as a PCI device.  In order to use the MDIO bus
>> drivers in this configuration, we must add PCI probing to the driver.
>>
>> There are two parts to this set of three patches:
>>
>>   1) Cleanup the PHY probing code in thunder_bgx.c to handle the case
>>      where there is no PHY attached to a port, as well as being more
>>      robust in the face of driver loading order by use of
>>      -EPROBE_DEFER.
>>
>>   2) Split mdio-octeon.c into two drivers, one with platform probing,
>>   and the other with PCI probing.  Common code is shared between the
>>   two.
>>
>> Tested on several different Thunder and OCTEON systems, also compile
>> tested on x86_64.
>
> Series applied, thanks David.


Thanks, but ... I was going to send another revision.

See: https://lkml.org/lkml/2016/3/11/721

There were a couple of items I wanted to fix.

   1) Missing MODULE_LICENSE() in new common code source file results in 
taint warnings.

   2) Fix device reference counts for -EPROBE_DEFER case.


At this point, I think the best path forward is for me to rebase against 
net-next and send you a small fixup set to what was merged.

What do you think?

David Daney

  reply	other threads:[~2016-03-14 20:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-11 17:53 [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code David Daney
2016-03-11 17:53 ` David Daney
2016-03-11 17:53 ` [PATCH v2 1/3] net: thunderx: Cleanup PHY probing code David Daney
2016-03-11 17:53   ` David Daney
2016-03-11 17:53   ` David Daney
2016-03-11 17:53 ` [PATCH v2 2/3] phy: mdio-octeon: Refactor into two files/modules David Daney
2016-03-11 17:53   ` David Daney
2016-03-11 17:53 ` [PATCH v2 3/3] phy: mdio-thunder: Add driver for Cavium Thunder SoC MDIO buses David Daney
2016-03-11 17:53   ` David Daney
2016-03-16 22:50   ` Andreas Färber
2016-03-16 22:50     ` Andreas Färber
2016-03-16 22:54     ` David Daney
2016-03-16 22:54       ` David Daney
2016-03-16 23:24       ` Andreas Färber
2016-03-16 23:24         ` Andreas Färber
2016-03-12  0:08 ` [PATCH v2 0/3] net/phy: Improvements to Cavium Thunder MDIO code David Daney
2016-03-12  0:08   ` David Daney
2016-03-14 19:27 ` David Miller
2016-03-14 19:27   ` David Miller
2016-03-14 20:12   ` David Daney [this message]
2016-03-14 20:12     ` David Daney
2016-03-14 20:18     ` David Miller
2016-03-14 20:18       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E71B45.1010805@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.