From: Laxman Dewangan <ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org,
treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
bparrot-l0cyMroinI0@public.gmane.org,
acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios
Date: Tue, 15 Mar 2016 12:07:25 +0530 [thread overview]
Message-ID: <56E7ADA5.7000502@nvidia.com> (raw)
In-Reply-To: <56E6E753.1020505-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
On Monday 14 March 2016 10:01 PM, Stephen Warren wrote:
> On 03/11/2016 06:43 AM, Laxman Dewangan wrote:
>> The property "gpios" of GPIO hog node support the multiple GPIO entries.
>> Rephrase the details of this property for this new support.
>>
>> Add details of new property "label" for GPIO label name.
>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
>> b/Documentation/devicetree/bindings/gpio/gpio.txt
>
>> Optional properties:
>> - line-name: The GPIO label name. If not present the node name is
>> used.
>> +- label: The GPIO lable name. This can have multiple string for
>> GPIO
>> + label names to match with the GPIOs in "gpios" properties.
>> + If line-name is prosent than name is taken from line-name. If
>> + it is not then the name will be taken from label. If both are
>> + not available then node name is used for GPIO label name.
>
> Why are there two properties for the same thing? Why not just allow
> line-name to have multiple entries instead of introducing a new property?
>
We can use the lin-names also but per disucssion on the patch V1 of
gpio: of: Add support to have multiple gpios in gpio-hog
Markus suggested the discussion about the discussion
(https://lkml.org/lkml/2016/3/10/194):
"Device tree binding documentation for gpio-switch"
and on that, label is used. Also for names, "label" is going to very
common.
So I added new property "label" to support multiple names.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: <linus.walleij@linaro.org>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<mpa@pengutronix.de>, <treding@nvidia.com>, <bparrot@ti.com>,
<acourbot@nvidia.com>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios
Date: Tue, 15 Mar 2016 12:07:25 +0530 [thread overview]
Message-ID: <56E7ADA5.7000502@nvidia.com> (raw)
In-Reply-To: <56E6E753.1020505@wwwdotorg.org>
On Monday 14 March 2016 10:01 PM, Stephen Warren wrote:
> On 03/11/2016 06:43 AM, Laxman Dewangan wrote:
>> The property "gpios" of GPIO hog node support the multiple GPIO entries.
>> Rephrase the details of this property for this new support.
>>
>> Add details of new property "label" for GPIO label name.
>
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio.txt
>> b/Documentation/devicetree/bindings/gpio/gpio.txt
>
>> Optional properties:
>> - line-name: The GPIO label name. If not present the node name is
>> used.
>> +- label: The GPIO lable name. This can have multiple string for
>> GPIO
>> + label names to match with the GPIOs in "gpios" properties.
>> + If line-name is prosent than name is taken from line-name. If
>> + it is not then the name will be taken from label. If both are
>> + not available then node name is used for GPIO label name.
>
> Why are there two properties for the same thing? Why not just allow
> line-name to have multiple entries instead of introducing a new property?
>
We can use the lin-names also but per disucssion on the patch V1 of
gpio: of: Add support to have multiple gpios in gpio-hog
Markus suggested the discussion about the discussion
(https://lkml.org/lkml/2016/3/10/194):
"Device tree binding documentation for gpio-switch"
and on that, label is used. Also for names, "label" is going to very
common.
So I added new property "label" to support multiple names.
next prev parent reply other threads:[~2016-03-15 6:37 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-11 13:43 [PATCH V2 0/5] gpio: of: Add error handling and support for multiple gpio in gpio-hog Laxman Dewangan
2016-03-11 13:43 ` Laxman Dewangan
2016-03-11 13:43 ` [PATCH V2 1/5] gpio: of: Scan available child node for gpio-hog Laxman Dewangan
2016-03-11 13:43 ` Laxman Dewangan
2016-03-15 14:09 ` Linus Walleij
[not found] ` <1457703804-3016-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-11 13:43 ` [PATCH V2 2/5] gpio: gpiolib: Print error number if gpio hog failed Laxman Dewangan
2016-03-11 13:43 ` Laxman Dewangan
[not found] ` <1457703804-3016-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-15 14:11 ` Linus Walleij
2016-03-15 14:11 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 3/5] gpio: of: Return error if gpio hog configuration failed Laxman Dewangan
2016-03-11 13:43 ` Laxman Dewangan
2016-03-15 14:12 ` Linus Walleij
[not found] ` <CACRpkdbsu+yfFvCR2=vKO3+S46+GHSy+3wu+5uwMmsu0_mfP-Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 11:10 ` Laxman Dewangan
2016-03-16 11:10 ` Laxman Dewangan
[not found] ` <1457703804-3016-4-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-13 12:43 ` Linus Walleij
2016-04-13 12:43 ` Linus Walleij
[not found] ` <CACRpkdbLKWDGvhqtwoogNNgQjG86g9HmpceLLVwKW+94dJk63A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-13 12:54 ` Laxman Dewangan
2016-04-13 12:54 ` Laxman Dewangan
2016-04-14 12:52 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 4/5] gpio: DT: Rephrase "gpios" of hog node to support multiple gpios Laxman Dewangan
2016-03-11 13:43 ` Laxman Dewangan
[not found] ` <1457703804-3016-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-14 16:31 ` Stephen Warren
2016-03-14 16:31 ` Stephen Warren
[not found] ` <56E6E753.1020505-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-03-15 6:37 ` Laxman Dewangan [this message]
2016-03-15 6:37 ` Laxman Dewangan
[not found] ` <56E7ADA5.7000502-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-03-15 15:40 ` Stephen Warren
2016-03-15 15:40 ` Stephen Warren
2016-03-15 14:16 ` Linus Walleij
2016-03-15 14:16 ` Linus Walleij
2016-03-11 13:43 ` [PATCH V2 5/5] gpio: of: Add support to have multiple gpios in gpio-hog Laxman Dewangan
2016-03-11 13:43 ` Laxman Dewangan
2016-03-15 14:21 ` Linus Walleij
[not found] ` <CACRpkdaoKeKAJX1mOD2v1rG_5ZVjAo66agoZrs6E606syUDLSQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 11:18 ` Laxman Dewangan
2016-03-16 11:18 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7ADA5.7000502@nvidia.com \
--to=ldewangan-ddmlm1+adcrqt0dzr+alfa@public.gmane.org \
--cc=acourbot-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=bparrot-l0cyMroinI0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.