All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hsu <KCHSU0@nuvoton.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, anatol.pomozov@gmail.com,
	YHCHuang@nuvoton.com, lgirdwood@gmail.com, benzh@chromium.org,
	CTLIN0@nuvoton.com, mhkuo@nuvoton.com, yong.zhi@intel.com
Subject: Re: [PATCH] ASoC: nau8825: fix interrupt fails and unstable after resume
Date: Tue, 15 Mar 2016 15:53:03 +0800	[thread overview]
Message-ID: <56E7BF5F.5000103@nuvoton.com> (raw)
In-Reply-To: <56E1105E.8010604@nuvoton.com>

Hi,

On 3/10/2016 2:12 PM, John Hsu wrote:
>>>      regcache_cache_only(nau8825->regmap, false);
>>> -    regcache_sync(nau8825->regmap);
>>> -    enable_irq(client->irq);
>>> +    enable_irq(nau8825->irq);
>>>     
>>
>> We're removing the register cache sync here but I don't see us adding it
>> anywhere else.
>>   
> A part of suspend and resume action moves to set bias function, 
> nau8825_set_bias_level.
> We make register cache dirty in bias off; and make register cache sync 
> after resume in bias standby.
>
Just confirm it. Could you accept the explain about the register cache sync?
We need to change it or not? Very appreciate.

  reply	other threads:[~2016-03-15  7:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-28 19:01 [PATCH] ASoC: nau8825: fix interrupt fails and unstable after resume John Hsu
2016-02-28 19:47 ` [PATCH v2] ASoC: nau8825: reduce stanby power consumption John Hsu
2016-03-05  4:10   ` Mark Brown
2016-03-01  3:26 ` [PATCH] ASoC: nau8825: fix interrupt fails and unstable after resume Mark Brown
2016-03-10  6:12   ` John Hsu
2016-03-15  7:53     ` John Hsu [this message]
2016-03-15  9:27       ` Mark Brown
2016-03-15  9:27     ` Mark Brown
2016-03-16  3:45       ` John Hsu
  -- strict thread matches above, loose matches on Subject: below --
2016-03-22  3:57 John Hsu
2016-03-26  0:08 ` Ben Zhang
2016-03-30  9:35   ` John Hsu
2016-01-12  1:09 John Hsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E7BF5F.5000103@nuvoton.com \
    --to=kchsu0@nuvoton.com \
    --cc=CTLIN0@nuvoton.com \
    --cc=YHCHuang@nuvoton.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=anatol.pomozov@gmail.com \
    --cc=benzh@chromium.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=mhkuo@nuvoton.com \
    --cc=yong.zhi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.