From: "Cédric Le Goater" <clg@fr.ibm.com>
To: Thomas Huth <thuth@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR
Date: Tue, 15 Mar 2016 09:05:08 +0100 [thread overview]
Message-ID: <56E7C234.9060005@fr.ibm.com> (raw)
In-Reply-To: <56E71E8E.4090800@redhat.com>
On 03/14/2016 09:26 PM, Thomas Huth wrote:
>> > @@ -8093,7 +8137,7 @@ static void init_proc_book3s_64(CPUPPCState *env, int version)
>> > case BOOK3S_CPU_POWER7:
>> > case BOOK3S_CPU_POWER8:
>> > gen_spr_book3s_ids(env);
>> > - gen_spr_amr(env);
>> > + gen_spr_amr(env, version >= BOOK3S_CPU_POWER8);
>> > gen_spr_book3s_purr(env);
>> > env->ci_large_pages = true;
>> > break;
> I think this last hunk (and thus the "has_iamr" parameter of that
> function) rather belong to the next patch, since it is not used here yet.
Yes. I fixed a compile break but I moved the hunk in the wrong patch.
Thanks,
C.
next prev parent reply other threads:[~2016-03-15 8:05 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 16:56 [Qemu-devel] [PATCH 00/17] ppc: preparing pnv landing Cédric Le Goater
2016-03-14 16:56 ` [Qemu-devel] [PATCH 01/17] ppc: Update SPR definitions Cédric Le Goater
2016-03-14 18:34 ` Thomas Huth
2016-03-14 16:56 ` [Qemu-devel] [PATCH 02/17] ppc: Add macros to register hypervisor mode SPRs Cédric Le Goater
2016-03-14 18:50 ` Thomas Huth
2016-03-14 16:56 ` [Qemu-devel] [PATCH 03/17] ppc: Add a bunch of hypervisor SPRs to Book3s Cédric Le Goater
2016-03-14 19:14 ` Thomas Huth
2016-03-15 9:43 ` David Gibson
2016-03-15 10:49 ` Thomas Huth
2016-03-15 17:04 ` [Qemu-devel] [Qemu-ppc] " Cédric Le Goater
2016-03-16 1:04 ` [Qemu-devel] " David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 04/17] ppc: Add number of threads per core to the processor definition Cédric Le Goater
2016-03-14 19:20 ` Thomas Huth
2016-03-15 8:06 ` Cédric Le Goater
2016-03-15 8:21 ` Bharata B Rao
2016-03-15 9:45 ` David Gibson
2016-03-15 21:11 ` Benjamin Herrenschmidt
2016-03-16 0:41 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 05/17] ppc: Fix hreg_store_msr() so that non-HV mode cannot alter MSR:HV Cédric Le Goater
2016-03-14 19:29 ` Thomas Huth
2016-03-15 9:47 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 06/17] ppc: Create cpu_ppc_set_papr() helper Cédric Le Goater
2016-03-17 2:34 ` David Gibson
2016-03-17 12:33 ` Cédric Le Goater
2016-03-17 22:03 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 07/17] ppc: Better figure out if processor has HV mode Cédric Le Goater
2016-03-16 1:05 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 08/17] ppc: Add placeholder SPRs for DPDES and DHDES on P8 Cédric Le Goater
2016-03-14 19:32 ` Thomas Huth
2016-03-16 1:06 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 09/17] ppc: SPURR & PURR are HV writeable and privileged Cédric Le Goater
2016-03-14 19:37 ` Thomas Huth
2016-03-16 1:07 ` David Gibson
2016-03-16 1:07 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 10/17] ppc: Add dummy SPR_IC for POWER8 Cédric Le Goater
2016-03-14 19:40 ` Thomas Huth
2016-03-16 1:08 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 11/17] ppc: Initialize AMOR in PAPR mode Cédric Le Goater
2016-03-14 20:13 ` Thomas Huth
2016-03-16 1:09 ` David Gibson
2016-03-17 2:36 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR Cédric Le Goater
2016-03-14 20:26 ` Thomas Huth
2016-03-15 8:05 ` Cédric Le Goater [this message]
2016-03-14 16:56 ` [Qemu-devel] [PATCH 13/17] ppc: Add POWER8 IAMR register Cédric Le Goater
2016-03-14 20:36 ` Thomas Huth
2016-03-14 16:56 ` [Qemu-devel] [PATCH 14/17] ppc: Add dummy write to VTB Cédric Le Goater
2016-03-14 20:54 ` Thomas Huth
2016-03-14 21:07 ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2016-03-16 1:12 ` [Qemu-devel] " David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 15/17] ppc: Add dummy POWER8 MPPR register Cédric Le Goater
2016-03-16 1:14 ` David Gibson
2016-03-16 6:17 ` Thomas Huth
2016-03-16 9:24 ` Cédric Le Goater
2016-03-14 16:56 ` [Qemu-devel] [PATCH 16/17] ppc: Add dummy CIABR SPR Cédric Le Goater
2016-03-14 20:00 ` Thomas Huth
2016-03-16 1:14 ` David Gibson
2016-03-16 6:24 ` Thomas Huth
2016-03-16 22:28 ` David Gibson
2016-03-14 16:56 ` [Qemu-devel] [PATCH 17/17] ppc: A couple more dummy POWER8 Book4 regs Cédric Le Goater
2016-03-14 20:08 ` Thomas Huth
2016-03-16 1:15 ` David Gibson
2016-03-15 0:39 ` [Qemu-devel] [PATCH 00/17] ppc: preparing pnv landing David Gibson
2016-03-15 8:11 ` Cédric Le Goater
2016-03-16 1:19 ` David Gibson
2016-03-16 9:08 ` Cédric Le Goater
2016-03-17 2:45 ` David Gibson
2016-03-17 14:28 ` Cédric Le Goater
2016-03-21 0:59 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7C234.9060005@fr.ibm.com \
--to=clg@fr.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.