From: Joao.Pinto@synopsys.com (Joao Pinto)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves
Date: Tue, 15 Mar 2016 12:06:31 +0000 [thread overview]
Message-ID: <56E7FAC7.7030001@synopsys.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA23075F4E8FE8F@us01wembx1.internal.synopsys.com>
On 3/15/2016 11:38 AM, Vineet Gupta wrote:
> On Tuesday 15 March 2016 04:47 PM, Andreas Ziegler wrote:
>> Commit 5f8fc43217a0 ("PCI: Include pci/pcie/Kconfig directly from
>> pci/Kconfig") in linux-next changed drivers/pci/Kconfig to include
>> drivers/pci/pcie/Kconfig itself, so that architectures do not need
>> to source both files themselves. ARC just recently gained PCI support
>> through commit 6b3fb77998dd ("ARC: Add PCI support"), but this change
>> was based on the old behaviour of the Kconfig files. This makes
>> Kconfig now spit out the following warnings:
>>
>> drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice group
>> drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice group
>> drivers/pci/pcie/Kconfig:74:warning: choice value used outside its choice group
>>
>> This change updates the Kconfig file for ARC, dropping the now
>> unnecessary 'source' statement, which makes the warning disappear.
>>
>> Signed-off-by: Andreas Ziegler <andreas.ziegler at fau.de>
>
> Thx for the fix Andreas.
>
> @Bjorn sorry you might to have to pick this one up as well.
> If not, that's fine too - I'll queue it up once ARC PCI hits upstream.
>
> Thx,
> -Vineet
>
>> ---
>> arch/arc/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
>> index 69d05f5..282efec 100644
>> --- a/arch/arc/Kconfig
>> +++ b/arch/arc/Kconfig
>> @@ -592,7 +592,6 @@ config PCI_SYSCALL
>> def_bool PCI
>>
>> source "drivers/pci/Kconfig"
>> -source "drivers/pci/pcie/Kconfig"
>>
>> endmenu
>>
>
Acked-by: Joao Pinto <jpinto at synopsys.com>
WARNING: multiple messages have this Message-ID (diff)
From: Joao Pinto <Joao.Pinto@synopsys.com>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
Andreas Ziegler <andreas.ziegler@fau.de>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Joao Pinto <Joao.Pinto@synopsys.com>
Subject: Re: [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves
Date: Tue, 15 Mar 2016 12:06:31 +0000 [thread overview]
Message-ID: <56E7FAC7.7030001@synopsys.com> (raw)
In-Reply-To: <C2D7FE5348E1B147BCA15975FBA23075F4E8FE8F@us01wembx1.internal.synopsys.com>
On 3/15/2016 11:38 AM, Vineet Gupta wrote:
> On Tuesday 15 March 2016 04:47 PM, Andreas Ziegler wrote:
>> Commit 5f8fc43217a0 ("PCI: Include pci/pcie/Kconfig directly from
>> pci/Kconfig") in linux-next changed drivers/pci/Kconfig to include
>> drivers/pci/pcie/Kconfig itself, so that architectures do not need
>> to source both files themselves. ARC just recently gained PCI support
>> through commit 6b3fb77998dd ("ARC: Add PCI support"), but this change
>> was based on the old behaviour of the Kconfig files. This makes
>> Kconfig now spit out the following warnings:
>>
>> drivers/pci/pcie/Kconfig:61:warning: choice value used outside its choice group
>> drivers/pci/pcie/Kconfig:67:warning: choice value used outside its choice group
>> drivers/pci/pcie/Kconfig:74:warning: choice value used outside its choice group
>>
>> This change updates the Kconfig file for ARC, dropping the now
>> unnecessary 'source' statement, which makes the warning disappear.
>>
>> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
>
> Thx for the fix Andreas.
>
> @Bjorn sorry you might to have to pick this one up as well.
> If not, that's fine too - I'll queue it up once ARC PCI hits upstream.
>
> Thx,
> -Vineet
>
>> ---
>> arch/arc/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/arch/arc/Kconfig b/arch/arc/Kconfig
>> index 69d05f5..282efec 100644
>> --- a/arch/arc/Kconfig
>> +++ b/arch/arc/Kconfig
>> @@ -592,7 +592,6 @@ config PCI_SYSCALL
>> def_bool PCI
>>
>> source "drivers/pci/Kconfig"
>> -source "drivers/pci/pcie/Kconfig"
>>
>> endmenu
>>
>
Acked-by: Joao Pinto <jpinto@synopsys.com>
next prev parent reply other threads:[~2016-03-15 12:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 11:16 [PATCH] ARC: Don't source drivers/pci/pcie/Kconfig ourselves Andreas Ziegler
2016-03-15 11:16 ` Andreas Ziegler
2016-03-15 11:38 ` Vineet Gupta
2016-03-15 11:38 ` Vineet Gupta
2016-03-15 12:06 ` Joao Pinto [this message]
2016-03-15 12:06 ` Joao Pinto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7FAC7.7030001@synopsys.com \
--to=joao.pinto@synopsys.com \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.