From: Keerthy <a0393675@ti.com>
To: Eduardo Valentin <edubezval@gmail.com>, Rui Zhang <rui.zhang@intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 13/13] thermal: convert ti-thermal to use devm_thermal_zone_of_sensor_register
Date: Tue, 15 Mar 2016 17:56:54 +0530 [thread overview]
Message-ID: <56E7FF8E.8030209@ti.com> (raw)
In-Reply-To: <1457559336-17652-15-git-send-email-edubezval@gmail.com>
Hi Eduardo,
On Thursday 10 March 2016 03:05 AM, Eduardo Valentin wrote:
> This changes the driver to use the devm_ version
> of thermal_zone_of_sensor_register and cleans
> up the local points and unregister calls.
>
Boot tested on dra7xx-evm, dra72x-evm, pandaboard-es.
Also checked the thermal sysfs entries on am57xx-beagle-x15.
Tested-by: Keerthy <j-keerthy@ti.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
> ---
> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index b213a12..15c0a9a 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -337,7 +337,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
> return -EINVAL;
>
> /* in case this is specified by DT */
> - data->ti_thermal = thermal_zone_of_sensor_register(bgp->dev, id,
> + data->ti_thermal = devm_thermal_zone_of_sensor_register(bgp->dev, id,
> data, &ti_of_thermal_ops);
> if (IS_ERR(data->ti_thermal)) {
> /* Create thermal zone */
> @@ -368,9 +368,6 @@ int ti_thermal_remove_sensor(struct ti_bandgap *bgp, int id)
> if (data && data->ti_thermal) {
> if (data->our_zone)
> thermal_zone_device_unregister(data->ti_thermal);
> - else
> - thermal_zone_of_sensor_unregister(bgp->dev,
> - data->ti_thermal);
> }
>
> return 0;
>
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <a0393675@ti.com>
To: Eduardo Valentin <edubezval@gmail.com>, Rui Zhang <rui.zhang@intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
lm-sensors@lm-sensors.org, linux-omap@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 13/13] thermal: convert ti-thermal to use devm_thermal_zone_of_sensor_regist
Date: Tue, 15 Mar 2016 12:38:54 +0000 [thread overview]
Message-ID: <56E7FF8E.8030209@ti.com> (raw)
In-Reply-To: <1457559336-17652-15-git-send-email-edubezval@gmail.com>
Hi Eduardo,
On Thursday 10 March 2016 03:05 AM, Eduardo Valentin wrote:
> This changes the driver to use the devm_ version
> of thermal_zone_of_sensor_register and cleans
> up the local points and unregister calls.
>
Boot tested on dra7xx-evm, dra72x-evm, pandaboard-es.
Also checked the thermal sysfs entries on am57xx-beagle-x15.
Tested-by: Keerthy <j-keerthy@ti.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
> ---
> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index b213a12..15c0a9a 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -337,7 +337,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
> return -EINVAL;
>
> /* in case this is specified by DT */
> - data->ti_thermal = thermal_zone_of_sensor_register(bgp->dev, id,
> + data->ti_thermal = devm_thermal_zone_of_sensor_register(bgp->dev, id,
> data, &ti_of_thermal_ops);
> if (IS_ERR(data->ti_thermal)) {
> /* Create thermal zone */
> @@ -368,9 +368,6 @@ int ti_thermal_remove_sensor(struct ti_bandgap *bgp, int id)
> if (data && data->ti_thermal) {
> if (data->our_zone)
> thermal_zone_device_unregister(data->ti_thermal);
> - else
> - thermal_zone_of_sensor_unregister(bgp->dev,
> - data->ti_thermal);
> }
>
> return 0;
>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Keerthy <a0393675@ti.com>
To: Eduardo Valentin <edubezval@gmail.com>, Rui Zhang <rui.zhang@intel.com>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>, <lm-sensors@lm-sensors.org>,
<linux-omap@vger.kernel.org>
Subject: Re: [PATCH 13/13] thermal: convert ti-thermal to use devm_thermal_zone_of_sensor_register
Date: Tue, 15 Mar 2016 17:56:54 +0530 [thread overview]
Message-ID: <56E7FF8E.8030209@ti.com> (raw)
In-Reply-To: <1457559336-17652-15-git-send-email-edubezval@gmail.com>
Hi Eduardo,
On Thursday 10 March 2016 03:05 AM, Eduardo Valentin wrote:
> This changes the driver to use the devm_ version
> of thermal_zone_of_sensor_register and cleans
> up the local points and unregister calls.
>
Boot tested on dra7xx-evm, dra72x-evm, pandaboard-es.
Also checked the thermal sysfs entries on am57xx-beagle-x15.
Tested-by: Keerthy <j-keerthy@ti.com>
> Cc: Zhang Rui <rui.zhang@intel.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-omap@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
> ---
> drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> index b213a12..15c0a9a 100644
> --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c
> @@ -337,7 +337,7 @@ int ti_thermal_expose_sensor(struct ti_bandgap *bgp, int id,
> return -EINVAL;
>
> /* in case this is specified by DT */
> - data->ti_thermal = thermal_zone_of_sensor_register(bgp->dev, id,
> + data->ti_thermal = devm_thermal_zone_of_sensor_register(bgp->dev, id,
> data, &ti_of_thermal_ops);
> if (IS_ERR(data->ti_thermal)) {
> /* Create thermal zone */
> @@ -368,9 +368,6 @@ int ti_thermal_remove_sensor(struct ti_bandgap *bgp, int id)
> if (data && data->ti_thermal) {
> if (data->our_zone)
> thermal_zone_device_unregister(data->ti_thermal);
> - else
> - thermal_zone_of_sensor_unregister(bgp->dev,
> - data->ti_thermal);
> }
>
> return 0;
>
next prev parent reply other threads:[~2016-03-15 12:26 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 21:35 [PATCH 00/13] thermal: convert users of thermal_zone_of_sensor_register to devm_ Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-09 21:35 ` [PATCH 01/13] hwmon: convert lm75 to use devm_thermal_zone_of_sensor_register Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-10 0:02 ` kbuild test robot
2016-03-10 0:02 ` kbuild test robot
2016-03-10 0:02 ` [lm-sensors] " kbuild test robot
2016-03-10 3:18 ` Guenter Roeck
2016-03-10 3:18 ` [lm-sensors] " Guenter Roeck
2016-03-09 21:35 ` [PATCH 02/13] hwmon: convert ntc_thermistor " Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-10 0:14 ` kbuild test robot
2016-03-10 0:14 ` kbuild test robot
2016-03-10 0:14 ` [lm-sensors] [PATCH 02/13] hwmon: convert ntc_thermistor to use devm_thermal_zone_of_sensor_regi kbuild test robot
2016-03-10 2:16 ` [PATCH 02/13] hwmon: convert ntc_thermistor to use devm_thermal_zone_of_sensor_register kbuild test robot
2016-03-10 2:16 ` kbuild test robot
2016-03-10 2:16 ` [lm-sensors] [PATCH 02/13] hwmon: convert ntc_thermistor to use devm_thermal_zone_of_sensor_regi kbuild test robot
2016-03-10 3:19 ` [PATCH 02/13] hwmon: convert ntc_thermistor to use devm_thermal_zone_of_sensor_register Guenter Roeck
2016-03-10 3:19 ` [lm-sensors] [PATCH 02/13] hwmon: convert ntc_thermistor to use devm_thermal_zone_of_sensor_regi Guenter Roeck
2016-03-09 21:35 ` [PATCH 03/13] hwmon: convert tmp102 to use devm_thermal_zone_of_sensor_register Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-10 3:20 ` Guenter Roeck
2016-03-10 3:20 ` [lm-sensors] " Guenter Roeck
2016-03-10 4:43 ` kbuild test robot
2016-03-10 4:43 ` kbuild test robot
2016-03-10 4:43 ` [lm-sensors] " kbuild test robot
2016-03-09 21:35 ` [PATCH 04/13] hwmon: convert scpi-hwmon " Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-10 2:29 ` Guenter Roeck
2016-03-10 2:29 ` [lm-sensors] " Guenter Roeck
2016-03-14 19:49 ` Eduardo Valentin
2016-03-14 19:49 ` [lm-sensors] " Eduardo Valentin
2016-03-09 21:35 ` [PATCH 05/13] input: convert sun4i-ts " Eduardo Valentin
2016-03-09 21:35 ` Eduardo Valentin
2016-03-09 21:45 ` Dmitry Torokhov
2016-03-09 21:45 ` Dmitry Torokhov
2016-03-14 21:07 ` Eduardo Valentin
2016-03-14 21:07 ` Eduardo Valentin
2016-03-10 9:34 ` Sascha Hauer
2016-03-10 9:34 ` Sascha Hauer
2016-03-10 13:19 ` Hans de Goede
2016-03-10 13:19 ` Hans de Goede
2016-03-09 21:35 ` [PATCH 06/13] thermal: convert hisi_thermal " Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-09 21:35 ` [PATCH 08/13] thermal: convert qcom-spmi " Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-09 21:35 ` [PATCH 09/13] thermal: convert rcar_thermal " Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
[not found] ` <1457559336-17652-1-git-send-email-edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-09 21:35 ` [PATCH 07/13] thermal: convert mtk_thermal " Eduardo Valentin
2016-03-09 21:35 ` Eduardo Valentin
2016-03-09 21:35 ` Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-09 23:18 ` kbuild test robot
2016-03-09 23:18 ` kbuild test robot
2016-03-09 23:18 ` kbuild test robot
2016-03-09 21:35 ` [PATCH 10/13] thermal: convert rockchip_thermal " Eduardo Valentin
2016-03-09 21:35 ` Eduardo Valentin
2016-03-09 21:35 ` Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] [PATCH 10/13] thermal: convert rockchip_thermal to use devm_thermal_zone_of_sensor_regi Eduardo Valentin
2016-03-09 22:23 ` [PATCH 10/13] thermal: convert rockchip_thermal to use devm_thermal_zone_of_sensor_register Heiko Stübner
2016-03-09 22:23 ` Heiko Stübner
2016-03-09 22:23 ` [lm-sensors] [PATCH 10/13] thermal: convert rockchip_thermal to use devm_thermal_zone_of_sensor_ Heiko Stübner
2016-03-10 2:36 ` [PATCH 10/13] thermal: convert rockchip_thermal to use devm_thermal_zone_of_sensor_register Caesar Wang
2016-03-10 2:36 ` Caesar Wang
2016-03-10 2:36 ` [lm-sensors] [PATCH 10/13] thermal: convert rockchip_thermal to use devm_thermal_zone_of_sensor_ Caesar Wang
2016-03-09 21:35 ` [PATCH 11/13] thermal: convert exynos to use devm_thermal_zone_of_sensor_register Eduardo Valentin
2016-03-09 21:35 ` Eduardo Valentin
2016-03-09 21:35 ` Eduardo Valentin
2016-03-10 0:16 ` Krzysztof Kozlowski
2016-03-10 0:16 ` Krzysztof Kozlowski
2016-03-10 0:16 ` [lm-sensors] " Krzysztof Kozlowski
2016-03-14 19:48 ` Eduardo Valentin
2016-03-14 19:48 ` Eduardo Valentin
2016-03-14 19:48 ` [lm-sensors] " Eduardo Valentin
2016-03-10 9:16 ` Lukasz Majewski
2016-03-10 9:16 ` Lukasz Majewski
2016-03-10 9:16 ` [lm-sensors] " Lukasz Majewski
2016-03-09 21:35 ` [PATCH 12/13] thermal: convert tegra_thermal " Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] [PATCH 12/13] thermal: convert tegra_thermal to use devm_thermal_zone_of_sensor_registe Eduardo Valentin
[not found] ` <1457559336-17652-13-git-send-email-edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-10 8:46 ` [PATCH 12/13] thermal: convert tegra_thermal to use devm_thermal_zone_of_sensor_register Wei Ni
2016-03-10 8:46 ` Wei Ni
2016-03-10 8:46 ` [lm-sensors] [PATCH 12/13] thermal: convert tegra_thermal to use devm_thermal_zone_of_sensor_reg Wei Ni
2016-03-14 21:16 ` [PATCH 12/13] thermal: convert tegra_thermal to use devm_thermal_zone_of_sensor_register Eduardo Valentin
2016-03-14 21:16 ` [lm-sensors] [PATCH 12/13] thermal: convert tegra_thermal to use devm_thermal_zone_of_sensor_reg Eduardo Valentin
[not found] ` <20160314211607.GC4740-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2016-03-15 5:42 ` [PATCH 12/13] thermal: convert tegra_thermal to use devm_thermal_zone_of_sensor_register Wei Ni
2016-03-15 5:42 ` Wei Ni
2016-03-15 5:42 ` [lm-sensors] [PATCH 12/13] thermal: convert tegra_thermal to use devm_thermal_zone_of_sensor_reg Wei Ni
2016-03-09 21:35 ` [PATCH 13/13] hwmon: convert ti-thermal to use devm_thermal_zone_of_sensor_register Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-09 21:35 ` [PATCH 13/13] thermal: " Eduardo Valentin
2016-03-09 21:35 ` [lm-sensors] " Eduardo Valentin
2016-03-09 22:11 ` kbuild test robot
2016-03-09 22:11 ` kbuild test robot
2016-03-09 22:11 ` [lm-sensors] [PATCH 13/13] thermal: convert ti-thermal to use devm_thermal_zone_of_sensor_regist kbuild test robot
2016-03-15 12:26 ` Keerthy [this message]
2016-03-15 12:38 ` Keerthy
2016-03-15 12:26 ` [PATCH 13/13] thermal: convert ti-thermal to use devm_thermal_zone_of_sensor_register Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7FF8E.8030209@ti.com \
--to=a0393675@ti.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.