All of lore.kernel.org
 help / color / mirror / Atom feed
From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
Date: Tue, 15 Mar 2016 17:38:30 +0300	[thread overview]
Message-ID: <56E81E66.6080706@cogentembedded.com> (raw)
In-Reply-To: <1458034150-10766-1-git-send-email-abrodkin@synopsys.com>

Hello.

On 3/15/2016 12:29 PM, Alexey Brodkin wrote:

> Following commit broke DW GMAC functionality on AXS10x boards:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>
> That's what happens on eth0 up:
> --------------------------->8------------------------
> libphy: PHY stmmac-0:ffffffff not found
> eth0: Could not attach to PHY
> stmmac_open: Cannot attach to PHY (error: -19)
> --------------------------->8------------------------
>
> Simplest solution is to add PHY description in board's .dts.
> And so we do here.
>
> Signed-off-by: Alexey Brodkin <abrodkin at synopsys.com>
> Cc: Rob Herring <robh at kernel.org>
> Cc: Phil Reid <preid at electromag.com.au>
> Cc: David S. Miller <davem at davemloft.net>
> Cc: linux-kernel at vger.kernel.org
> Cc: netdev at vger.kernel.org
> Cc: stable at vger.kernel.org # 4.5.x
> ---
>   arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index 44a578c..04b999e 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -47,6 +47,14 @@
>   			clocks = <&apbclk>;
>   			clock-names = "stmmaceth";
>   			max-speed = <100>;
> +			mdio0 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "snps,dwmac-mdio";
> +				phy0: ethernet-phy at 0 {

    The naming is inconsistent with the "reg" prop specified, should be @1.

MBR, Sergei

WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
	linux-snps-arc@lists.infradead.org
Cc: Rob Herring <robh@kernel.org>,
	Phil Reid <preid@electromag.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	stable@vger.kernel.org, #@synopsys.com, 4.5.x@synopsys.com
Subject: Re: [PATCH] ARC: axs10x - add Ethernet PHY description in .dts
Date: Tue, 15 Mar 2016 17:38:30 +0300	[thread overview]
Message-ID: <56E81E66.6080706@cogentembedded.com> (raw)
In-Reply-To: <1458034150-10766-1-git-send-email-abrodkin@synopsys.com>

Hello.

On 3/15/2016 12:29 PM, Alexey Brodkin wrote:

> Following commit broke DW GMAC functionality on AXS10x boards:
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e34d65696d2ef13dc32f2a162556c86c461ed763
>
> That's what happens on eth0 up:
> --------------------------->8------------------------
> libphy: PHY stmmac-0:ffffffff not found
> eth0: Could not attach to PHY
> stmmac_open: Cannot attach to PHY (error: -19)
> --------------------------->8------------------------
>
> Simplest solution is to add PHY description in board's .dts.
> And so we do here.
>
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Phil Reid <preid@electromag.com.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: linux-kernel@vger.kernel.org
> Cc: netdev@vger.kernel.org
> Cc: stable@vger.kernel.org # 4.5.x
> ---
>   arch/arc/boot/dts/axs10x_mb.dtsi | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arc/boot/dts/axs10x_mb.dtsi b/arch/arc/boot/dts/axs10x_mb.dtsi
> index 44a578c..04b999e 100644
> --- a/arch/arc/boot/dts/axs10x_mb.dtsi
> +++ b/arch/arc/boot/dts/axs10x_mb.dtsi
> @@ -47,6 +47,14 @@
>   			clocks = <&apbclk>;
>   			clock-names = "stmmaceth";
>   			max-speed = <100>;
> +			mdio0 {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				compatible = "snps,dwmac-mdio";
> +				phy0: ethernet-phy@0 {

    The naming is inconsistent with the "reg" prop specified, should be @1.

MBR, Sergei

  reply	other threads:[~2016-03-15 14:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-15  9:29 [PATCH] ARC: axs10x - add Ethernet PHY description in .dts Alexey Brodkin
2016-03-15  9:29 ` Alexey Brodkin
2016-03-15 14:38 ` Sergei Shtylyov [this message]
2016-03-15 14:38   ` Sergei Shtylyov
2016-03-15 14:50   ` Alexey Brodkin
2016-03-15 14:50     ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E81E66.6080706@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=linux-snps-arc@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.