Re: [PATCH mesa 2/6] nouveau: codegen: Slightly refactor Source::scanInstruction() dst handling

[Samuel Pitoiset <samuel.pitoiset-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>

On 03/16/2016 10:23 AM, Hans de Goede wrote:
> Use the dst temp variable which was used in the TGSI_FILE_OUTPUT
> case everywhere. This makes the code somewhat easier to reads
> and helps avoiding going over 80 chars with upcoming changes.
>
> This also brings the dst handling more in line with the src
> handling.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> index 8a1a426..1e91ad3 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_from_tgsi.cpp
> @@ -1261,9 +1261,9 @@ bool Source::scanInstruction(const struct tgsi_full_instruction *inst)
>         info->numBarriers = 1;
>
>      if (insn.dstCount()) {
> -      if (insn.getDst(0).getFile() == TGSI_FILE_OUTPUT) {
> -         Instruction::DstRegister dst = insn.getDst(0);
> +      Instruction::DstRegister dst = insn.getDst(0);
>
> +      if (dst.getFile() == TGSI_FILE_OUTPUT) {
>            if (dst.isIndirect(0))
>               for (unsigned i = 0; i < info->numOutputs; ++i)
>                  info->out[i].mask = 0xf;
> @@ -1280,11 +1280,11 @@ bool Source::scanInstruction(const struct tgsi_full_instruction *inst)
>            if (isEdgeFlagPassthrough(insn))
>               info->io.edgeFlagIn = insn.getSrc(0).getIndex(0);
>         } else
> -      if (insn.getDst(0).getFile() == TGSI_FILE_TEMPORARY) {
> -         if (insn.getDst(0).isIndirect(0))
> -            indirectTempArrays.insert(insn.getDst(0).getArrayId());
> +      if (dst.getFile() == TGSI_FILE_TEMPORARY) {
> +         if (dst.isIndirect(0))
> +            indirectTempArrays.insert(dst.getArrayId());
>         } else
> -      if (insn.getDst(0).getFile() == TGSI_FILE_BUFFER) {
> +      if (dst.getFile() == TGSI_FILE_BUFFER) {
>            info->io.globalAccess |= 0x2;
>         }
>      }
>
_______________________________________________
Nouveau mailing list
Nouveau@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/nouveau