All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Pitoiset <samuel.pitoiset@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>, Ilia Mirkin <imirkin@alum.mit.edu>
Cc: mesa-dev@lists.freedesktop.org, nouveau@lists.freedesktop.org
Subject: Re: [PATCH mesa 3/6] nouveau: codegen: gk110: Make emitSTORE offset handling identical to emitLOAD
Date: Wed, 16 Mar 2016 11:28:16 +0100	[thread overview]
Message-ID: <56E93540.500@gmail.com> (raw)
In-Reply-To: <1458120239-27659-3-git-send-email-hdegoede@redhat.com>

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>

On 03/16/2016 10:23 AM, Hans de Goede wrote:
> Make the store offset handling in CodeEmitterGK110::emitSTORE identical
> to the one in CodeEmitterGK110::emitLOAD handling.
>
> This is just a cleanup, it does not cause any functional changes.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>   src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> index 0d7d95e..70f3c3f 100644
> --- a/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> +++ b/src/gallium/drivers/nouveau/codegen/nv50_ir_emit_gk110.cpp
> @@ -1655,10 +1655,8 @@ CodeEmitterGK110::emitSTORE(const Instruction *i)
>         break;
>      }
>
> -   if (i->src(0).getFile() != FILE_MEMORY_GLOBAL)
> -      offset &= 0xffffff;
> -
>      if (code[0] & 0x2) {
> +      offset &= 0xffffff;
>         emitLoadStoreType(i->dType, 0x33);
>         if (i->src(0).getFile() == FILE_MEMORY_LOCAL)
>            emitCachingMode(i->cache, 0x2f);
>
_______________________________________________
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/mesa-dev

  reply	other threads:[~2016-03-16 10:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16  9:23 [PATCH mesa 1/6] tgsi_build: Fix return of uninitialized memory in tgsi_*_instruction_memory Hans de Goede
     [not found] ` <1458120239-27659-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16  9:23   ` [PATCH mesa 2/6] nouveau: codegen: Slightly refactor Source::scanInstruction() dst handling Hans de Goede
     [not found]     ` <1458120239-27659-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16 10:24       ` Samuel Pitoiset
2016-03-16  9:23   ` [PATCH mesa 3/6] nouveau: codegen: gk110: Make emitSTORE offset handling identical to emitLOAD Hans de Goede
2016-03-16 10:28     ` Samuel Pitoiset [this message]
2016-03-16  9:23   ` [PATCH mesa 4/6] nouveau: codegen: s/FILE_MEMORY_GLOBAL/FILE_MEMORY_BUFFER/ Hans de Goede
2016-03-16 10:31     ` Samuel Pitoiset
     [not found]     ` <1458120239-27659-4-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16 14:55       ` Ilia Mirkin
     [not found]         ` <CAKb7Uvg=2MpmfYfeRi8NcYYzGkhZy7mDLFw0dFoeWd68Q6EgFA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-16 18:14           ` Hans de Goede
2016-03-16 18:24             ` Ilia Mirkin
2016-03-16  9:23   ` [PATCH mesa 5/6] nouveau: codegen: Add support for OpenCL global memory buffers Hans de Goede
2016-03-16 10:37     ` Samuel Pitoiset
2016-03-16 10:45       ` Hans de Goede
     [not found]         ` <56E9394D.8040704-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16 10:49           ` Samuel Pitoiset
2016-03-16  9:23   ` [PATCH mesa 6/6] nouveau: codegen: Disable more old resource handling code Hans de Goede
2016-03-16 10:45     ` Samuel Pitoiset
     [not found]       ` <56E9393A.2080300-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-03-16 10:49         ` Hans de Goede
     [not found]           ` <56E93A3E.1080808-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-03-16 12:20             ` Samuel Pitoiset
2016-03-16  9:52   ` [Mesa-dev] [PATCH mesa 1/6] tgsi_build: Fix return of uninitialized memory in tgsi_*_instruction_memory Marek Olšák
2016-03-16 15:12 ` Nicolai Hähnle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E93540.500@gmail.com \
    --to=samuel.pitoiset@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=imirkin@alum.mit.edu \
    --cc=mesa-dev@lists.freedesktop.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.