All of lore.kernel.org
 help / color / mirror / Atom feed
From: vbabka@suse.cz (Vlastimil Babka)
To: linux-arm-kernel@lists.infradead.org
Subject: Suspicious error for CMA stress test
Date: Wed, 16 Mar 2016 13:03:21 +0100	[thread overview]
Message-ID: <56E94B89.80706@suse.cz> (raw)
In-Reply-To: <CAAmzW4OKQHJ06Bi86jqVFGxqWsW7h_EWeGPAFB9K1aY754C4aQ@mail.gmail.com>

On 03/14/2016 03:10 PM, Joonsoo Kim wrote:
> 2016-03-14 21:30 GMT+09:00 Vlastimil Babka <vbabka@suse.cz>:
>
> Now I see why this happen. I enabled CONFIG_DEBUG_PAGEALLOC
> and it makes difference.
>
> I tested on x86_64, gcc (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4.
>
> With CONFIG_CMA + CONFIG_DEBUG_PAGEALLOC
> ./scripts/bloat-o-meter page_alloc_base.o page_alloc_vlastimil_orig.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 510/0 (510)
> function                                     old     new   delta
> free_one_page                               1050    1334    +284
> free_pcppages_bulk                          1396    1622    +226
>
> ./scripts/bloat-o-meter page_alloc_base.o page_alloc_mine.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 351/0 (351)
> function                                     old     new   delta
> free_one_page                               1050    1230    +180
> free_pcppages_bulk                          1396    1567    +171
>
>
> With CONFIG_CMA + !CONFIG_DEBUG_PAGEALLOC
> (pa_b is base, pa_v is yours and pa_m is mine)
>
> ./scripts/bloat-o-meter pa_b.o pa_v.o
> add/remove: 0/0 grow/shrink: 1/1 up/down: 88/-23 (65)
> function                                     old     new   delta
> free_one_page                                761     849     +88
> free_pcppages_bulk                          1117    1094     -23
>
> ./scripts/bloat-o-meter pa_b.o pa_m.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 329/0 (329)
> function                                     old     new   delta
> free_one_page                                761    1031    +270
> free_pcppages_bulk                          1117    1176     +59
>
> Still, it has difference but less than before.
> Maybe, we are still using different configuration. Could you
> check if CONFIG_DEBUG_VM is enabled or not? In my case, it's not

It's disabled here.

> enabled. And, do you think this bloat isn't acceptable?

Well, it is quite significant. But given that Hanjun sees the errors 
still, it's not the biggest issue now :/

> Thanks.
>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
	Laura Abbott <labbott@redhat.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	qiuxishi <qiuxishi@huawei.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	dingtinahong <dingtianhong@huawei.com>,
	chenjie6@huawei.com, "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: Suspicious error for CMA stress test
Date: Wed, 16 Mar 2016 13:03:21 +0100	[thread overview]
Message-ID: <56E94B89.80706@suse.cz> (raw)
In-Reply-To: <CAAmzW4OKQHJ06Bi86jqVFGxqWsW7h_EWeGPAFB9K1aY754C4aQ@mail.gmail.com>

On 03/14/2016 03:10 PM, Joonsoo Kim wrote:
> 2016-03-14 21:30 GMT+09:00 Vlastimil Babka <vbabka@suse.cz>:
>
> Now I see why this happen. I enabled CONFIG_DEBUG_PAGEALLOC
> and it makes difference.
>
> I tested on x86_64, gcc (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4.
>
> With CONFIG_CMA + CONFIG_DEBUG_PAGEALLOC
> ./scripts/bloat-o-meter page_alloc_base.o page_alloc_vlastimil_orig.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 510/0 (510)
> function                                     old     new   delta
> free_one_page                               1050    1334    +284
> free_pcppages_bulk                          1396    1622    +226
>
> ./scripts/bloat-o-meter page_alloc_base.o page_alloc_mine.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 351/0 (351)
> function                                     old     new   delta
> free_one_page                               1050    1230    +180
> free_pcppages_bulk                          1396    1567    +171
>
>
> With CONFIG_CMA + !CONFIG_DEBUG_PAGEALLOC
> (pa_b is base, pa_v is yours and pa_m is mine)
>
> ./scripts/bloat-o-meter pa_b.o pa_v.o
> add/remove: 0/0 grow/shrink: 1/1 up/down: 88/-23 (65)
> function                                     old     new   delta
> free_one_page                                761     849     +88
> free_pcppages_bulk                          1117    1094     -23
>
> ./scripts/bloat-o-meter pa_b.o pa_m.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 329/0 (329)
> function                                     old     new   delta
> free_one_page                                761    1031    +270
> free_pcppages_bulk                          1117    1176     +59
>
> Still, it has difference but less than before.
> Maybe, we are still using different configuration. Could you
> check if CONFIG_DEBUG_VM is enabled or not? In my case, it's not

It's disabled here.

> enabled. And, do you think this bloat isn't acceptable?

Well, it is quite significant. But given that Hanjun sees the errors 
still, it's not the biggest issue now :/

> Thanks.
>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Joonsoo Kim <js1304@gmail.com>
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	"Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>,
	Laura Abbott <labbott@redhat.com>,
	Hanjun Guo <guohanjun@huawei.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Sasha Levin <sasha.levin@oracle.com>,
	Laura Abbott <lauraa@codeaurora.org>,
	qiuxishi <qiuxishi@huawei.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>,
	dingtinahong <dingtianhong@huawei.com>,
	chenjie6@huawei.com, "linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: Suspicious error for CMA stress test
Date: Wed, 16 Mar 2016 13:03:21 +0100	[thread overview]
Message-ID: <56E94B89.80706@suse.cz> (raw)
In-Reply-To: <CAAmzW4OKQHJ06Bi86jqVFGxqWsW7h_EWeGPAFB9K1aY754C4aQ@mail.gmail.com>

On 03/14/2016 03:10 PM, Joonsoo Kim wrote:
> 2016-03-14 21:30 GMT+09:00 Vlastimil Babka <vbabka@suse.cz>:
>
> Now I see why this happen. I enabled CONFIG_DEBUG_PAGEALLOC
> and it makes difference.
>
> I tested on x86_64, gcc (Ubuntu 4.8.4-2ubuntu1~14.04.1) 4.8.4.
>
> With CONFIG_CMA + CONFIG_DEBUG_PAGEALLOC
> ./scripts/bloat-o-meter page_alloc_base.o page_alloc_vlastimil_orig.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 510/0 (510)
> function                                     old     new   delta
> free_one_page                               1050    1334    +284
> free_pcppages_bulk                          1396    1622    +226
>
> ./scripts/bloat-o-meter page_alloc_base.o page_alloc_mine.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 351/0 (351)
> function                                     old     new   delta
> free_one_page                               1050    1230    +180
> free_pcppages_bulk                          1396    1567    +171
>
>
> With CONFIG_CMA + !CONFIG_DEBUG_PAGEALLOC
> (pa_b is base, pa_v is yours and pa_m is mine)
>
> ./scripts/bloat-o-meter pa_b.o pa_v.o
> add/remove: 0/0 grow/shrink: 1/1 up/down: 88/-23 (65)
> function                                     old     new   delta
> free_one_page                                761     849     +88
> free_pcppages_bulk                          1117    1094     -23
>
> ./scripts/bloat-o-meter pa_b.o pa_m.o
> add/remove: 0/0 grow/shrink: 2/0 up/down: 329/0 (329)
> function                                     old     new   delta
> free_one_page                                761    1031    +270
> free_pcppages_bulk                          1117    1176     +59
>
> Still, it has difference but less than before.
> Maybe, we are still using different configuration. Could you
> check if CONFIG_DEBUG_VM is enabled or not? In my case, it's not

It's disabled here.

> enabled. And, do you think this bloat isn't acceptable?

Well, it is quite significant. But given that Hanjun sees the errors 
still, it's not the biggest issue now :/

> Thanks.
>

  reply	other threads:[~2016-03-16 12:03 UTC|newest]

Thread overview: 176+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-02 13:52 Suspicious error for CMA stress test Hanjun Guo
2016-03-02 13:52 ` Hanjun Guo
2016-03-03  1:25 ` Laura Abbott
2016-03-03  1:25   ` Laura Abbott
2016-03-03  1:25   ` Laura Abbott
2016-03-03  6:07   ` Hanjun Guo
2016-03-03  6:07     ` Hanjun Guo
2016-03-03  6:07     ` Hanjun Guo
2016-03-03  7:42   ` Joonsoo Kim
2016-03-03  7:42     ` Joonsoo Kim
2016-03-03  7:42     ` Joonsoo Kim
2016-03-03  7:58     ` Hanjun Guo
2016-03-03  7:58       ` Hanjun Guo
2016-03-03  7:58       ` Hanjun Guo
2016-03-03 12:49     ` Hanjun Guo
2016-03-03 12:49       ` Hanjun Guo
2016-03-03 12:49       ` Hanjun Guo
2016-03-03 18:52       ` Laura Abbott
2016-03-03 18:52         ` Laura Abbott
2016-03-03 18:52         ` Laura Abbott
2016-03-04  2:09         ` Joonsoo Kim
2016-03-04  2:09           ` Joonsoo Kim
2016-03-04  2:09           ` Joonsoo Kim
2016-03-04  6:09           ` Hanjun Guo
2016-03-04  6:09             ` Hanjun Guo
2016-03-04  6:09             ` Hanjun Guo
2016-03-04  2:02       ` Joonsoo Kim
2016-03-04  2:02         ` Joonsoo Kim
2016-03-04  2:02         ` Joonsoo Kim
2016-03-04  4:32         ` Joonsoo Kim
2016-03-04  4:32           ` Joonsoo Kim
2016-03-04  4:32           ` Joonsoo Kim
2016-03-04  6:05           ` Hanjun Guo
2016-03-04  6:05             ` Hanjun Guo
2016-03-04  6:05             ` Hanjun Guo
2016-03-04  6:38             ` Joonsoo Kim
2016-03-04  6:38               ` Joonsoo Kim
2016-03-04  6:38               ` Joonsoo Kim
2016-03-04  7:35               ` Hanjun Guo
2016-03-04  7:35                 ` Hanjun Guo
2016-03-04  7:35                 ` Hanjun Guo
2016-03-07  4:34                 ` Joonsoo Kim
2016-03-07  4:34                   ` Joonsoo Kim
2016-03-07  4:34                   ` Joonsoo Kim
2016-03-07  8:16                   ` Leizhen (ThunderTown)
2016-03-07  8:16                     ` Leizhen (ThunderTown)
2016-03-07  8:16                     ` Leizhen (ThunderTown)
2016-03-07 18:42                     ` Laura Abbott
2016-03-07 18:42                       ` Laura Abbott
2016-03-07 18:42                       ` Laura Abbott
2016-03-08  1:54                       ` Leizhen (ThunderTown)
2016-03-08  1:54                         ` Leizhen (ThunderTown)
2016-03-08  1:54                         ` Leizhen (ThunderTown)
2016-03-09  1:23                         ` Leizhen (ThunderTown)
2016-03-09  1:23                           ` Leizhen (ThunderTown)
2016-03-09  1:23                           ` Leizhen (ThunderTown)
2016-03-11 15:00                           ` Joonsoo Kim
2016-03-11 15:00                             ` Joonsoo Kim
2016-03-11 15:00                             ` Joonsoo Kim
2016-03-11 17:07                             ` Vlastimil Babka
2016-03-11 17:07                               ` Vlastimil Babka
2016-03-11 17:07                               ` Vlastimil Babka
2016-03-14  6:49                               ` Joonsoo Kim
2016-03-14  6:49                                 ` Joonsoo Kim
2016-03-14  6:49                                 ` Joonsoo Kim
2016-03-14  7:06                                 ` Vlastimil Babka
2016-03-14  7:06                                   ` Vlastimil Babka
2016-03-14  7:06                                   ` Vlastimil Babka
2016-03-14  7:18                                   ` Joonsoo Kim
2016-03-14  7:18                                     ` Joonsoo Kim
2016-03-14  7:18                                     ` Joonsoo Kim
2016-03-14 12:30                                     ` Vlastimil Babka
2016-03-14 12:30                                       ` Vlastimil Babka
2016-03-14 12:30                                       ` Vlastimil Babka
2016-03-14 14:10                                       ` Joonsoo Kim
2016-03-14 14:10                                         ` Joonsoo Kim
2016-03-14 14:10                                         ` Joonsoo Kim
2016-03-16 12:03                                         ` Vlastimil Babka [this message]
2016-03-16 12:03                                           ` Vlastimil Babka
2016-03-16 12:03                                           ` Vlastimil Babka
2016-03-16  9:44                                     ` Hanjun Guo
2016-03-16  9:44                                       ` Hanjun Guo
2016-03-16  9:44                                       ` Hanjun Guo
2016-03-17  6:54                                       ` Joonsoo Kim
2016-03-17  6:54                                         ` Joonsoo Kim
2016-03-17  6:54                                         ` Joonsoo Kim
2016-03-17  9:24                                         ` Hanjun Guo
2016-03-17  9:24                                           ` Hanjun Guo
2016-03-17  9:24                                           ` Hanjun Guo
2016-03-17 15:31                                           ` Joonsoo Kim
2016-03-17 15:31                                             ` Joonsoo Kim
2016-03-17 15:31                                             ` Joonsoo Kim
2016-03-18  2:03                                             ` Hanjun Guo
2016-03-18  2:03                                               ` Hanjun Guo
2016-03-18  2:03                                               ` Hanjun Guo
2016-03-17 15:43                                           ` Vlastimil Babka
2016-03-17 15:43                                             ` Vlastimil Babka
2016-03-17 15:43                                             ` Vlastimil Babka
2016-03-17 15:52                                             ` Joonsoo Kim
2016-03-17 15:52                                               ` Joonsoo Kim
2016-03-17 15:52                                               ` Joonsoo Kim
2016-03-18 13:32                                               ` Lucas Stach
2016-03-18 13:32                                                 ` Lucas Stach
2016-03-18 13:32                                                 ` Lucas Stach
2016-03-21  4:42                                                 ` Joonsoo Kim
2016-03-21  4:42                                                   ` Joonsoo Kim
2016-03-21  4:42                                                   ` Joonsoo Kim
2016-03-22 14:56                                                   ` Lucas Stach
2016-03-22 14:56                                                     ` Lucas Stach
2016-03-22 14:56                                                     ` Lucas Stach
2016-03-23  4:42                                                     ` Joonsoo Kim
2016-03-23  4:42                                                       ` Joonsoo Kim
2016-03-23  4:42                                                       ` Joonsoo Kim
2016-03-18 14:10                                               ` Vlastimil Babka
2016-03-18 14:10                                                 ` Vlastimil Babka
2016-03-18 14:10                                                 ` Vlastimil Babka
2016-03-18 14:42                                                 ` Lucas Stach
2016-03-18 14:42                                                   ` Lucas Stach
2016-03-18 14:42                                                   ` Lucas Stach
2016-03-18 20:58                                                   ` Vlastimil Babka
2016-03-18 20:58                                                     ` Vlastimil Babka
2016-03-18 20:58                                                     ` Vlastimil Babka
2016-03-22 14:47                                                     ` Lucas Stach
2016-03-22 14:47                                                       ` Lucas Stach
2016-03-22 14:47                                                       ` Lucas Stach
2016-03-19  7:24                                                 ` Hanjun Guo
2016-03-19  7:24                                                   ` Hanjun Guo
2016-03-19  7:24                                                   ` Hanjun Guo
2016-03-19 22:11                                                   ` Vlastimil Babka
2016-03-19 22:11                                                     ` Vlastimil Babka
2016-03-19 22:11                                                     ` Vlastimil Babka
2016-03-23  4:44                                                 ` Joonsoo Kim
2016-03-23  4:44                                                   ` Joonsoo Kim
2016-03-23  4:44                                                   ` Joonsoo Kim
2016-03-23  8:26                                                   ` Vlastimil Babka
2016-03-23  8:26                                                     ` Vlastimil Babka
2016-03-23  8:26                                                     ` Vlastimil Babka
2016-03-23  8:32                                                     ` Joonsoo Kim
2016-03-23  8:32                                                       ` Joonsoo Kim
2016-03-23  8:32                                                       ` Joonsoo Kim
2016-03-18 12:29                                         ` Vlastimil Babka
2016-03-18 12:29                                           ` Vlastimil Babka
2016-03-18 12:29                                           ` Vlastimil Babka
2016-03-08  4:03                     ` Hanjun Guo
2016-03-08  4:03                       ` Hanjun Guo
2016-03-08  4:03                       ` Hanjun Guo
2016-03-07 12:59                   ` Vlastimil Babka
2016-03-07 12:59                     ` Vlastimil Babka
2016-03-07 12:59                     ` Vlastimil Babka
2016-03-08  7:48                     ` Joonsoo Kim
2016-03-08  7:48                       ` Joonsoo Kim
2016-03-08  7:48                       ` Joonsoo Kim
2016-03-08 10:45                       ` Xishi Qiu
2016-03-08 10:45                         ` Xishi Qiu
2016-03-08 10:45                         ` Xishi Qiu
2016-03-08 15:36                         ` Joonsoo Kim
2016-03-08 15:36                           ` Joonsoo Kim
2016-03-08 15:36                           ` Joonsoo Kim
2016-03-09  2:18                           ` Xishi Qiu
2016-03-09  2:18                             ` Xishi Qiu
2016-03-09  2:18                             ` Xishi Qiu
2016-03-04  5:33         ` Hanjun Guo
2016-03-04  5:33           ` Hanjun Guo
2016-03-04  5:33           ` Hanjun Guo
2016-03-08  1:42           ` Xishi Qiu
2016-03-08  1:42             ` Xishi Qiu
2016-03-08  1:42             ` Xishi Qiu
2016-03-08  8:09             ` Joonsoo Kim
2016-03-08  8:09               ` Joonsoo Kim
2016-03-08  8:09               ` Joonsoo Kim
2016-03-04  6:59         ` Hanjun Guo
2016-03-04  6:59           ` Hanjun Guo
2016-03-04  6:59           ` Hanjun Guo
2016-03-07  4:40           ` Joonsoo Kim
2016-03-07  4:40             ` Joonsoo Kim
2016-03-07  4:40             ` Joonsoo Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E94B89.80706@suse.cz \
    --to=vbabka@suse.cz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.