From: Sergei Shtylyov <sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>
To: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
leozwang-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 2/9] net: arc_emac: add phy reset is optional for device tree
Date: Wed, 16 Mar 2016 16:57:42 +0300 [thread overview]
Message-ID: <56E96656.5000101@cogentembedded.com> (raw)
In-Reply-To: <1457942520-12859-3-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Hello.
On 3/14/2016 11:01 AM, Caesar Wang wrote:
> This patch adds the following property for arc_emac.
>
> 1) phy-reset-gpios:
> The phy-reset-gpio is an optional property for arc emac device tree boot.
> Change the binding document to match the driver code.
>
> 2) phy-reset-duration:
> Different boards may require different phy reset duration. Add property
> phy-reset-duration for device tree probe, so that the boards that need
> a longer reset duration can specify it in their device tree.
>
> Anyway, we can add the above property for arc emac.
>
> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Could you have a look at drivers/net/ethernet/cadence/macb/? It seems to be
the only driver which places the PHY's "reset-gpios" prop correctly, into the
PHY subnode? I'm currently working on adding support of this prop into phylib...
MBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Caesar Wang <wxt@rock-chips.com>,
Heiko Stuebner <heiko@sntech.de>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-rockchip@lists.infradead.org, keescook@google.com,
leozwang@google.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/9] net: arc_emac: add phy reset is optional for device tree
Date: Wed, 16 Mar 2016 16:57:42 +0300 [thread overview]
Message-ID: <56E96656.5000101@cogentembedded.com> (raw)
In-Reply-To: <1457942520-12859-3-git-send-email-wxt@rock-chips.com>
Hello.
On 3/14/2016 11:01 AM, Caesar Wang wrote:
> This patch adds the following property for arc_emac.
>
> 1) phy-reset-gpios:
> The phy-reset-gpio is an optional property for arc emac device tree boot.
> Change the binding document to match the driver code.
>
> 2) phy-reset-duration:
> Different boards may require different phy reset duration. Add property
> phy-reset-duration for device tree probe, so that the boards that need
> a longer reset duration can specify it in their device tree.
>
> Anyway, we can add the above property for arc emac.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Could you have a look at drivers/net/ethernet/cadence/macb/? It seems to be
the only driver which places the PHY's "reset-gpios" prop correctly, into the
PHY subnode? I'm currently working on adding support of this prop into phylib...
MBR, Sergei
next prev parent reply other threads:[~2016-03-16 13:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 8:01 [PATCH v3 0/9] arc_emac: fixes the emac issues and cleanup emac drivers Caesar Wang
2016-03-14 8:01 ` Caesar Wang
[not found] ` <1457942520-12859-1-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-03-14 8:01 ` [PATCH v3 1/9] net: arc_emac: make the rockchip emac document more compatible Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-14 8:01 ` Caesar Wang
[not found] ` <1457942520-12859-2-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-03-18 20:22 ` Rob Herring
2016-03-18 20:22 ` Rob Herring
2016-03-18 20:22 ` Rob Herring
2016-03-14 8:01 ` [PATCH v3 2/9] net: arc_emac: add phy reset is optional for device tree Caesar Wang
2016-03-14 8:01 ` Caesar Wang
[not found] ` <1457942520-12859-3-git-send-email-wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-03-16 13:57 ` Sergei Shtylyov [this message]
2016-03-16 13:57 ` Sergei Shtylyov
2016-03-17 10:02 ` Caesar Wang
2016-03-14 8:01 ` [PATCH v3 3/9] net: arc_emac: support the phy reset for emac driver Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-14 8:02 ` [PATCH v3 9/9] ARM: dts: rockchip: add to support emac for rk3036 SoCs Caesar Wang
2016-03-14 8:02 ` Caesar Wang
2016-03-14 8:02 ` Caesar Wang
2016-03-14 8:01 ` [PATCH v3 4/9] net: arc: trivial: cleanup the emac driver Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-14 8:01 ` [PATCH v3 5/9] clk: rockchip: add node-id for rk3036 emac hclk Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-14 8:01 ` [PATCH v3 6/9] clk: rockchip: associate the rk3036 HCLK_EMAC clock-id Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-14 8:01 ` [PATCH v3 7/9] clk: rockchip: add clock-id for rk3036 emac pll source clock Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-14 8:01 ` [PATCH v3 8/9] clk: rockchip: associate SCLK_MAC_PLL and disable reparenting on rk3036 Caesar Wang
2016-03-14 8:01 ` Caesar Wang
2016-03-16 23:28 ` [PATCH v3 0/9] arc_emac: fixes the emac issues and cleanup emac drivers David Miller
2016-03-16 23:28 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E96656.5000101@cogentembedded.com \
--to=sergei.shtylyov-m4dtvfq/zs1mrggop+s0pdbpr1lh4cv8@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=keescook-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=leozwang-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.