From: Martin Kepplinger <martink@posteo.de>
To: Jens Axboe <axboe@fb.com>,
ulf.hansson@linaro.org, chuanxiao.dong@intel.com, fabf@skynet.be
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: card: don't use PF_MEMALLOC
Date: Wed, 16 Mar 2016 16:07:21 +0100 [thread overview]
Message-ID: <56E976A9.40906@posteo.de> (raw)
In-Reply-To: <56E9707D.5070004@fb.com>
Am 2016-03-16 um 15:41 schrieb Jens Axboe:
> On 03/16/2016 04:43 AM, Martin Kepplinger wrote:
>> PF_MEMALLOC is assigned to processes by mm. If drivers prevent memory
>> reclaim and mm is not in control, strange hang-up or OOM Killer
>> invocation
>> could happen.
>>
>> Signed-off-by: Martin Kepplinger <martink@posteo.de>
>> ---
>> I use MMC cards with this change perfectly fine. As I understand it,
>> even *if* PF_MEMALLOC has a real reason to be here, I think it should
>> be very well documented.
>
> Did you try swap on mmcblk?
>
No I haven't even thought about that :) If you know it can be necessary
in that case, it's obviously fine. A comment would still be good though.
next prev parent reply other threads:[~2016-03-16 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 11:43 [PATCH] mmc: card: don't use PF_MEMALLOC Martin Kepplinger
2016-03-16 14:41 ` Jens Axboe
2016-03-16 14:41 ` Jens Axboe
2016-03-16 15:07 ` Martin Kepplinger [this message]
2016-03-16 15:12 ` Jens Axboe
2016-03-16 15:12 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E976A9.40906@posteo.de \
--to=martink@posteo.de \
--cc=axboe@fb.com \
--cc=chuanxiao.dong@intel.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.