All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Martin Kepplinger <martink@posteo.de>,
	ulf.hansson@linaro.org, chuanxiao.dong@intel.com, fabf@skynet.be
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: card: don't use PF_MEMALLOC
Date: Wed, 16 Mar 2016 07:41:01 -0700	[thread overview]
Message-ID: <56E9707D.5070004@fb.com> (raw)
In-Reply-To: <1458128635-3539-1-git-send-email-martink@posteo.de>

On 03/16/2016 04:43 AM, Martin Kepplinger wrote:
> PF_MEMALLOC is assigned to processes by mm. If drivers prevent memory
> reclaim and mm is not in control, strange hang-up or OOM Killer invocation
> could happen.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> I use MMC cards with this change perfectly fine. As I understand it,
> even *if* PF_MEMALLOC has a real reason to be here, I think it should
> be very well documented.

Did you try swap on mmcblk?

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@fb.com>
To: Martin Kepplinger <martink@posteo.de>, <ulf.hansson@linaro.org>,
	<chuanxiao.dong@intel.com>, <fabf@skynet.be>
Cc: <linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: card: don't use PF_MEMALLOC
Date: Wed, 16 Mar 2016 07:41:01 -0700	[thread overview]
Message-ID: <56E9707D.5070004@fb.com> (raw)
In-Reply-To: <1458128635-3539-1-git-send-email-martink@posteo.de>

On 03/16/2016 04:43 AM, Martin Kepplinger wrote:
> PF_MEMALLOC is assigned to processes by mm. If drivers prevent memory
> reclaim and mm is not in control, strange hang-up or OOM Killer invocation
> could happen.
>
> Signed-off-by: Martin Kepplinger <martink@posteo.de>
> ---
> I use MMC cards with this change perfectly fine. As I understand it,
> even *if* PF_MEMALLOC has a real reason to be here, I think it should
> be very well documented.

Did you try swap on mmcblk?

-- 
Jens Axboe

  reply	other threads:[~2016-03-16 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 11:43 [PATCH] mmc: card: don't use PF_MEMALLOC Martin Kepplinger
2016-03-16 14:41 ` Jens Axboe [this message]
2016-03-16 14:41   ` Jens Axboe
2016-03-16 15:07   ` Martin Kepplinger
2016-03-16 15:12     ` Jens Axboe
2016-03-16 15:12       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E9707D.5070004@fb.com \
    --to=axboe@fb.com \
    --cc=chuanxiao.dong@intel.com \
    --cc=fabf@skynet.be \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=martink@posteo.de \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.