From: Thomas Huth <thuth@redhat.com>
To: "Cédric Le Goater" <clg@fr.ibm.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR
Date: Wed, 16 Mar 2016 18:43:51 +0100 [thread overview]
Message-ID: <56E99B57.2070305@redhat.com> (raw)
In-Reply-To: <1458134034-32500-8-git-send-email-clg@fr.ibm.com>
On 16.03.2016 14:13, Cédric Le Goater wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> The masks weren't chosen nor applied properly. The architecture specifies
> that writes to AMR are masked by UAMOR for PR=1, otherwise AMOR for HV=0.
>
> The writes to UAMOR are masked by AMOR for HV=0
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> [clg: moved gen_spr_amr() prototype change to next patch ]
> Signed-off-by: Cédric Le Goater <clg@fr.ibm.com>
> ---
> target-ppc/translate_init.c | 74 ++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 59 insertions(+), 15 deletions(-)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2016-03-16 17:44 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 13:13 [Qemu-devel] [PATCH v2 00/10] ppc: preparing pnv landing Cédric Le Goater
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 01/10] ppc: Update SPR definitions Cédric Le Goater
2016-03-21 1:00 ` David Gibson
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 02/10] ppc: Add macros to register hypervisor mode SPRs Cédric Le Goater
2016-03-16 17:26 ` Thomas Huth
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 03/10] ppc: Add a bunch of hypervisor SPRs to Book3s Cédric Le Goater
2016-03-16 17:28 ` Thomas Huth
2016-03-21 1:00 ` David Gibson
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 04/10] ppc: Create cpu_ppc_set_papr() helper Cédric Le Goater
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 05/10] ppc: Add dummy SPR_IC for POWER8 Cédric Le Goater
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 06/10] ppc: Initialize AMOR in PAPR mode Cédric Le Goater
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 07/10] ppc: Fix writing to AMR/UAMOR Cédric Le Goater
2016-03-16 17:43 ` Thomas Huth [this message]
2016-03-21 3:06 ` David Gibson
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 08/10] ppc: Add POWER8 IAMR register Cédric Le Goater
2016-03-16 17:46 ` Thomas Huth
2016-03-16 17:49 ` Cédric Le Goater
2016-03-16 17:57 ` [Qemu-devel] [PATCH v3 " Cédric Le Goater
2016-03-16 19:54 ` Thomas Huth
2016-03-21 3:08 ` David Gibson
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 09/10] ppc: Add dummy CIABR SPR Cédric Le Goater
2016-03-16 13:13 ` [Qemu-devel] [PATCH v2 10/10] ppc: A couple more dummy POWER8 Book4 regs Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E99B57.2070305@redhat.com \
--to=thuth@redhat.com \
--cc=clg@fr.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.