From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-arm] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0
Date: Wed, 16 Mar 2016 21:34:15 +0300 [thread overview]
Message-ID: <56E9A727.7080807@gmail.com> (raw)
In-Reply-To: <CAPokK=reD-sN1525osBbcxjFDzyJKvaoEf69C7wb6oHco4N=Lw@mail.gmail.com>
09.03.2016 00:08, Peter Crosthwaite пишет:
> On Sat, Jan 30, 2016 at 8:43 AM, Dmitry Osipenko <digetx@gmail.com> wrote:
>> It might be necessary by some emulated HW to perform the tick after one
>> period if delta = 0. Given that it is much less churny to implement immediate
>> tick by the ptimer user itself, let's make ptimer do the delayed tick.
>>
>
> Isn't this related to previous patch? It is kind of a rounding problem
Ah, you probably meant "Legalize running with delta = load = 0 and abort on
period = 0" patch. Yes, they could be squashed.
I chose wrong policy at first time, further added MPtimer tests revealed it.
--
Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
qemu-arm <qemu-arm@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0
Date: Wed, 16 Mar 2016 21:34:15 +0300 [thread overview]
Message-ID: <56E9A727.7080807@gmail.com> (raw)
In-Reply-To: <CAPokK=reD-sN1525osBbcxjFDzyJKvaoEf69C7wb6oHco4N=Lw@mail.gmail.com>
09.03.2016 00:08, Peter Crosthwaite пишет:
> On Sat, Jan 30, 2016 at 8:43 AM, Dmitry Osipenko <digetx@gmail.com> wrote:
>> It might be necessary by some emulated HW to perform the tick after one
>> period if delta = 0. Given that it is much less churny to implement immediate
>> tick by the ptimer user itself, let's make ptimer do the delayed tick.
>>
>
> Isn't this related to previous patch? It is kind of a rounding problem
Ah, you probably meant "Legalize running with delta = load = 0 and abort on
period = 0" patch. Yes, they could be squashed.
I chose wrong policy at first time, further added MPtimer tests revealed it.
--
Dmitry
next prev parent reply other threads:[~2016-03-16 18:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-30 16:43 [Qemu-devel] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 1/9] hw/ptimer: Fix issues caused by the adjusted timer limit value Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-arm] [PATCH v12 2/9] hw/ptimer: Perform counter wrap around if timer already expired Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] " Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-arm] [PATCH v12 3/9] hw/ptimer: Update .delta on period/freq change Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] " Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-arm] [PATCH v12 4/9] hw/ptimer: Support "on the fly" timer mode switch Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] " Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 5/9] hw/ptimer: Introduce ptimer_get_limit Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 6/9] hw/ptimer: Legalize running with delta = load = 0 and abort on period = 0 Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-arm] [PATCH v12 7/9] hw/ptimer: Fix counter - 1 returned by ptimer_get_count for the active timer Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] " Dmitry Osipenko
2016-02-02 15:19 ` [Qemu-arm] " Dmitry Osipenko
2016-02-02 15:19 ` [Qemu-devel] " Dmitry Osipenko
2016-02-02 15:24 ` [Qemu-arm] " Dmitry Osipenko
2016-02-02 15:24 ` [Qemu-devel] " Dmitry Osipenko
2016-03-08 3:43 ` [Qemu-arm] " Peter Crosthwaite
2016-03-08 3:43 ` [Qemu-devel] " Peter Crosthwaite
2016-03-08 19:11 ` [Qemu-arm] " Dmitry Osipenko
2016-03-08 19:11 ` [Qemu-devel] " Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 8/9] hw/ptimer: Perform delayed tick instead of immediate if delta = 0 Dmitry Osipenko
2016-03-08 21:08 ` [Qemu-arm] " Peter Crosthwaite
2016-03-08 21:08 ` [Qemu-devel] " Peter Crosthwaite
2016-03-09 19:56 ` [Qemu-arm] " Dmitry Osipenko
2016-03-09 19:56 ` [Qemu-devel] " Dmitry Osipenko
2016-03-16 18:34 ` Dmitry Osipenko [this message]
2016-03-16 18:34 ` Dmitry Osipenko
2016-01-30 16:43 ` [Qemu-devel] [PATCH v12 9/9] arm_mptimer: Convert to use ptimer Dmitry Osipenko
2016-03-08 21:03 ` [Qemu-arm] " Peter Crosthwaite
2016-03-08 21:03 ` [Qemu-devel] " Peter Crosthwaite
2016-03-16 14:36 ` [Qemu-arm] [PATCH v12 0/9] PTimer fixes/features and ARM MPTimer conversion Peter Maydell
2016-03-16 14:36 ` [Qemu-devel] " Peter Maydell
2016-03-16 15:33 ` [Qemu-arm] " Dmitry Osipenko
2016-03-16 15:33 ` [Qemu-devel] " Dmitry Osipenko
2016-03-28 13:22 ` [Qemu-arm] " Dmitry Osipenko
2016-03-28 13:22 ` [Qemu-devel] " Dmitry Osipenko
2016-03-29 19:00 ` [Qemu-arm] " Peter Maydell
2016-03-29 19:00 ` Peter Maydell
2016-03-29 20:17 ` Dmitry Osipenko
2016-05-24 16:20 ` [Qemu-arm] " Peter Maydell
2016-05-24 16:20 ` Peter Maydell
2016-05-24 17:15 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E9A727.7080807@gmail.com \
--to=digetx@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.