Re: [PATCH] tpm: fix tpm_bios_log_setup stub prototype

[Stefan Berger <stefanb-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>]

On 03/16/2016 01:57 PM, Jason Gunthorpe wrote:
> On Wed, Mar 16, 2016 at 12:13:41PM +0200, Jarkko Sakkinen wrote:
>> On Wed, Mar 16, 2016 at 09:19:48AM +0100, Arnd Bergmann wrote:
>>> A cleanup patch changed the prototype of the regular tpm_bios_log_setup
>>> function, but not that of the stub that is used when the TPM is disabled,
>>> causing a harmless build warning:
>>>
>>> drivers/char/tpm/tpm-chip.c: In function 'tpm1_chip_register':
>>> drivers/char/tpm/tpm-chip.c:287:38: error: passing argument 1 of 'tpm_bios_log_setup' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
>>>    chip->bios_dir = tpm_bios_log_setup(dev_name(&chip->dev));
>>> In file included from ../drivers/char/tpm/tpm-chip.c:30:0:
>>> ../drivers/char/tpm/tpm_eventlog.h:83:31: note: expected 'char *' but argument is of type 'const char *'
>>>   static inline struct dentry **tpm_bios_log_setup(char *name)
>>>
>>> This changes the stub function to match the normal prototype,
>>> avoiding that warning.
>> Good catch. Thank you.
> The weird thing is I already applied this hunk to the patch, an
> autobuilder found it, it is right in my personal tree..
>
> Unclear where it got dropped? Are we missing anything else in that
> series? Stephen?

If I lost it, I certainly did not drop it intentionately.

    Stefan


------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140