All of lore.kernel.org
 help / color / mirror / Atom feed
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 2/2] mailbox: Introduce TI message manager driver
Date: Wed, 16 Mar 2016 19:29:49 -0500	[thread overview]
Message-ID: <56E9FA7D.9050801@ti.com> (raw)
In-Reply-To: <CABb+yY1S52aK63coeNuiH+Ca8GERq=ukCPFidcitUEMhHVdsyg@mail.gmail.com>

Hi Jassi,

On 03/16/2016 12:16 AM, Jassi Brar wrote:

[...]
>> Alright, i will drop this check since it is causing a lot more
>> confusion
>>
> It's confusing because you check ti_msgmgr_queue_get_num_messages()
> also in ti_msgmgr_last_tx_done() which doesn't make sense because the
> former accounts for messages from other senders also (as you say there
> could be multiple senders).


True -> I will drop it for now. I will see if the case I was trying to
protect is actually possible to be hit in the first place. And if proven
to be required, I will introduce it back with a better explanation and
the usecase where this is needed.

>> that that is worth. we can introduce it when we finally do
>> hit an issue eventually with multiple processors trying to transmit on
>> the same queue manager. that is not a concern at the very immediate
>> time, so we should be good to drop.
>>
>> please let me know if you are ok with this.
>>
> I am ok with whatever you assert is needed for your platform. I just
> point out what I think are inconsistencies in your assumptions. I'll
> pick the next revision however it is.


Thanks for your patience and guidance with this series. I have tried to
incorporate all the alignment we have had on this thread as part of
V3[1] of the series.


[1] http://marc.info/?l=linux-arm-kernel&m=145817434531691&w=2

-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm-l0cyMroinI0@public.gmane.org>
To: Jassi Brar <jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Devicetree List
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Linux Kernel Mailing List
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
	Santosh Shilimkar
	<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Franklin S Cooper Jr <fcooper-l0cyMroinI0@public.gmane.org>
Subject: Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver
Date: Wed, 16 Mar 2016 19:29:49 -0500	[thread overview]
Message-ID: <56E9FA7D.9050801@ti.com> (raw)
In-Reply-To: <CABb+yY1S52aK63coeNuiH+Ca8GERq=ukCPFidcitUEMhHVdsyg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi Jassi,

On 03/16/2016 12:16 AM, Jassi Brar wrote:

[...]
>> Alright, i will drop this check since it is causing a lot more
>> confusion
>>
> It's confusing because you check ti_msgmgr_queue_get_num_messages()
> also in ti_msgmgr_last_tx_done() which doesn't make sense because the
> former accounts for messages from other senders also (as you say there
> could be multiple senders).


True -> I will drop it for now. I will see if the case I was trying to
protect is actually possible to be hit in the first place. And if proven
to be required, I will introduce it back with a better explanation and
the usecase where this is needed.

>> that that is worth. we can introduce it when we finally do
>> hit an issue eventually with multiple processors trying to transmit on
>> the same queue manager. that is not a concern at the very immediate
>> time, so we should be good to drop.
>>
>> please let me know if you are ok with this.
>>
> I am ok with whatever you assert is needed for your platform. I just
> point out what I think are inconsistencies in your assumptions. I'll
> pick the next revision however it is.


Thanks for your patience and guidance with this series. I have tried to
incorporate all the alignment we have had on this thread as part of
V3[1] of the series.


[1] http://marc.info/?l=linux-arm-kernel&m=145817434531691&w=2

-- 
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: Devicetree List <devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	Franklin S Cooper Jr <fcooper@ti.com>
Subject: Re: [PATCH V2 2/2] mailbox: Introduce TI message manager driver
Date: Wed, 16 Mar 2016 19:29:49 -0500	[thread overview]
Message-ID: <56E9FA7D.9050801@ti.com> (raw)
In-Reply-To: <CABb+yY1S52aK63coeNuiH+Ca8GERq=ukCPFidcitUEMhHVdsyg@mail.gmail.com>

Hi Jassi,

On 03/16/2016 12:16 AM, Jassi Brar wrote:

[...]
>> Alright, i will drop this check since it is causing a lot more
>> confusion
>>
> It's confusing because you check ti_msgmgr_queue_get_num_messages()
> also in ti_msgmgr_last_tx_done() which doesn't make sense because the
> former accounts for messages from other senders also (as you say there
> could be multiple senders).


True -> I will drop it for now. I will see if the case I was trying to
protect is actually possible to be hit in the first place. And if proven
to be required, I will introduce it back with a better explanation and
the usecase where this is needed.

>> that that is worth. we can introduce it when we finally do
>> hit an issue eventually with multiple processors trying to transmit on
>> the same queue manager. that is not a concern at the very immediate
>> time, so we should be good to drop.
>>
>> please let me know if you are ok with this.
>>
> I am ok with whatever you assert is needed for your platform. I just
> point out what I think are inconsistencies in your assumptions. I'll
> pick the next revision however it is.


Thanks for your patience and guidance with this series. I have tried to
incorporate all the alignment we have had on this thread as part of
V3[1] of the series.


[1] http://marc.info/?l=linux-arm-kernel&m=145817434531691&w=2

-- 
Regards,
Nishanth Menon

  reply	other threads:[~2016-03-17  0:29 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-26 22:24 [PATCH V2 0/2] mailbox: Introduce Texas Instrument's message manager driver Nishanth Menon
2016-02-26 22:24 ` Nishanth Menon
2016-02-26 22:24 ` Nishanth Menon
2016-02-26 22:24 ` [PATCH V2 1/2] Documentation: dt: mailbox: Add TI Message Manager Nishanth Menon
2016-02-26 22:24   ` Nishanth Menon
2016-02-26 22:24   ` Nishanth Menon
2016-03-03 21:09   ` Rob Herring
2016-03-03 21:09     ` Rob Herring
2016-03-03 21:09     ` Rob Herring
2016-02-26 22:24 ` [PATCH V2 2/2] mailbox: Introduce TI message manager driver Nishanth Menon
2016-02-26 22:24   ` Nishanth Menon
2016-02-26 22:24   ` Nishanth Menon
2016-03-04  5:18   ` Jassi Brar
2016-03-04  5:18     ` Jassi Brar
2016-03-04 13:05     ` Nishanth Menon
2016-03-04 13:05       ` Nishanth Menon
2016-03-07 18:31       ` Jassi Brar
2016-03-07 18:31         ` Jassi Brar
2016-03-07 18:31         ` Jassi Brar
2016-03-07 19:18         ` Nishanth Menon
2016-03-07 19:18           ` Nishanth Menon
2016-03-08  7:10           ` Jassi Brar
2016-03-08  7:10             ` Jassi Brar
2016-03-08  7:10             ` Jassi Brar
2016-03-08 14:37             ` Nishanth Menon
2016-03-08 14:37               ` Nishanth Menon
2016-03-08 14:37               ` Nishanth Menon
2016-03-15  5:31               ` Jassi Brar
2016-03-15  5:31                 ` Jassi Brar
2016-03-15  5:31                 ` Jassi Brar
2016-03-15 17:05                 ` Nishanth Menon
2016-03-15 17:05                   ` Nishanth Menon
2016-03-15 17:05                   ` Nishanth Menon
2016-03-16  5:16                   ` Jassi Brar
2016-03-16  5:16                     ` Jassi Brar
2016-03-17  0:29                     ` Nishanth Menon [this message]
2016-03-17  0:29                       ` Nishanth Menon
2016-03-17  0:29                       ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E9FA7D.9050801@ti.com \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.