From: Kamezawa Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
To: Zhao Lei <zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Mateusz Guzik <mguzik-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH 0/2] Make core_pattern support namespace
Date: Thu, 17 Mar 2016 09:57:32 +0900 [thread overview]
Message-ID: <56EA00FC.3030800@jp.fujitsu.com> (raw)
In-Reply-To: <cover.1458119582.git.zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
On 2016/03/16 18:23, Zhao Lei wrote:
> We discussed patch titled:
> [PATCH] Make core_pattern support namespace
> before.
>
> Above patch can solve half problem of custom core_dump pattern
> in container, but there are also another problem that limit
> custom core_pattern in container, it is the pipe-type core_pattern
> will write core dump into host's filesystem.
> (See discussion of that patch for detail)
>
> Now we can solve the second problem by [PATCH 1/2], I send
> the origional patch with it.
>
Let me know your design...
This patch does using fork+execve() rather than calling UMH in pipe-coredump pass.
And coredump-pipe process is run as a child of get-dumped process.
Right ?
Doesn't this break existing solution actually used in distro ?
BTW, it's first time for me to see that _do_fork() is called outside from fork.c.
Isn't it better to add a new func in fork.c if we really need this ?
Thanks,
-Kame
WARNING: multiple messages have this Message-ID (diff)
From: Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Zhao Lei <zhaolei@cn.fujitsu.com>,
linux-kernel@vger.kernel.org, Mateusz Guzik <mguzik@redhat.com>
Cc: containers@lists.linux-foundation.org
Subject: Re: [PATCH 0/2] Make core_pattern support namespace
Date: Thu, 17 Mar 2016 09:57:32 +0900 [thread overview]
Message-ID: <56EA00FC.3030800@jp.fujitsu.com> (raw)
In-Reply-To: <cover.1458119582.git.zhaolei@cn.fujitsu.com>
On 2016/03/16 18:23, Zhao Lei wrote:
> We discussed patch titled:
> [PATCH] Make core_pattern support namespace
> before.
>
> Above patch can solve half problem of custom core_dump pattern
> in container, but there are also another problem that limit
> custom core_pattern in container, it is the pipe-type core_pattern
> will write core dump into host's filesystem.
> (See discussion of that patch for detail)
>
> Now we can solve the second problem by [PATCH 1/2], I send
> the origional patch with it.
>
Let me know your design...
This patch does using fork+execve() rather than calling UMH in pipe-coredump pass.
And coredump-pipe process is run as a child of get-dumped process.
Right ?
Doesn't this break existing solution actually used in distro ?
BTW, it's first time for me to see that _do_fork() is called outside from fork.c.
Isn't it better to add a new func in fork.c if we really need this ?
Thanks,
-Kame
next prev parent reply other threads:[~2016-03-17 0:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 9:23 [PATCH 0/2] Make core_pattern support namespace Zhao Lei
2016-03-16 9:23 ` Zhao Lei
[not found] ` <cover.1458119582.git.zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-03-16 9:23 ` [PATCH 1/2] Run dump pipe in container's namespace Zhao Lei
2016-03-16 9:23 ` Zhao Lei
[not found] ` <f27cec06b90060f2c32691c432f624584f95d251.1458119582.git.zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org>
2016-03-16 9:43 ` kbuild test robot
2016-03-16 9:43 ` kbuild test robot
2016-03-16 9:23 ` [PATCH 2/2] Make core_pattern support namespace Zhao Lei
2016-03-16 9:23 ` Zhao Lei
2016-03-17 0:57 ` Kamezawa Hiroyuki [this message]
2016-03-17 0:57 ` [PATCH 0/2] " Kamezawa Hiroyuki
[not found] ` <56EA00FC.3030800-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2016-03-17 2:22 ` Zhao Lei
2016-03-17 2:22 ` Zhao Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EA00FC.3030800@jp.fujitsu.com \
--to=kamezawa.hiroyu-+cum20s59erqfuhtdcdx3a@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mguzik-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=zhaolei-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.