* [PATCH] drm/exynos: fimd: fix broken dp_clock control
@ 2016-03-17 6:53 Marek Szyprowski
2016-03-17 7:19 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Marek Szyprowski @ 2016-03-17 6:53 UTC (permalink / raw)
To: dri-devel, linux-samsung-soc
Cc: Krzysztof Kozlowski, Javier Martinez Canillas,
Bartlomiej Zolnierkiewicz, Seung-Woo Kim, Andrzej Hajda,
Chanho Park, Marek Szyprowski
Commit 1feafd3afd294b03dbbedb8e8f94e0c4db526f10 ("drm/exynos: add
exynos5420 support for fimd") add support for Exynos 5420 SoC, but it
broke enabling display clock feature because of incorrect condition
check. This patch fixes it, so display is working again on platforms
requiring display clock control (i.e. Exynos5250-based SNOW platform).
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
index 0a44511..c65fe79 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c
@@ -889,7 +889,7 @@ static void fimd_dp_clock_enable(struct exynos_drm_crtc *crtc, bool enable)
* clock. On these SoCs the bootloader may enable it but any
* power domain off/on will reset it to disable state.
*/
- if (ctx->driver_data != &exynos5_fimd_driver_data ||
+ if (ctx->driver_data != &exynos5_fimd_driver_data &&
ctx->driver_data != &exynos5420_fimd_driver_data)
return;
--
1.9.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/exynos: fimd: fix broken dp_clock control
2016-03-17 6:53 [PATCH] drm/exynos: fimd: fix broken dp_clock control Marek Szyprowski
@ 2016-03-17 7:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-17 7:19 UTC (permalink / raw)
To: Marek Szyprowski, dri-devel, linux-samsung-soc
Cc: Inki Dae, Joonyoung Shim, Seung-Woo Kim, Andrzej Hajda,
Chanho Park, Javier Martinez Canillas, Bartlomiej Zolnierkiewicz
On 17.03.2016 15:53, Marek Szyprowski wrote:
> Commit 1feafd3afd294b03dbbedb8e8f94e0c4db526f10 ("drm/exynos: add
The commit exists only in next so the SHA might be useless in case of
rebase of drm-exynos tree.
> exynos5420 support for fimd") add support for Exynos 5420 SoC, but it
> broke enabling display clock feature because of incorrect condition
> check. This patch fixes it, so display is working again on platforms
> requiring display clock control (i.e. Exynos5250-based SNOW platform).
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-17 7:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 6:53 [PATCH] drm/exynos: fimd: fix broken dp_clock control Marek Szyprowski
2016-03-17 7:19 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.