All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Li Zhijian <lizhijian@cn.fujitsu.com>,
	Zhang Chen <zhangchen.fnst@cn.fujitsu.com>,
	qemu devel <qemu-devel@nongnu.org>
Cc: Gui jianfeng <guijianfeng@cn.fujitsu.com>,
	Yang Hongyang <hongyang.yang@easystack.cn>,
	"eddie.dong" <eddie.dong@intel.com>,
	zhanghailiang <zhang.zhanghailiang@huawei.com>,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH V6 1/2] net/filter-mirror: implement filter-redirector
Date: Thu, 17 Mar 2016 15:59:13 +0800	[thread overview]
Message-ID: <56EA63D1.6060302@redhat.com> (raw)
In-Reply-To: <56EA61DD.6050005@cn.fujitsu.com>



On 03/17/2016 03:50 PM, Li Zhijian wrote:
>>
>> +static void filter_redirector_fini(Object *obj)
>> +{
>> +    MirrorState *s = FILTER_REDIRECTOR(obj);
>> +
>> +    qemu_chr_add_handlers(s->chr_in, NULL, NULL, NULL, NULL);
>
> hi, Jason
> Do we reset the chardev handler here is reasonable ?
> filter_redirector_fini() is destruction of filter_redirector_init()
> which we
> don't register handler.
>
> So, I think move the handler reset to filter_redirector_cleanup()
> would be better.
>
> Thanks
> Li 

Yes, please.

Thanks

  reply	other threads:[~2016-03-17  7:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17  7:32 [Qemu-devel] [PATCH V6 0/2] Introduce filter-redirector Zhang Chen
2016-03-17  7:32 ` [Qemu-devel] [PATCH V6 1/2] net/filter-mirror: implement filter-redirector Zhang Chen
2016-03-17  7:50   ` Li Zhijian
2016-03-17  7:59     ` Jason Wang [this message]
2016-03-17  7:32 ` [Qemu-devel] [PATCH V6 2/2] tests/test-filter-redirector: Add unit test for filter-redirector Zhang Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EA63D1.6060302@redhat.com \
    --to=jasowang@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=eddie.dong@intel.com \
    --cc=guijianfeng@cn.fujitsu.com \
    --cc=hongyang.yang@easystack.cn \
    --cc=lizhijian@cn.fujitsu.com \
    --cc=qemu-devel@nongnu.org \
    --cc=zhang.zhanghailiang@huawei.com \
    --cc=zhangchen.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.