* [Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec
@ 2016-03-17 9:11 piaojun
2016-03-17 9:23 ` Joseph Qi
2016-03-25 19:36 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: piaojun @ 2016-03-17 9:11 UTC (permalink / raw)
To: ocfs2-devel
Clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec.
Signed-off-by: Jun Piao <piaojun@huawei.com>
---
alloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/alloc.c b/alloc.c
index d002579..2b8b721 100644
--- a/alloc.c
+++ b/alloc.c
@@ -5334,7 +5334,7 @@ static int ocfs2_truncate_rec(handle_t *handle,
{
int ret;
u32 left_cpos, rec_range, trunc_range;
- int wants_rotate = 0, is_rightmost_tree_rec = 0;
+ int is_rightmost_tree_rec = 0;
struct super_block *sb = ocfs2_metadata_cache_get_super(et->et_ci);
struct ocfs2_path *left_path = NULL;
struct ocfs2_extent_list *el = path_leaf_el(path);
@@ -5431,7 +5431,6 @@ static int ocfs2_truncate_rec(handle_t *handle,
memset(rec, 0, sizeof(*rec));
ocfs2_cleanup_merge(el, index);
- wants_rotate = 1;
next_free = le16_to_cpu(el->l_next_free_rec);
if (is_rightmost_tree_rec && next_free > 1) {
--
1.8.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec
2016-03-17 9:11 [Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec piaojun
@ 2016-03-17 9:23 ` Joseph Qi
2016-03-25 19:36 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Joseph Qi @ 2016-03-17 9:23 UTC (permalink / raw)
To: ocfs2-devel
On 2016/3/17 17:11, piaojun wrote:
> Clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec.
>
> Signed-off-by: Jun Piao <piaojun@huawei.com>
Reviewed-by: Joseph Qi <joseph.qi@huawei.com>
> ---
> alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/alloc.c b/alloc.c
> index d002579..2b8b721 100644
> --- a/alloc.c
> +++ b/alloc.c
> @@ -5334,7 +5334,7 @@ static int ocfs2_truncate_rec(handle_t *handle,
> {
> int ret;
> u32 left_cpos, rec_range, trunc_range;
> - int wants_rotate = 0, is_rightmost_tree_rec = 0;
> + int is_rightmost_tree_rec = 0;
> struct super_block *sb = ocfs2_metadata_cache_get_super(et->et_ci);
> struct ocfs2_path *left_path = NULL;
> struct ocfs2_extent_list *el = path_leaf_el(path);
> @@ -5431,7 +5431,6 @@ static int ocfs2_truncate_rec(handle_t *handle,
>
> memset(rec, 0, sizeof(*rec));
> ocfs2_cleanup_merge(el, index);
> - wants_rotate = 1;
>
> next_free = le16_to_cpu(el->l_next_free_rec);
> if (is_rightmost_tree_rec && next_free > 1) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec
2016-03-17 9:11 [Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec piaojun
2016-03-17 9:23 ` Joseph Qi
@ 2016-03-25 19:36 ` Andrew Morton
2016-03-26 4:25 ` piaojun
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2016-03-25 19:36 UTC (permalink / raw)
To: ocfs2-devel
On Thu, 17 Mar 2016 17:11:27 +0800 piaojun <piaojun@huawei.com> wrote:
> Clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec.
>
> Signed-off-by: Jun Piao <piaojun@huawei.com>
> ---
> alloc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/alloc.c b/alloc.c
> index d002579..2b8b721 100644
> --- a/alloc.c
> +++ b/alloc.c
This should be
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
please. `patch -p1' form.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec
2016-03-25 19:36 ` Andrew Morton
@ 2016-03-26 4:25 ` piaojun
0 siblings, 0 replies; 4+ messages in thread
From: piaojun @ 2016-03-26 4:25 UTC (permalink / raw)
To: ocfs2-devel
Clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec.
Signed-off-by: Jun Piao <piaojun@huawei.com>
---
fs/ocfs2/alloc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/ocfs2/alloc.c b/fs/ocfs2/alloc.c
index d002579..2b8b721 100644
--- a/fs/ocfs2/alloc.c
+++ b/fs/ocfs2/alloc.c
@@ -5334,7 +5334,7 @@ static int ocfs2_truncate_rec(handle_t *handle,
{
int ret;
u32 left_cpos, rec_range, trunc_range;
- int wants_rotate = 0, is_rightmost_tree_rec = 0;
+ int is_rightmost_tree_rec = 0;
struct super_block *sb = ocfs2_metadata_cache_get_super(et->et_ci);
struct ocfs2_path *left_path = NULL;
struct ocfs2_extent_list *el = path_leaf_el(path);
@@ -5431,7 +5431,6 @@ static int ocfs2_truncate_rec(handle_t *handle,
memset(rec, 0, sizeof(*rec));
ocfs2_cleanup_merge(el, index);
- wants_rotate = 1;
next_free = le16_to_cpu(el->l_next_free_rec);
if (is_rightmost_tree_rec && next_free > 1) {
--
1.8.4.3
On 2016/3/26 3:36, Andrew Morton wrote:
> On Thu, 17 Mar 2016 17:11:27 +0800 piaojun <piaojun@huawei.com> wrote:
>
>> Clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec.
>>
>> Signed-off-by: Jun Piao <piaojun@huawei.com>
>> ---
>> alloc.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/alloc.c b/alloc.c
>> index d002579..2b8b721 100644
>> --- a/alloc.c
>> +++ b/alloc.c
>
> This should be
>
> --- a/fs/ocfs2/alloc.c
> +++ b/fs/ocfs2/alloc.c
>
> please. `patch -p1' form.
>
>
>
> .
>
I make a new patch according to your suggestion, thks.
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-26 4:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 9:11 [Ocfs2-devel] [PATCH] ocfs2: clean up an unused variable 'wants_rotate' in ocfs2_truncate_rec piaojun
2016-03-17 9:23 ` Joseph Qi
2016-03-25 19:36 ` Andrew Morton
2016-03-26 4:25 ` piaojun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.