All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Franklin S Cooper Jr." <fcooper@ti.com>
To: thierry.reding@gmail.com, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, bcousson@baylibre.com, tony@atomide.com,
	linux@arm.linux.org.uk, paul@pwsan.com,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, vigneshr@ti.com
Subject: Re: [PATCH v5 1/6] pwms: pwm-ti*: Get the clock from the PWMSS (parent)
Date: Thu, 17 Mar 2016 17:37:18 -0500	[thread overview]
Message-ID: <56EB319E.3050502@ti.com> (raw)
In-Reply-To: <1457400224-24797-2-git-send-email-fcooper@ti.com>

Gentle ping on this

On 03/07/2016 07:23 PM, Franklin S Cooper Jr wrote:
> The eCAP and ePWM doesn't have their own separate clocks. They simply
> utilize the clock provided directly by the PWMSS. Therefore, they simply
> need to grab a reference to their parent's clock.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  drivers/pwm/pwm-tiecap.c   | 2 +-
>  drivers/pwm/pwm-tiehrpwm.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> index 616af76..9418159 100644
> --- a/drivers/pwm/pwm-tiecap.c
> +++ b/drivers/pwm/pwm-tiecap.c
> @@ -212,7 +212,7 @@ static int ecap_pwm_probe(struct platform_device *pdev)
>  	if (!pc)
>  		return -ENOMEM;
>  
> -	clk = devm_clk_get(&pdev->dev, "fck");
> +	clk = devm_clk_get(pdev->dev.parent, "fck");
>  	if (IS_ERR(clk)) {
>  		dev_err(&pdev->dev, "failed to get clock\n");
>  		return PTR_ERR(clk);
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
> index 6a41e66..09dc1bc 100644
> --- a/drivers/pwm/pwm-tiehrpwm.c
> +++ b/drivers/pwm/pwm-tiehrpwm.c
> @@ -443,7 +443,7 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
>  	if (!pc)
>  		return -ENOMEM;
>  
> -	clk = devm_clk_get(&pdev->dev, "fck");
> +	clk = devm_clk_get(pdev->dev.parent, "fck");
>  	if (IS_ERR(clk)) {
>  		dev_err(&pdev->dev, "failed to get clock\n");
>  		return PTR_ERR(clk);

WARNING: multiple messages have this Message-ID (diff)
From: fcooper@ti.com (Franklin S Cooper Jr.)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 1/6] pwms: pwm-ti*: Get the clock from the PWMSS (parent)
Date: Thu, 17 Mar 2016 17:37:18 -0500	[thread overview]
Message-ID: <56EB319E.3050502@ti.com> (raw)
In-Reply-To: <1457400224-24797-2-git-send-email-fcooper@ti.com>

Gentle ping on this

On 03/07/2016 07:23 PM, Franklin S Cooper Jr wrote:
> The eCAP and ePWM doesn't have their own separate clocks. They simply
> utilize the clock provided directly by the PWMSS. Therefore, they simply
> need to grab a reference to their parent's clock.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  drivers/pwm/pwm-tiecap.c   | 2 +-
>  drivers/pwm/pwm-tiehrpwm.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> index 616af76..9418159 100644
> --- a/drivers/pwm/pwm-tiecap.c
> +++ b/drivers/pwm/pwm-tiecap.c
> @@ -212,7 +212,7 @@ static int ecap_pwm_probe(struct platform_device *pdev)
>  	if (!pc)
>  		return -ENOMEM;
>  
> -	clk = devm_clk_get(&pdev->dev, "fck");
> +	clk = devm_clk_get(pdev->dev.parent, "fck");
>  	if (IS_ERR(clk)) {
>  		dev_err(&pdev->dev, "failed to get clock\n");
>  		return PTR_ERR(clk);
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
> index 6a41e66..09dc1bc 100644
> --- a/drivers/pwm/pwm-tiehrpwm.c
> +++ b/drivers/pwm/pwm-tiehrpwm.c
> @@ -443,7 +443,7 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
>  	if (!pc)
>  		return -ENOMEM;
>  
> -	clk = devm_clk_get(&pdev->dev, "fck");
> +	clk = devm_clk_get(pdev->dev.parent, "fck");
>  	if (IS_ERR(clk)) {
>  		dev_err(&pdev->dev, "failed to get clock\n");
>  		return PTR_ERR(clk);

WARNING: multiple messages have this Message-ID (diff)
From: "Franklin S Cooper Jr." <fcooper@ti.com>
To: <thierry.reding@gmail.com>, <robh+dt@kernel.org>,
	<pawel.moll@arm.com>, <mark.rutland@arm.com>,
	<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
	<bcousson@baylibre.com>, <tony@atomide.com>,
	<linux@arm.linux.org.uk>, <paul@pwsan.com>,
	<linux-pwm@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <vigneshr@ti.com>
Subject: Re: [PATCH v5 1/6] pwms: pwm-ti*: Get the clock from the PWMSS (parent)
Date: Thu, 17 Mar 2016 17:37:18 -0500	[thread overview]
Message-ID: <56EB319E.3050502@ti.com> (raw)
In-Reply-To: <1457400224-24797-2-git-send-email-fcooper@ti.com>

Gentle ping on this

On 03/07/2016 07:23 PM, Franklin S Cooper Jr wrote:
> The eCAP and ePWM doesn't have their own separate clocks. They simply
> utilize the clock provided directly by the PWMSS. Therefore, they simply
> need to grab a reference to their parent's clock.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>  drivers/pwm/pwm-tiecap.c   | 2 +-
>  drivers/pwm/pwm-tiehrpwm.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pwm/pwm-tiecap.c b/drivers/pwm/pwm-tiecap.c
> index 616af76..9418159 100644
> --- a/drivers/pwm/pwm-tiecap.c
> +++ b/drivers/pwm/pwm-tiecap.c
> @@ -212,7 +212,7 @@ static int ecap_pwm_probe(struct platform_device *pdev)
>  	if (!pc)
>  		return -ENOMEM;
>  
> -	clk = devm_clk_get(&pdev->dev, "fck");
> +	clk = devm_clk_get(pdev->dev.parent, "fck");
>  	if (IS_ERR(clk)) {
>  		dev_err(&pdev->dev, "failed to get clock\n");
>  		return PTR_ERR(clk);
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
> index 6a41e66..09dc1bc 100644
> --- a/drivers/pwm/pwm-tiehrpwm.c
> +++ b/drivers/pwm/pwm-tiehrpwm.c
> @@ -443,7 +443,7 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
>  	if (!pc)
>  		return -ENOMEM;
>  
> -	clk = devm_clk_get(&pdev->dev, "fck");
> +	clk = devm_clk_get(pdev->dev.parent, "fck");
>  	if (IS_ERR(clk)) {
>  		dev_err(&pdev->dev, "failed to get clock\n");
>  		return PTR_ERR(clk);

  reply	other threads:[~2016-03-17 22:37 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-08  1:23 [PATCH v5 0/6] ARM: am335x/am437x/dra7: Add PWM support for DRA7 Franklin S Cooper Jr
2016-03-08  1:23 ` Franklin S Cooper Jr
2016-03-08  1:23 ` [PATCH v5 1/6] pwms: pwm-ti*: Get the clock from the PWMSS (parent) Franklin S Cooper Jr
2016-03-08  1:23   ` Franklin S Cooper Jr
2016-03-17 22:37   ` Franklin S Cooper Jr. [this message]
2016-03-17 22:37     ` Franklin S Cooper Jr.
2016-03-17 22:37     ` Franklin S Cooper Jr.
2016-04-05  6:08   ` Sekhar Nori
2016-04-05  6:08     ` Sekhar Nori
2016-04-05  6:08     ` Sekhar Nori
2016-04-05 11:25     ` Franklin S Cooper Jr.
2016-04-05 11:25       ` Franklin S Cooper Jr.
2016-04-05 11:25       ` Franklin S Cooper Jr.
     [not found]       ` <5703A0C4.6010406-l0cyMroinI0@public.gmane.org>
2016-04-10 20:51         ` Paul Walmsley
2016-04-10 20:51           ` Paul Walmsley
2016-04-10 20:51           ` Paul Walmsley
     [not found]           ` <alpine.DEB.2.02.1604102048380.11457-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2016-04-11 11:49             ` Sekhar Nori
2016-04-11 11:49               ` Sekhar Nori
2016-04-11 11:49               ` Sekhar Nori
2016-04-11 12:45               ` Rob Herring
2016-04-11 12:45                 ` Rob Herring
2016-04-12  8:10                 ` Sekhar Nori
2016-04-12  8:10                   ` Sekhar Nori
     [not found] ` <1457400224-24797-1-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-08  1:23   ` [PATCH v5 2/6] ARM: dts: am437x/am33xx: Remove eCAP and ePWM hwmod properties Franklin S Cooper Jr
2016-03-08  1:23     ` Franklin S Cooper Jr
2016-03-08  1:23     ` Franklin S Cooper Jr
2016-03-08  6:55   ` [PATCH v5 0/6] ARM: am335x/am437x/dra7: Add PWM support for DRA7 Paul Walmsley
2016-03-08  6:55     ` Paul Walmsley
2016-03-08  6:55     ` Paul Walmsley
2016-03-08 17:04     ` Franklin S Cooper Jr.
2016-03-08 17:04       ` Franklin S Cooper Jr.
2016-03-08 17:04       ` Franklin S Cooper Jr.
2016-03-08  1:23 ` [PATCH v5 3/6] ARM: AM335x/AM437x: hwmod: Remove eQEP, ePWM and eCAP hwmod entries Franklin S Cooper Jr
2016-03-08  1:23   ` Franklin S Cooper Jr
     [not found]   ` <1457400224-24797-4-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-17 15:06     ` Rob Herring
2016-03-17 15:06       ` Rob Herring
2016-03-17 15:06       ` Rob Herring
2016-03-17 15:45       ` Franklin S Cooper Jr.
2016-03-17 15:45         ` Franklin S Cooper Jr.
2016-03-17 15:45         ` Franklin S Cooper Jr.
2016-03-17 19:04         ` Rob Herring
2016-03-17 19:04           ` Rob Herring
2016-03-08  1:23 ` [PATCH v5 4/6] ARM: OMAP2+: DRA7: Add hwmod entries for PWMSS Franklin S Cooper Jr
2016-03-08  1:23   ` Franklin S Cooper Jr
2016-03-08  6:45   ` Paul Walmsley
2016-03-08  6:45     ` Paul Walmsley
2016-04-10 18:57     ` Paul Walmsley
2016-04-10 18:57       ` Paul Walmsley
2016-03-08  1:23 ` [PATCH v5 5/6] ARM: dts: DRA7: Add TBCLK " Franklin S Cooper Jr
2016-03-08  1:23   ` Franklin S Cooper Jr
2016-04-11 20:21   ` Tony Lindgren
2016-04-11 20:21     ` Tony Lindgren
2016-04-11 20:27     ` Tony Lindgren
2016-04-11 20:27       ` Tony Lindgren
2016-03-08  1:23 ` [PATCH v5 6/6] ARM: dts: DRA7: Add dt nodes " Franklin S Cooper Jr
2016-03-08  1:23   ` Franklin S Cooper Jr
     [not found]   ` <1457400224-24797-7-git-send-email-fcooper-l0cyMroinI0@public.gmane.org>
2016-03-17 15:11     ` Rob Herring
2016-03-17 15:11       ` Rob Herring
2016-03-17 15:11       ` Rob Herring
2016-03-17 15:53       ` Franklin S Cooper Jr.
2016-03-17 15:53         ` Franklin S Cooper Jr.
2016-03-17 15:53         ` Franklin S Cooper Jr.
2016-04-11 20:21         ` Tony Lindgren
2016-04-11 20:21           ` Tony Lindgren
2016-04-19 16:20           ` Franklin S Cooper Jr.
2016-04-19 16:20             ` Franklin S Cooper Jr.
2016-04-19 16:20             ` Franklin S Cooper Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EB319E.3050502@ti.com \
    --to=fcooper@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=paul@pwsan.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.