From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: drjones@redhat.com, dgibson@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH 3/5] powerpc: check 64bit mode
Date: Fri, 18 Mar 2016 08:28:33 +0000 [thread overview]
Message-ID: <56EBBC31.6010301@redhat.com> (raw)
In-Reply-To: <1458141183-27207-4-git-send-email-lvivier@redhat.com>
On 16.03.2016 16:13, Laurent Vivier wrote:
> Check in MSR if the SF bit is set (64bit mode is enabled)
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> powerpc/emulator.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/powerpc/emulator.c b/powerpc/emulator.c
> index 1215c4f..b66c1d7 100644
> --- a/powerpc/emulator.c
> +++ b/powerpc/emulator.c
> @@ -32,12 +32,26 @@ static void test_illegal(void)
> report_prefix_pop();
> }
>
> +static void test_64bit(void)
> +{
> + uint64_t msr;
> +
> + report_prefix_push("64bit");
> +
> + asm("mfmsr %[msr]": [msr] "=r" (msr));
> +
> + report("detected", msr & 0x8000000000000000UL);
> +
> + report_prefix_pop();
> +}
> +
> int main(void)
> {
> handle_exception(0x700, program_check_handler, (void *)&is_invalid);
>
> report_prefix_push("emulator");
>
> + test_64bit();
> test_illegal();
>
> report_prefix_pop();
Reviewed-by: Thomas Huth <thuth@redhat.com>
But I still wonder how kvm-unit-tests worked at all before the 64-bit
mode has been fixed in QEMU ... I mean kvm-unit-tests is compiled with
64-bit code, but it's still working when run in 32-bit? Something really
strange was going on here...
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: drjones@redhat.com, dgibson@redhat.com, pbonzini@redhat.com
Subject: Re: [kvm-unit-tests PATCH 3/5] powerpc: check 64bit mode
Date: Fri, 18 Mar 2016 09:28:33 +0100 [thread overview]
Message-ID: <56EBBC31.6010301@redhat.com> (raw)
In-Reply-To: <1458141183-27207-4-git-send-email-lvivier@redhat.com>
On 16.03.2016 16:13, Laurent Vivier wrote:
> Check in MSR if the SF bit is set (64bit mode is enabled)
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> powerpc/emulator.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/powerpc/emulator.c b/powerpc/emulator.c
> index 1215c4f..b66c1d7 100644
> --- a/powerpc/emulator.c
> +++ b/powerpc/emulator.c
> @@ -32,12 +32,26 @@ static void test_illegal(void)
> report_prefix_pop();
> }
>
> +static void test_64bit(void)
> +{
> + uint64_t msr;
> +
> + report_prefix_push("64bit");
> +
> + asm("mfmsr %[msr]": [msr] "=r" (msr));
> +
> + report("detected", msr & 0x8000000000000000UL);
> +
> + report_prefix_pop();
> +}
> +
> int main(void)
> {
> handle_exception(0x700, program_check_handler, (void *)&is_invalid);
>
> report_prefix_push("emulator");
>
> + test_64bit();
> test_illegal();
>
> report_prefix_pop();
Reviewed-by: Thomas Huth <thuth@redhat.com>
But I still wonder how kvm-unit-tests worked at all before the 64-bit
mode has been fixed in QEMU ... I mean kvm-unit-tests is compiled with
64-bit code, but it's still working when run in 32-bit? Something really
strange was going on here...
Thomas
next prev parent reply other threads:[~2016-03-18 8:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 15:12 [kvm-unit-tests PATCH 0/5] Check emulation Laurent Vivier
2016-03-16 15:12 ` Laurent Vivier
2016-03-16 15:12 ` [kvm-unit-tests PATCH 1/5] powerpc: add exception handler Laurent Vivier
2016-03-16 15:12 ` Laurent Vivier
2016-03-18 3:59 ` David Gibson
2016-03-18 3:59 ` David Gibson
2016-03-18 8:53 ` Laurent Vivier
2016-03-18 8:53 ` Laurent Vivier
2016-03-18 9:42 ` Thomas Huth
2016-03-18 9:42 ` Thomas Huth
2016-03-16 15:13 ` [kvm-unit-tests PATCH 2/5] powerpc: add test to check invalid instruction trap Laurent Vivier
2016-03-16 15:13 ` Laurent Vivier
2016-03-18 9:51 ` Thomas Huth
2016-03-18 9:51 ` Thomas Huth
2016-03-18 10:08 ` Laurent Vivier
2016-03-18 10:08 ` Laurent Vivier
2016-03-18 10:12 ` Thomas Huth
2016-03-18 10:12 ` Thomas Huth
2016-03-16 15:13 ` [kvm-unit-tests PATCH 3/5] powerpc: check 64bit mode Laurent Vivier
2016-03-16 15:13 ` Laurent Vivier
2016-03-18 8:28 ` Thomas Huth [this message]
2016-03-18 8:28 ` Thomas Huth
2016-03-18 8:38 ` Paul Mackerras
2016-03-18 8:38 ` Paul Mackerras
2016-03-18 8:41 ` Thomas Huth
2016-03-18 8:41 ` Thomas Huth
2016-03-16 15:13 ` [kvm-unit-tests PATCH 4/5] powerpc: check lswx Laurent Vivier
2016-03-16 15:13 ` Laurent Vivier
2016-03-18 9:09 ` Thomas Huth
2016-03-18 9:09 ` Thomas Huth
2016-03-18 10:01 ` Laurent Vivier
2016-03-18 10:01 ` Laurent Vivier
2016-03-18 10:06 ` Thomas Huth
2016-03-18 10:06 ` Thomas Huth
2016-03-18 10:18 ` Laurent Vivier
2016-03-18 10:18 ` Laurent Vivier
2016-03-18 10:34 ` Thomas Huth
2016-03-18 10:34 ` Thomas Huth
2016-03-16 15:13 ` [kvm-unit-tests PATCH 5/5] powerpc: Check lswx in little-endian mode Laurent Vivier
2016-03-16 15:13 ` Laurent Vivier
2016-03-18 9:54 ` Thomas Huth
2016-03-18 9:54 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EBBC31.6010301@redhat.com \
--to=thuth@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.