From: Johann Obermayr <johann.obermayr@sigmatek.at>
To: xenomai@xenomai.org
Subject: [Xenomai] ipipe bug in gpio/irq for mx6
Date: Fri, 18 Mar 2016 11:43:26 +0100 [thread overview]
Message-ID: <56EBDBCE.3030800@sigmatek.at> (raw)
Hello,
in the the git branch ipipe-3.0-imx6q
in the file arch/arm/plat-mxc/gpio.c
there is follow function.
void __ipipe_mach_enable_irqdesc(struct ipipe_domain *ipd, unsigned irq)
{
struct irq_desc *desc = irq_to_desc(irq);
struct irq_data *idata = irq_desc_get_irq_data(desc);
struct irq_chip *chip = irq_data_get_irq_chip(idata);
if (chip == &gpio_irq_chip) {
/* It is a gpio. */
u32 gpio = irq_to_gpio(irq);
struct mxc_gpio_port *port = &mxc_gpio_ports[gpio / 32];
if (ipd != &ipipe_root) {
port->nonroot_gpios |= (1 << (gpio % 32));
if (port->nonroot_gpios == (1 << (gpio % 32))) {
__ipipe_irqbits[(port->irq / 32)]
&= ~(1 << (port->irq % 32));
set_irq_prio(port->irq, 1);
}
}
} else
set_irq_prio(irq, ipd != &ipipe_root);
}
But there is missing set_irq_prio for the port->irq_high.
to add
if (port->irq_high > 0)
set_irq_prio(port->irq_high, 1);
is not my problem.
my problem is, that i don't known if __ipipe_irqbits is handled correct.
regards
Johann
next reply other threads:[~2016-03-18 10:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 10:43 Johann Obermayr [this message]
2016-03-18 11:10 ` [Xenomai] ipipe bug in gpio/irq for mx6 Gilles Chanteperdrix
2016-03-18 12:15 ` Johann Obermayr
2016-03-18 12:28 ` Gilles Chanteperdrix
2016-03-23 11:01 ` Johann Obermayr
2016-03-23 11:12 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EBDBCE.3030800@sigmatek.at \
--to=johann.obermayr@sigmatek.at \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.