All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
To: Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
	jarkko.nikula-FVTvWyuFUl3QT0dZR+AlfA@public.gmane.org,
	t-kristo-l0cyMroinI0@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone
Date: Mon, 21 Mar 2016 10:57:56 +0200	[thread overview]
Message-ID: <56EFB794.5010505@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1603191937430.6629-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>

Paul,

On 03/19/16 21:38, Paul Walmsley wrote:
> On Fri, 18 Mar 2016, Peter Ujfalusi wrote:
> 
>> Hi,
>>
>> Chanes since v1:
>> - removed the ASoC patch as Mark has applied it already
>> - Added my signed-off to the hwmod patch
>> - New patch to handle the case when the sidetone hwmod has been removed for
>>   legacy boot.
>>
>> The series addresses a long standing issue with McBSP2/3 regarding to hwmod
>> setup. When booting with DT a warning is printed that mcbsp2/3 is using two
>> hwmod.
>> The root of the issue is the way how the hwmod data was constructed in the first
>> place for OMAP3 McBSP2/3.
>> After re-reading the TRM it is clear that the sidetone should not have it's
>> own hwmod data as it is not a separate IP, it is part of the McBSP module. It
>> can not affect PRCM either since it's SYSCONFIG register's AUTOIDLE bit is only
>> sets the autoidle from the internal McBSP_iclk clock to the sidetone block of
>> the same McBSP.
> 
> NAK, at least without further discussion - see my comments on the v1 0/3 
> introduction.

Yes, I could have sent the first series as RFC, but I believe(d) that this is
the correct way to fix the McBSP sidetone integration.

-- 
Péter
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone
Date: Mon, 21 Mar 2016 10:57:56 +0200	[thread overview]
Message-ID: <56EFB794.5010505@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1603191937430.6629@utopia.booyaka.com>

Paul,

On 03/19/16 21:38, Paul Walmsley wrote:
> On Fri, 18 Mar 2016, Peter Ujfalusi wrote:
> 
>> Hi,
>>
>> Chanes since v1:
>> - removed the ASoC patch as Mark has applied it already
>> - Added my signed-off to the hwmod patch
>> - New patch to handle the case when the sidetone hwmod has been removed for
>>   legacy boot.
>>
>> The series addresses a long standing issue with McBSP2/3 regarding to hwmod
>> setup. When booting with DT a warning is printed that mcbsp2/3 is using two
>> hwmod.
>> The root of the issue is the way how the hwmod data was constructed in the first
>> place for OMAP3 McBSP2/3.
>> After re-reading the TRM it is clear that the sidetone should not have it's
>> own hwmod data as it is not a separate IP, it is part of the McBSP module. It
>> can not affect PRCM either since it's SYSCONFIG register's AUTOIDLE bit is only
>> sets the autoidle from the internal McBSP_iclk clock to the sidetone block of
>> the same McBSP.
> 
> NAK, at least without further discussion - see my comments on the v1 0/3 
> introduction.

Yes, I could have sent the first series as RFC, but I believe(d) that this is
the correct way to fix the McBSP sidetone integration.

-- 
P?ter

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: <tony@atomide.com>, <jarkko.nikula@bitmer.com>, <t-kristo@ti.com>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone
Date: Mon, 21 Mar 2016 10:57:56 +0200	[thread overview]
Message-ID: <56EFB794.5010505@ti.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1603191937430.6629@utopia.booyaka.com>

Paul,

On 03/19/16 21:38, Paul Walmsley wrote:
> On Fri, 18 Mar 2016, Peter Ujfalusi wrote:
> 
>> Hi,
>>
>> Chanes since v1:
>> - removed the ASoC patch as Mark has applied it already
>> - Added my signed-off to the hwmod patch
>> - New patch to handle the case when the sidetone hwmod has been removed for
>>   legacy boot.
>>
>> The series addresses a long standing issue with McBSP2/3 regarding to hwmod
>> setup. When booting with DT a warning is printed that mcbsp2/3 is using two
>> hwmod.
>> The root of the issue is the way how the hwmod data was constructed in the first
>> place for OMAP3 McBSP2/3.
>> After re-reading the TRM it is clear that the sidetone should not have it's
>> own hwmod data as it is not a separate IP, it is part of the McBSP module. It
>> can not affect PRCM either since it's SYSCONFIG register's AUTOIDLE bit is only
>> sets the autoidle from the internal McBSP_iclk clock to the sidetone block of
>> the same McBSP.
> 
> NAK, at least without further discussion - see my comments on the v1 0/3 
> introduction.

Yes, I could have sent the first series as RFC, but I believe(d) that this is
the correct way to fix the McBSP sidetone integration.

-- 
Péter

  parent reply	other threads:[~2016-03-21  8:57 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 14:23 [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone Peter Ujfalusi
2016-03-18 14:23 ` Peter Ujfalusi
2016-03-18 14:23 ` Peter Ujfalusi
2016-03-18 14:23 ` [PATCH v2 1/3] ARM: DTS: omap3: Remove mcbsp2/3_sidetone hwmod reference for McBSP2/3 Peter Ujfalusi
2016-03-18 14:23   ` Peter Ujfalusi
2016-03-18 14:23   ` Peter Ujfalusi
2016-03-18 14:23 ` [PATCH v2 2/3] ARM: OMAP2+: mcbsp: Prepare the device build code for sidetone hwmod removal Peter Ujfalusi
2016-03-18 14:23   ` Peter Ujfalusi
2016-03-18 14:23   ` Peter Ujfalusi
2016-03-18 14:23 ` [PATCH v2 3/3] ARM: OMAP3: hwmod data: Merge and remove the McBSP sidetone related data Peter Ujfalusi
2016-03-18 14:23   ` Peter Ujfalusi
2016-03-18 14:23   ` Peter Ujfalusi
     [not found] ` <1458311007-19168-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2016-03-19 19:38   ` [PATCH v2 0/3] ARM: OMAP3: Fix McBSP2/3 hwmod setup for sidetone Paul Walmsley
2016-03-19 19:38     ` Paul Walmsley
2016-03-19 19:38     ` Paul Walmsley
     [not found]     ` <alpine.DEB.2.02.1603191937430.6629-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2016-03-21  8:57       ` Peter Ujfalusi [this message]
2016-03-21  8:57         ` Peter Ujfalusi
2016-03-21  8:57         ` Peter Ujfalusi
2016-03-21 17:44         ` Paul Walmsley
2016-03-21 17:44           ` Paul Walmsley
     [not found]           ` <alpine.DEB.2.02.1603211743200.31059-rwI8Ez+7Ko+d5PgPZx9QOdBPR1lH4CV8@public.gmane.org>
2016-04-01  9:33             ` Peter Ujfalusi
2016-04-01  9:33               ` Peter Ujfalusi
2016-04-01  9:33               ` Peter Ujfalusi
2016-04-02  0:17               ` Tony Lindgren
2016-04-02  0:17                 ` Tony Lindgren
2016-04-02  0:17                 ` Tony Lindgren
     [not found]                 ` <20160402001753.GR9329-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-04 12:45                   ` Peter Ujfalusi
2016-04-04 12:45                     ` Peter Ujfalusi
2016-04-04 12:45                     ` Peter Ujfalusi
2016-04-04 15:12                     ` Tony Lindgren
2016-04-04 15:12                       ` Tony Lindgren
2016-04-05 13:15                       ` Peter Ujfalusi
2016-04-05 13:15                         ` Peter Ujfalusi
2016-04-05 13:15                         ` Peter Ujfalusi
     [not found]                         ` <5703BA6B.1080208-l0cyMroinI0@public.gmane.org>
2016-04-11 21:28                           ` Tony Lindgren
2016-04-11 21:28                             ` Tony Lindgren
2016-04-11 21:28                             ` Tony Lindgren
     [not found]                             ` <20160411212845.GJ5995-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-12  9:52                               ` Peter Ujfalusi
2016-04-12  9:52                                 ` Peter Ujfalusi
2016-04-12  9:52                                 ` Peter Ujfalusi
2016-04-12 16:37                                 ` Tony Lindgren
2016-04-12 16:37                                   ` Tony Lindgren
2016-04-13 11:57                                   ` Peter Ujfalusi
2016-04-13 11:57                                     ` Peter Ujfalusi
2016-04-13 11:57                                     ` Peter Ujfalusi
2016-04-13 15:28                                     ` Tony Lindgren
2016-04-13 15:28                                       ` Tony Lindgren
2016-04-14  7:34                                       ` Peter Ujfalusi
2016-04-14  7:34                                         ` Peter Ujfalusi
2016-04-14  7:34                                         ` Peter Ujfalusi
2016-04-14 16:55                                         ` Tony Lindgren
2016-04-14 16:55                                           ` Tony Lindgren
2016-04-14 19:37                                           ` Peter Ujfalusi
2016-04-14 19:37                                             ` Peter Ujfalusi
2016-04-14 19:37                                             ` Peter Ujfalusi
2016-04-14 20:34                                             ` Tony Lindgren
2016-04-14 20:34                                               ` Tony Lindgren
2016-04-15 10:23                                               ` Peter Ujfalusi
2016-04-15 10:23                                                 ` Peter Ujfalusi
2016-04-15 10:23                                                 ` Peter Ujfalusi
     [not found]                                                 ` <5710C10A.6040908-l0cyMroinI0@public.gmane.org>
2016-04-15 15:16                                                   ` Tony Lindgren
2016-04-15 15:16                                                     ` Tony Lindgren
2016-04-15 15:16                                                     ` Tony Lindgren
     [not found]                                                     ` <20160415151651.GP5995-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-04-15 19:50                                                       ` Peter Ujfalusi
2016-04-15 19:50                                                         ` Peter Ujfalusi
2016-04-15 19:50                                                         ` Peter Ujfalusi
2016-04-18 23:51                                                         ` Tony Lindgren
2016-04-18 23:51                                                           ` Tony Lindgren
2016-04-22 13:12                                                           ` Peter Ujfalusi
2016-04-22 13:12                                                             ` Peter Ujfalusi
2016-04-22 13:12                                                             ` Peter Ujfalusi
     [not found]                                                             ` <571A2357.3060006-l0cyMroinI0@public.gmane.org>
2016-04-22 22:24                                                               ` Tony Lindgren
2016-04-22 22:24                                                                 ` Tony Lindgren
2016-04-22 22:24                                                                 ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EFB794.5010505@ti.com \
    --to=peter.ujfalusi-l0cymroini0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jarkko.nikula-FVTvWyuFUl3QT0dZR+AlfA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
    --cc=t-kristo-l0cyMroinI0@public.gmane.org \
    --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.