From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: drjones@redhat.com, dgibson@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 4/5] powerpc: check lswx
Date: Mon, 21 Mar 2016 14:25:53 +0000 [thread overview]
Message-ID: <56F00471.6070801@redhat.com> (raw)
In-Reply-To: <56EFE3EA.5000900@redhat.com>
On 21/03/2016 13:07, Thomas Huth wrote:
>> > + /* adding r1 in the clobber list doesn't protect it... */
> You repeat that again in the comment below, so in case you respin this
> series, you could also drop one of the two comments, I think.
I can do it while fixing the typo (arount->around).
Paolo
>> > + "mr r29,r1;"
>> > + "li r31,-1;"
>> > + "mr r1,r31;"
>> > + "mr r0, %[addr];"
>> > + "lswx r31, 0, r0;"
>> > + "std r31, 0*8(%[regs]);"
>> > + "std r0, 1*8(%[regs]);"
>> > + "std r1, 2*8(%[regs]);"
>> > + "mr r1,r29;"
>> > + ::
>> > + [len] "r" (12),
>> > + [addr] "r" (addr),
>> > + [regs] "r" (regs)
>> > + :
>> > + /* three registers from r31, wrap arount to r1,
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Cc: drjones@redhat.com, dgibson@redhat.com
Subject: Re: [kvm-unit-tests PATCH v2 4/5] powerpc: check lswx
Date: Mon, 21 Mar 2016 15:25:53 +0100 [thread overview]
Message-ID: <56F00471.6070801@redhat.com> (raw)
In-Reply-To: <56EFE3EA.5000900@redhat.com>
On 21/03/2016 13:07, Thomas Huth wrote:
>> > + /* adding r1 in the clobber list doesn't protect it... */
> You repeat that again in the comment below, so in case you respin this
> series, you could also drop one of the two comments, I think.
I can do it while fixing the typo (arount->around).
Paolo
>> > + "mr r29,r1;"
>> > + "li r31,-1;"
>> > + "mr r1,r31;"
>> > + "mr r0, %[addr];"
>> > + "lswx r31, 0, r0;"
>> > + "std r31, 0*8(%[regs]);"
>> > + "std r0, 1*8(%[regs]);"
>> > + "std r1, 2*8(%[regs]);"
>> > + "mr r1,r29;"
>> > + ::
>> > + [len] "r" (12),
>> > + [addr] "r" (addr),
>> > + [regs] "r" (regs)
>> > + :
>> > + /* three registers from r31, wrap arount to r1,
next prev parent reply other threads:[~2016-03-21 14:25 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 11:33 [kvm-unit-tests PATCH v2 0/5] Check emulation Laurent Vivier
2016-03-21 11:33 ` Laurent Vivier
2016-03-21 11:33 ` [kvm-unit-tests PATCH v2 1/5] powerpc: add exception handler Laurent Vivier
2016-03-21 11:33 ` Laurent Vivier
2016-03-21 23:47 ` David Gibson
2016-03-21 23:47 ` David Gibson
2016-03-21 11:33 ` [kvm-unit-tests PATCH v2 2/5] powerpc: add test to check invalid instruction trap Laurent Vivier
2016-03-21 11:33 ` Laurent Vivier
2016-03-21 14:57 ` Thomas Huth
2016-03-21 14:57 ` Thomas Huth
2016-03-21 23:49 ` David Gibson
2016-03-21 23:49 ` David Gibson
2016-03-21 11:33 ` [kvm-unit-tests PATCH v2 3/5] powerpc: check 64bit mode Laurent Vivier
2016-03-21 11:33 ` Laurent Vivier
2016-03-21 23:49 ` David Gibson
2016-03-21 23:49 ` David Gibson
2016-03-21 11:33 ` [kvm-unit-tests PATCH v2 4/5] powerpc: check lswx Laurent Vivier
2016-03-21 11:33 ` Laurent Vivier
2016-03-21 12:07 ` Thomas Huth
2016-03-21 12:07 ` Thomas Huth
2016-03-21 14:25 ` Paolo Bonzini [this message]
2016-03-21 14:25 ` Paolo Bonzini
2016-03-21 15:59 ` Laurent Vivier
2016-03-21 15:59 ` Laurent Vivier
2016-03-21 23:53 ` David Gibson
2016-03-21 23:53 ` David Gibson
2016-03-21 11:33 ` [kvm-unit-tests PATCH v2 5/5] powerpc: Check lswx in little-endian mode Laurent Vivier
2016-03-21 11:33 ` Laurent Vivier
2016-03-21 23:56 ` David Gibson
2016-03-21 23:56 ` David Gibson
2016-03-22 8:12 ` Thomas Huth
2016-03-22 8:12 ` Thomas Huth
2016-03-22 8:25 ` Laurent Vivier
2016-03-22 8:25 ` Laurent Vivier
2016-03-23 0:14 ` David Gibson
2016-03-23 0:14 ` David Gibson
2016-03-22 9:50 ` [kvm-unit-tests PATCH v2 0/5] Check emulation Paolo Bonzini
2016-03-22 9:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F00471.6070801@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.